From: David Howells <dhowells@redhat.com>
To: Eric Biggers <ebiggers3@gmail.com>
Cc: dhowells@redhat.com, keyrings@vger.kernel.org,
Michael Halcrow <mhalcrow@google.com>,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, Eric Biggers <ebiggers@google.com>
Subject: Re: [PATCH v2 1/3] KEYS: fix cred refcount leak in request_key_auth_new()
Date: Mon, 25 Sep 2017 15:18:57 +0100 [thread overview]
Message-ID: <30852.1506349137@warthog.procyon.org.uk> (raw)
In-Reply-To: <20170921205742.144596-2-ebiggers3@gmail.com>
Eric Biggers <ebiggers3@gmail.com> wrote:
> + rka = kzalloc(sizeof(*rka), GFP_KERNEL);
> + if (!rka)
> + goto error_free_rka;
But you haven't allocated an rka if you're in the error path. I'll fix that
to jump over the release.
David
prev parent reply other threads:[~2017-09-25 14:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 20:57 [PATCH v2 0/3] KEYS: fix error handling " Eric Biggers
2017-09-21 20:57 ` [PATCH v2 1/3] KEYS: fix cred refcount leak " Eric Biggers
2017-09-21 20:57 ` [PATCH v2 2/3] KEYS: don't revoke uninstantiated key " Eric Biggers
2017-09-21 20:57 ` [PATCH v2 3/3] KEYS: use kmemdup() " Eric Biggers
2017-09-25 14:14 ` [PATCH v2 2/3] KEYS: don't revoke uninstantiated key " David Howells
2017-09-25 14:18 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30852.1506349137@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=ebiggers3@gmail.com \
--cc=ebiggers@google.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mhalcrow@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®