From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=158.69.130.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795096186; b=QgQ9flOb/uAKUX5Xd21LSzJnPjKqYgbtM2VDI82Pa1qNzdfcv0P1DsbrRI/tjEu3wN/0 3C2D/d/FjmUVAzDPjYMKzhqxS3udICA0C7bWyy1jG42Yce4x1Qv6di3cXOn2uHfsyJTyR Nl2VMImqCZ/Aymb0UtO+tu4B851RPuANhSOVXOSgR2SVkh4mYrOVkD6BGaSnfZiXPow5Z plk1i9gZ646iJMeqmMbG8BaDuZX2w89GresqZyVdZlg/y/ugZ61nJ1j7AceeHe27sdckd 9+OFD7Iv4lMf+KYOxhVxD3DyOS89k780P9mzcXoLt6N+1j6Il9m0Laro/84hcamC1Bg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795096186; h=DMARC-Filter:DKIM-Signature:Received:From:To:Cc:Subject:Date: Message-Id:X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding; bh=RpH3Eqg7iYrUnR+bT4B28VRSM1FxKzR8GEzsrCXC1us=; b=KFyUd9M/YlFdjtMqhG9OmkT9tfzBTZdgDJpt7bv8SmAq3j9e6YjfNLGXaZoLBJhrUkt2 X1pO51YJDUvU8aG7Zrzfw+7D59xAb1dGjKmRrHiA9SWTOat6GOlN5LTbjQyUrl4vadPUF h1PUjd/BnET6aFpswmimSUY9aMpjA29lQNLlfyg7Nj0PYvpxDUMDRw1zlbE46xUZOMAG5 6z4Jzz3msbc7HJ7oyevOotzuLw1oyTrJJjzuSLgkpCSt2pwoOwkfQ8mteBFV2gu8xfiQH lgBRn2xh83Azzdb3o4wRjIjGW7FDKxHltF78/W89xZFLXSmb2/E/5/RPCKuUSaCnjnw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=efficios.com; spf=pass smtp.mailfrom=efficios.com; dkim=pass header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=smtpout1 header.b=RMWfKBA4; arc=none smtp.remote-ip=158.69.130.18 Received: from smtpout.efficios.com (smtpout.efficios.com [158.69.130.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF02D60A2614; Thu, 19 Nov 2026 13:49:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org CF02D60A2614 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=efficios.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=smtpout1 header.b=RMWfKBA4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=smtpout1; t=1795096184; bh=RpH3Eqg7iYrUnR+bT4B28VRSM1FxKzR8GEzsrCXC1us=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RMWfKBA4nGMb+GNjuzYdRrWuICJk8AFaw5hNkb3PUkT811bIEJ9ohGTpzAYAT1EKI siGFYPtSSHcqUOzZfNndTUBmMgaid0Zb91DiyzviGtNjud4FQjJFwufYCofCiljHhh kI/cTOX1ILJBnpb4x2RSRQjklbAiAoI51Dh+RwqcrFCryvjO8GDQH4lupOXsc97aY8 nc71QWR/Lx0Ny0RPCYHjTlpy3XDNn5H61ZS56mXo1oeYpaWzG77MR87yHZMgH1epjI 6XQu/LAflWI13aW2bQlt8ta1G8CLO5GvZGVydw/zZn+wO2jL+Z01RwHHPcYg4yMXeb LIINcyYl9Hxjw== Received: from thinkos.internal.efficios.com (mtl.efficios.com [216.120.195.104]) by smtpout.efficios.com (Postfix) with ESMTPSA id 4jVfwS3QhpzSPX; Thu, 19 Nov 2026 08:49:44 -0500 (EST) From: Mathieu Desnoyers To: juri.lelli@redhat.com, peterz@infradead.org, mingo@redhat.com, vincent.guittot@linaro.org Cc: linux-kernel@vger.kernel.org, Mathieu Desnoyers , tglx@kernel.org, will@kernel.org, boqun@kernel.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, kprateek.nayak@amd.com, luca.abeni@santannapisa.it, mathieu.poirier@linaro.org, longman@redhat.com, ridong.chen@linux.dev, tj@kernel.org, hannes@cmpxchg.org, mkoutny@suse.com, shuah@kernel.org, bigeasy@linutronix.de, clrkwllms@kernel.org, parri.andrea@gmail.com, m.szyprowski@samsung.com, kayracizmeci@gmail.com, weihengqiuu@gmail.com, cgroups@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-rt-devel@lists.linux.dev, stable@vger.kernel.org Subject: [PATCH v3 05/17] sched/deadline: Refuse dl_server debugfs writes while the rq is offline Date: Thu, 19 Nov 2026 08:49:28 -0500 Message-Id: <30870826885d7aa42b641d23701066e03b1a2b9b.1795092090.git.mathieu.desnoyers@efficios.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: References: X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Commit 4043f5498416 ("sched/deadline: Reject debugfs dl_server writes for offline CPUs") refuses a write to a dl_server's runtime or period on an offline CPU. Its message says that such a write has no meaningful semantics. It tests cpu_online(). But during hotplug the CPU is still online while it sits in the default root domain. This lasts from the rebuild in sched_cpu_deactivate() to the offline, and from the online to sched_cpu_activate(). That root domain does not count the server's bandwidth. A write in the window still goes through admission. With admission control off, it changes total_bw there. On v7.4-rc2, a write of the current value divides by zero in that window. The previous patch removes the division, not the write. Fix this by testing rq->online instead. It is set under the runqueue lock when the CPU joins a root domain that counts it, after cpu_active() is set. Test cpu_active() too. On the way down, it is cleared before rq->online. A write now fails with EBUSY while the CPU goes offline or comes online, as a write on an offline CPU already does. Writes at any other time are unchanged. Applied without the previous patch, this patch alone also stops the oops. The reproducer survives 20 rounds with no warning, in 3 VMs of 3. Fixes: d741f297bcea ("sched/fair: Fair server interface") Signed-off-by: Mathieu Desnoyers Reviewed-by: Juri Lelli Cc: stable@vger.kernel.org --- kernel/sched/debug.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c index e6a3b516c703..ddb382df454b 100644 --- a/kernel/sched/debug.c +++ b/kernel/sched/debug.c @@ -410,7 +410,16 @@ static ssize_t sched_server_write_common(struct file *filp, const char __user *u return -EINVAL; } - if (!cpu_online(cpu_of(rq))) + /* + * Refuse the write while the runqueue is offline. This + * includes the windows where the CPU goes offline or comes + * online. The root domain then does not count the server's + * bandwidth, and may have no active CPU. rq->online is set + * under this lock when the CPU joins a root domain that + * counts it. cpu_active() is set before that. On the way + * down, cpu_active() is cleared first. + */ + if (!rq->online || !cpu_active(cpu_of(rq))) return -EBUSY; update_rq_clock(rq); -- 2.47.3