From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=158.69.130.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795115239; b=QPJREbuGY2jcdowS4txJinA3CetDJHJEYFQaniuIF2lYHXM5RSXcJfz6AyYpViZZJbsD t+nOFWHwvPCRB12z5fhGdteF3Wlbkmnnc7HskG+cTfVypeur8QPAG8X/BgzInyI8eAaCO 4TJxTF1MnBuc+SrxZdruHYjgoSe0U/Y7ngPGGbPrXaL/s6K/+1kC3GrXXeCLxoRJvnpym LBsdsmmsSfZ6+LJ5jTe4hYqNotqpyEw8gdSIgn+BRv3oTY1tg95lbDuV06H7jWLNAGWiw zltlnu4CUcyY1Krs8RK1rR+Kn4YMc3eeFi3Va7+j9jLDrR23CCqaZ7nMJ5bkpEpY5vw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795115239; h=DMARC-Filter:DKIM-Signature:Received:From:To:Cc:Subject:Date: Message-Id:X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding; bh=RpH3Eqg7iYrUnR+bT4B28VRSM1FxKzR8GEzsrCXC1us=; b=fqHcP/JMpPtImDA3+zXjmtRhpjUevbvcqaANXQHA5phDLimMlM9WOUOgn0mBhPkXeHxZ HsDBZvuJYZYhivDCuxWqdUBq2J6YTepKnjFonwFl0hqTVYqXmrBWsaXJK93yYssp11bHb zGV06lgRED2h1D2OWunQDQlL+d0ZtE+6b3WxixuQY0DoHp4MF2N2VxxGRofUkWC21LG/h gVGlyxLJpV3vixXJf7X+UcnLQTe+zWPh1sv83buF8UCNoEQXaiKslNg8Vy/L/8+lzC6I/ 3+vfVr04SGyrII/eXfUJvFMNoSk08SZnwl2jEma1YJv1r7Fb37pL/d/NebD//Q4R64Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=efficios.com; spf=pass smtp.mailfrom=efficios.com; dkim=pass header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=smtpout1 header.b=UUCwOP5H; arc=none smtp.remote-ip=158.69.130.18 Received: from smtpout.efficios.com (smtpout.efficios.com [158.69.130.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31A9460A2614; Thu, 19 Nov 2026 19:07:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 31A9460A2614 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=efficios.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=smtpout1 header.b=UUCwOP5H DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=smtpout1; t=1795115237; bh=RpH3Eqg7iYrUnR+bT4B28VRSM1FxKzR8GEzsrCXC1us=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UUCwOP5HI2UfiHATfKl3XGkry+h9fJJRDSeRFUw95YDCfIBGUCqMbs+077BAWTTlU N7ut322DPBKyVaF0a9lOOVsLKvOefPYpHAvfWYoQiirJdgYA21Ty6/uex07nrESh2C 1DLXFr6U5prcB94vff1q8ga95HsD7KYl7xbzP76ydTR5Fau7CmN+Us/oiyJBD1Zsql oHxYk1rFZP1Rsjn2q1sHCi5i+ZW//XewcKo5OSZxVpcMPVba3fyF1lBWEPNmINIr/r v6SGsNbyNOcQ2u7DCZ6Muhdl88IO8bHc3/3VUguNEwsRhnfsTiBYzbD0mbJkrMdqqj 3Rypq0v0OCnpg== Received: from thinkos.internal.efficios.com (mtl.efficios.com [216.120.195.104]) by smtpout.efficios.com (Postfix) with ESMTPSA id 4jVnys5qzCzSF6; Thu, 19 Nov 2026 14:07:17 -0500 (EST) From: Mathieu Desnoyers To: juri.lelli@redhat.com, peterz@infradead.org, mingo@redhat.com, vincent.guittot@linaro.org Cc: Mathieu Desnoyers , tglx@kernel.org, will@kernel.org, boqun@kernel.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, kprateek.nayak@amd.com, luca.abeni@santannapisa.it, mathieu.poirier@linaro.org, longman@redhat.com, ridong.chen@linux.dev, tj@kernel.org, hannes@cmpxchg.org, mkoutny@suse.com, shuah@kernel.org, bigeasy@linutronix.de, clrkwllms@kernel.org, parri.andrea@gmail.com, m.szyprowski@samsung.com, kayracizmeci@gmail.com, weihengqiuu@gmail.com, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-rt-devel@lists.linux.dev, stable@vger.kernel.org Subject: [PATCH v5 05/17] sched/deadline: Refuse dl_server debugfs writes while the rq is offline Date: Thu, 19 Nov 2026 14:07:02 -0500 Message-Id: <30870826885d7aa42b641d23701066e03b1a2b9b.1795115075.git.mathieu.desnoyers@efficios.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: References: X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Commit 4043f5498416 ("sched/deadline: Reject debugfs dl_server writes for offline CPUs") refuses a write to a dl_server's runtime or period on an offline CPU. Its message says that such a write has no meaningful semantics. It tests cpu_online(). But during hotplug the CPU is still online while it sits in the default root domain. This lasts from the rebuild in sched_cpu_deactivate() to the offline, and from the online to sched_cpu_activate(). That root domain does not count the server's bandwidth. A write in the window still goes through admission. With admission control off, it changes total_bw there. On v7.4-rc2, a write of the current value divides by zero in that window. The previous patch removes the division, not the write. Fix this by testing rq->online instead. It is set under the runqueue lock when the CPU joins a root domain that counts it, after cpu_active() is set. Test cpu_active() too. On the way down, it is cleared before rq->online. A write now fails with EBUSY while the CPU goes offline or comes online, as a write on an offline CPU already does. Writes at any other time are unchanged. Applied without the previous patch, this patch alone also stops the oops. The reproducer survives 20 rounds with no warning, in 3 VMs of 3. Fixes: d741f297bcea ("sched/fair: Fair server interface") Signed-off-by: Mathieu Desnoyers Reviewed-by: Juri Lelli Cc: stable@vger.kernel.org --- kernel/sched/debug.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c index e6a3b516c703..ddb382df454b 100644 --- a/kernel/sched/debug.c +++ b/kernel/sched/debug.c @@ -410,7 +410,16 @@ static ssize_t sched_server_write_common(struct file *filp, const char __user *u return -EINVAL; } - if (!cpu_online(cpu_of(rq))) + /* + * Refuse the write while the runqueue is offline. This + * includes the windows where the CPU goes offline or comes + * online. The root domain then does not count the server's + * bandwidth, and may have no active CPU. rq->online is set + * under this lock when the CPU joins a root domain that + * counts it. cpu_active() is set before that. On the way + * down, cpu_active() is cleared first. + */ + if (!rq->online || !cpu_active(cpu_of(rq))) return -EBUSY; update_rq_clock(rq); -- 2.47.3