From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE0E0C433E3 for ; Sat, 18 Jul 2020 15:06:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B8E482067D for ; Sat, 18 Jul 2020 15:06:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727975AbgGRPGT (ORCPT ); Sat, 18 Jul 2020 11:06:19 -0400 Received: from smtprelay0163.hostedemail.com ([216.40.44.163]:40920 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726155AbgGRPGT (ORCPT ); Sat, 18 Jul 2020 11:06:19 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay04.hostedemail.com (Postfix) with ESMTP id 1BCCA180A8CA9; Sat, 18 Jul 2020 15:06:18 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: fear80_261175726f14 X-Filterd-Recvd-Size: 2490 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf13.hostedemail.com (Postfix) with ESMTPA; Sat, 18 Jul 2020 15:06:16 +0000 (UTC) Message-ID: <3093bc36c2ad86170e2e90a3451e5962d0815122.camel@perches.com> Subject: Re: [PATCH -next] net: ena: use NULL instead of zero From: Joe Perches To: Wang Hai , netanel@amazon.com, akiyano@amazon.com, gtzalik@amazon.com, saeedb@amazon.com, zorik@amazon.com, davem@davemloft.net, kuba@kernel.org, sameehj@amazon.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Sat, 18 Jul 2020 08:06:14 -0700 In-Reply-To: <20200718115633.37464-1-wanghai38@huawei.com> References: <20200718115633.37464-1-wanghai38@huawei.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.3-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2020-07-18 at 19:56 +0800, Wang Hai wrote: > Fix sparse build warning: > > drivers/net/ethernet/amazon/ena/ena_netdev.c:2193:34: warning: > Using plain integer as NULL pointer Better to remove the initialization altogether and move the declaration into the loop. > diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c [] > @@ -2190,7 +2190,7 @@ static void ena_del_napi_in_range(struct ena_adapter *adapter, > static void ena_init_napi_in_range(struct ena_adapter *adapter, > int first_index, int count) > { > - struct ena_napi *napi = {0}; > + struct ena_napi *napi = NULL; > int i; > > for (i = first_index; i < first_index + count; i++) { --- drivers/net/ethernet/amazon/ena/ena_netdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c index 91be3ffa1c5c..470d8f38b824 100644 --- a/drivers/net/ethernet/amazon/ena/ena_netdev.c +++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c @@ -2190,11 +2190,10 @@ static void ena_del_napi_in_range(struct ena_adapter *adapter, static void ena_init_napi_in_range(struct ena_adapter *adapter, int first_index, int count) { - struct ena_napi *napi = {0}; int i; for (i = first_index; i < first_index + count; i++) { - napi = &adapter->ena_napi[i]; + struct ena_napi *napi = &adapter->ena_napi[i]; netif_napi_add(adapter->netdev, &adapter->ena_napi[i].napi,