mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>,
	Linus Torvalds <torvalds@linux-foundation.org>
Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org,
	linux-afs@lists.infradead.org,
	"Pali Rohár" <pali.rohar@gmail.com>
Subject: Re: [PATCH] afs: proc cells and rootcell are writeable
Date: Fri, 31 Jan 2014 00:07:57 +0000	[thread overview]
Message-ID: <3099.1391126877@warthog.procyon.org.uk> (raw)
In-Reply-To: <8761p1m98f.fsf@xmission.com>

Eric W. Biederman <ebiederm@xmission.com> wrote:

> These files have been read-only since this code was merged in 2002.
> Over a decade of not being used seems like a strong indication that no
> one cares about the write path.

Actually, things aren't as simple as they seem.  Without the patch applied:

	[root@andromeda ~]# ls -l /proc/fs/afs/cells
	-r--r--r--. 1 root root 0 Jan 31 00:04 /proc/fs/afs/cells
	[root@andromeda ~]# echo add your-file-system.com 204.29.154.37 >/proc/fs/afs/cells
	[root@andromeda ~]# 

You'll observe there is no error reported on the echo command.

Further, looking in dmesg, I see:

	kAFS: Added new cell 'your-file-system.com'

So the file *is* writable, *despite* i_mode.

David

  parent reply	other threads:[~2014-01-31  0:08 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-26 12:27 David Howells
2014-01-26 19:23 ` Linus Torvalds
2014-01-26 20:19   ` Ingo Molnar
2014-01-26 20:22     ` Ingo Molnar
2014-01-26 20:25     ` Ingo Molnar
2014-01-28  8:39       ` Geert Uytterhoeven
2014-01-28 12:04         ` Ingo Molnar
2014-01-28 12:17           ` Geert Uytterhoeven
2014-01-28 12:20             ` Ingo Molnar
2014-01-28 17:34             ` Joe Perches
2014-01-28 20:20 ` David Howells
2014-01-28 20:27   ` Al Viro
2014-01-28 20:56   ` David Howells
2014-01-30 21:48 ` Eric W. Biederman
2014-01-30 21:50   ` Linus Torvalds
2014-01-30 22:15     ` Pali Rohár
2014-01-30 22:27       ` Linus Torvalds
2014-01-30 22:36         ` Dave Jones
2014-01-30 22:33       ` Russ Allbery
2014-01-31  0:21   ` David Howells
2014-01-31  0:28   ` David Howells
2014-01-31  0:31   ` David Howells
2014-01-31  0:07 ` David Howells [this message]
2014-01-31  0:20 ` David Howells
  -- strict thread matches above, loose matches on Subject: below --
2014-01-27 12:33 Alexey Dobriyan
2013-11-20 13:30 Pali Rohár
2013-12-10  8:02 ` Pali Rohár
2013-12-16  7:00 ` Andrew Morton
2013-12-17 13:19   ` Pali Rohár
2013-12-17 18:31 ` David Howells
2013-12-31  9:59   ` Pali Rohár

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3099.1391126877@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=ebiederm@xmission.com \
    --cc=linux-afs@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pali.rohar@gmail.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome