From: Jemmy Wong <jemmywong512@gmail.com>
To: Kayra Cizmeci <kayracizmeci@gmail.com>
Cc: Jemmy Wong <jemmywong512@gmail.com>,
sh_def@163.com, jstultz@google.com, bsegall@google.com,
dietmar.eggemann@arm.com, juri.lelli@redhat.com,
kprateek.nayak@amd.com, linux-kernel@vger.kernel.org,
mgorman@suse.de, mingo@redhat.com, peterz@infradead.org,
rostedt@goodmis.org, tim.c.chen@linux.intel.com,
vincent.guittot@linaro.org, vschneid@redhat.com
Subject: Re: [PATCH 0/3] sched: Fix proxy-exec use of curr and donor
Date: Fri, 9 Oct 2026 11:41:20 +0800 [thread overview]
Message-ID: <309FAB10-ACB0-4EFF-81B2-5E7906A00ECE@gmail.com> (raw)
In-Reply-To: <20261008153348.92684-1-kayracizmeci@gmail.com>
Hi Kayra,
Yes. My first patch and Hui's v5 2/4 and 3/4 move the NUMA and cache
ticks onto rq->curr when that task is fair. Hui's 1/4 is the right
shape: task_tick() runs the donor class and, when a proxy crosses
classes, the execution class as well. A fair lock holder whose donor
is RT or deadline still gets those hooks. My patch only changes
task_tick_fair(), so that case stays missing. I'll drop it.
The other two are not in that series.
task_sched_runtime() still flushes only when @p is the donor, through
@p->sched_class->update_curr(). update_se() adds the delta to rq->curr,
so a runtime read of the lock holder drops the open interval. The fix
flushes when @p is rq->curr, through the donor class's update_curr().
sched_can_stop_tick() still passes rq->curr to
cfs_task_bw_constrained(). sched_fair_update_stop_tick() already
passes the donor. The third patch makes those callers match. It does
not change the tick while a proxy is active, because both checks
return unless nr_running == 1.
Thanks,
Jemmy
> On Oct 8, 2026, at 11:33 PM, Kayra Cizmeci <kayracizmeci@gmail.com> wrote:
>
>> After the split between scheduling and execution context, update_se()
>> charges the open run interval to rq->curr. The tick and the runtime
>> sample still treated the donor as the task on CPU. Under proxy
>> execution the donor is blocked on a kernel mutex and the lock holder
>> is the task that runs.
>
> Please look at here: https://lore.kernel.org/lkml/20260913064722.1534766-1-sh_def@163.com/
>
> I think y'all are trying to fix the same thing, no? (Or atleast similar in most ways.)
>
> Adding Hui and John to CC.
>
> Thanks,
> Kayra
next prev parent reply other threads:[~2026-10-09 3:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 13:26 Jemmy Wong
2026-10-08 13:26 ` [PATCH 1/3] sched/fair: Drive NUMA and cache tick work from the execution context Jemmy Wong
2026-10-08 13:26 ` [PATCH 2/3] sched/core: Flush pending runtime for " Jemmy Wong
2026-10-08 13:26 ` [PATCH 3/3] sched/core: Check CFS bandwidth against the donor for NOHZ Jemmy Wong
2026-10-08 15:33 ` [PATCH 0/3] sched: Fix proxy-exec use of curr and donor Kayra Cizmeci
2026-10-09 3:41 ` Jemmy Wong [this message]
2026-10-09 4:07 ` Hui Su
2026-10-09 5:46 ` Jemmy Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=309FAB10-ACB0-4EFF-81B2-5E7906A00ECE@gmail.com \
--to=jemmywong512@gmail.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=jstultz@google.com \
--cc=juri.lelli@redhat.com \
--cc=kayracizmeci@gmail.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sh_def@163.com \
--cc=tim.c.chen@linux.intel.com \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®