From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0B8E3DE458 for ; Tue, 24 Mar 2026 10:00:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774346429; cv=none; b=aqfARfvff4XIJNUrd1S7vNKu4WunzBMEk3oag89tykHSVKrv33bWagEwWXubyUtYRQOt9lZkIIEX4ju1eYOjeJykcMul/WkcPUlf5i3oEqfGwjKtSPYeZnJz4aRNLPfD9Ofti2iVuPDgmBKzN3pJhWI/no4LXISITmRk2mmr7O8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774346429; c=relaxed/simple; bh=Ub6P1Xxwa05g0RZGfOEQxXEZuKj/fxHw4ztSk7ygSIQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bfIOuqBnPqZaRBkDcW8UbR5hFZElCbFJRwOowkZWyO/bLl1nxW2+6j8+qcphVV93hzOZ29zrjTjV5KcDaD/tBFDWkm7Di+NTRvOw1MChGK22auFg8I69NL+CNqnhi87ctC/fZbewBUnHjLUcR9TRO3GKfBcyEnutMC8pb4Lj++Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=CHKo1RTl; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RtdFwoFW; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="CHKo1RTl"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RtdFwoFW" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62O9wRUQ3039639 for ; Tue, 24 Mar 2026 10:00:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= WT0sxJjxN+LdXES7eWwHlBN7cn82bPNexx29FFsAMOU=; b=CHKo1RTllj9tQhcM wFF/NhldkqPtJ2AOWhf7AmsLXH8XXiEQqaz/zAjBPCfZDYm6Q8RIaQWRjt9kYyEZ UVaGhgkKFzuqOsgVIraZQjF5azCi4r/Pg+WRDDRb3eJllUYu/D7NGR+pOUszQwwp TNIbyfW0obMVUQwgCyvDFJwYUssTJx4pulfcOBUwgWddYWJ/gYS8UP5TTsPb1QeJ ghgKLUlbhxxxcblZmQr/s9D6wgqLTTt5uPn3EVYrtYv2CGUBEwMnIGfntcI7CsFR HCjXdbOIQsZNldfKhivZunvt11BcTXH13hMNlqpmo/3KuYFQiu2vSb5oQfYk7jyA +NDiVg== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d3rf0g09g-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 24 Mar 2026 10:00:26 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8cd97debc51so393305185a.1 for ; Tue, 24 Mar 2026 03:00:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774346426; x=1774951226; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WT0sxJjxN+LdXES7eWwHlBN7cn82bPNexx29FFsAMOU=; b=RtdFwoFWbtc0IL9kwOgBFOaVv6lgIYAZrLbPbb7D6XkpXlEcaUglE1DChJuF8j0GgR o0KZsgkIFLOebq5nT3dAbjlM0ZiiaJstg6dnXSuzXnKmVOscfjtHo5WA29LsAUpGTC1u yZAKCci00v4mtniAdCeNv+2JHni1Lp56GdyZjBiIklp9nn3s52Hn2sQ2M+Ag0rZZk/Er VuehKq5Hp7fdTztCqJDbz47+o1YNPQ0JEH0YnN35Dc+2MSvZq8GRr6omuHyf1bCxde2P 3TFfSZmcA9IF8XPGY/MizQ3nFsX622Lvum2oD1P+XbiiaQh/jnEtWCou3Ld0MeuaFsWN K8tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774346426; x=1774951226; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WT0sxJjxN+LdXES7eWwHlBN7cn82bPNexx29FFsAMOU=; b=htj1DYkjGFsMc67L8p+UqwI3g615sbTL0Jb+xEoKrZYbynwGAbhSiwdY9YB9MNE4gk wkLiwaXSQny9lodV3JNmK/KRNTGltl1SnWmoxJppA6TG4dKNLUKlIsYrBroRaKfVT0o9 x290YHu16H21/KSGVwyXa6kF53ElkkAa8LeY5A2KPKEKaOBhy0kv0YsVSyalzxQ2CHDK k0sTOXQScxxO0tcxGz7cS8PXyM7cRgpDmn/tuB7fc9yOEky2/WwZQfprtjR+0YTVm+Kt 2VEoYuCgW3odNWpL8NU/VBqDrE0x6UTVjJ3jxON5Ue1Lk7bYdAW0WvdK4AuFlbv8N56h NnCA== X-Forwarded-Encrypted: i=1; AJvYcCVyC1oNVv4TAzegEvSO8E0geVE8+v8YFhBcAFzI+xBvxKtnsI85apyrJ1LLXXM/j2kKTAxpk4p7yMydWRk=@vger.kernel.org X-Gm-Message-State: AOJu0YzJjDrnljndz4G3HoQf59lGWlnpvl68UealLb7M9ElmTvAKKxmu IAB04Y+hO9213kfVyi9vz7ev/Y2QbevC7On7e/4mjxgkFH2w0I3c7uzIpD81SODi8NCyaQavPIz ofN1PQQZj8eMbTXBgzcxy5axBemHMeJ/EBGM/oHs7r3OUrMHqBrmbocKaItdAz9Bf0QQ= X-Gm-Gg: ATEYQzwIWzYxkH/E4mQN7Flxj6SM5ZKNfU6gX6IxOI8m4PDNwN4cHKlZs9JZlK3TjiQ pT8QRdBtA+Qet3GV9YuoVfESHIASBPQ6dL2ZxqYKgT2POnU7TbqMJDHNoIGPVE4CModw9ucPCbl QSS0fqDlAYBXKLoIwdIKlsIiJnUj3qBH2K/GbOgN2GJ+jnDz7tNIFFU1ysv9WeSNMrQ5DCzU3ey FoLBwXNVpTcIl1LdlHsPH5rerlvZdSjQah6Ah1nEHjf8TgukroRQ07wBy2lNV+huvpPRutG375z +Nfs9IkEN+Q8pHe6T0atzbjt3Gd41XYvfjHQmfm3mx87Ce8mm6Yv3dEDMFbMgMxn1bdzqsGfi2/ RerrHBhMKLvuWcKBDRmgWnO9s03UGEOSDJLaDWcutgFweAJOX9dQYiHROjCCu/qzlQCUm4ikihE Q1RPQ= X-Received: by 2002:a05:620a:294f:b0:8cf:df37:4f6c with SMTP id af79cd13be357-8cfdf375316mr1003164485a.5.1774346425737; Tue, 24 Mar 2026 03:00:25 -0700 (PDT) X-Received: by 2002:a05:620a:294f:b0:8cf:df37:4f6c with SMTP id af79cd13be357-8cfdf375316mr1003153185a.5.1774346424857; Tue, 24 Mar 2026 03:00:24 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-66a5f017c83sm119090a12.3.2026.03.24.03.00.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Mar 2026 03:00:23 -0700 (PDT) Message-ID: <30a4cdad-47c0-43f0-9327-04c28eac52ae@oss.qualcomm.com> Date: Tue, 24 Mar 2026 11:00:19 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 08/16] drm/msm/a6xx: Update HFI definitions To: Akhil P Oommen , Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Antonino Maniscalco , Connor Abbott , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260324-a8xx-gpu-batch2-v1-0-fc95b8d9c017@oss.qualcomm.com> <20260324-a8xx-gpu-batch2-v1-8-fc95b8d9c017@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260324-a8xx-gpu-batch2-v1-8-fc95b8d9c017@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI0MDA3OSBTYWx0ZWRfX1ZYRHwJS3orR K4JG9giyb0uSbxGt0br0iyzvoJiAfl+s+EfLPiANdTqFU8PhSdFu22L0wVkWBKsgEc8OZnZYmtr SaR8gVVzx2ZEMJKA8qMoxjZcdVkHvFktFs0oNrSOZhJC9vzgRtJAzzI0TPJxdcL9Pgx8flt/QpH TORvdPl8OCsKD7hWy0kDs2bl6YwE66E8cRKvhkO8ELQYAPgw4thVexvk5oz4ya1qd6uYyqiPX1/ DsF6vaDEkRYyWTaBganWtymTxc9yE+Xd4igsoQAU0uRyBnJsNixwAUiRekAfEc95LQg2vIXjQ6R ychjinqAzIBBog2RC5GySkdV+5VYzI6BI9ZHBIL3OCpJa7uryWeLMS57Co9EkIKOsfrdLzeMl86 lRyRX6d1nbUcYrcmu+3ceZNpr6NWb4nK/djdW6x5/KSp7LLeAp6wJVMEOrdExjiCmvjNzSuKYzU rhn77MjPwpqn3my92Cw== X-Authority-Analysis: v=2.4 cv=Ua9ciaSN c=1 sm=1 tr=0 ts=69c260ba cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=yXWzbejlfdbuXM6ywS4A:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-ORIG-GUID: N9KMA8s4Q6_aipfwQ4Nei_MAXILcgOmY X-Proofpoint-GUID: N9KMA8s4Q6_aipfwQ4Nei_MAXILcgOmY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-24_02,2026-03-23_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 suspectscore=0 clxscore=1015 impostorscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603240079 On 3/23/26 9:12 PM, Akhil P Oommen wrote: > Update the HFI definitions to support additional GMU based power > features. > > Signed-off-by: Akhil P Oommen > --- [...] > +#define CLX_DATA(irated, num_phases, clx_path, extd_intf) \ > + ((extd_intf << 29) | \ > + (clx_path << 28) | \ > + (num_phases << 22) | \ > + (irated << 16)) > + > +struct a6xx_hfi_clx_domain_v2 { > + /** > + * @data: BITS[0:15] Migration time > + * BITS[16:21] Current rating > + * BITS[22:27] Phases for domain > + * BITS[28:28] Path notification > + * BITS[29:31] Extra features > + */ My first thought would be to define these as bitfields, i.e. u16 mitigation_time u8 current_rating : 6; u8 num_phases : 6; u8 path_notification : 1; u8 extra_features : 3; (hopefully I counted them right) You would then not need custom macros to set/get the data > + u32 data; > + /** @clxt: CLX time in microseconds */ slash-star-star implies kerneldoc, which this isn't - but it would be appreciated, see e.g. struct qcom_icc_provider in drivers/interconnect/qcom/icc-rpmh.h Konrad