mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pu Lehui <pulehui@huawei.com>
To: Daniel Borkmann <daniel@iogearbox.net>, <ast@kernel.org>,
	<andrii@kernel.org>, <kafai@fb.com>, <songliubraving@fb.com>,
	<yhs@fb.com>, <john.fastabend@gmail.com>, <kpsingh@kernel.org>,
	<paul.walmsley@sifive.com>, <palmer@dabbelt.com>,
	<aou@eecs.berkeley.edu>, <shuah@kernel.org>
Cc: <linux-kselftest@vger.kernel.org>, <netdev@vger.kernel.org>,
	<bpf@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH bpf-next] selftests/bpf: Fix building error when using userspace pt_regs
Date: Wed, 15 Dec 2021 09:20:34 +0800	[thread overview]
Message-ID: <30aa8ea2-3752-d711-50f8-4b3d49cad56f@huawei.com> (raw)
In-Reply-To: <9063be69-fbd9-c0a5-9271-c6d4281c71ef@iogearbox.net>

On 2021/12/15 4:01, Daniel Borkmann wrote:
> On 12/14/21 2:55 PM, Pu Lehui wrote:
>> When building bpf selftests on arm64, the following error will occur:
>>
>> progs/loop2.c:20:7: error: incomplete definition of type 'struct
>> user_pt_regs'
>>
>> Some archs, like arm64 and riscv, use userspace pt_regs in
>> bpf_tracing.h, which causes build failure when bpf prog use
>> macro in bpf_tracing.h. So let's use vmlinux.h directly.
>>
>> Signed-off-by: Pu Lehui <pulehui@huawei.com>
> 
> Looks like this lets CI fail, did you run the selftests also with 
> vmtest.sh to
> double check?
> 
> https://github.com/kernel-patches/bpf/runs/4521708490?check_suite_focus=true 
> :
> 
> [...]
> #189 verif_scale_loop6:FAIL
> libbpf: prog 'trace_virtqueue_add_sgs': BPF program load failed: 
> Argument list too long
> libbpf: prog 'trace_virtqueue_add_sgs': -- BEGIN PROG LOAD LOG --
> R1 type=ctx expected=fp
> BPF program is too large. Processed 1000001 insn
> verification time 12250995 usec
> stack depth 88
> processed 1000001 insns (limit 1000000) max_states_per_insn 107 
> total_states 21739 peak_states 2271 mark_read 6
> -- END PROG LOAD LOG --
> libbpf: failed to load program 'trace_virtqueue_add_sgs'
> libbpf: failed to load object 'loop6.o'
> scale_test:FAIL:expect_success unexpected error: -7 (errno 7)
> Summary: 221/986 PASSED, 8 SKIPPED, 1 FAILED
> [...]
> 
> Please take a look and fix in your patch, thanks!
> .
Sorry for my negligence, I'll take a look and fix it.

  reply	other threads:[~2021-12-15  1:20 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-14 13:55 Pu Lehui
2021-12-14 20:01 ` Daniel Borkmann
2021-12-15  1:20   ` Pu Lehui [this message]
2021-12-17  2:19     ` Pu Lehui
2021-12-16  4:06 ` Andrii Nakryiko
2021-12-17  2:25   ` Pu Lehui
2021-12-17 16:45     ` Andrii Nakryiko
2021-12-20 14:02       ` Pu Lehui
2021-12-21  0:58         ` Pu Lehui
2021-12-21 23:52           ` Andrii Nakryiko
2021-12-22  1:33             ` Pu Lehui
2021-12-22 23:17               ` Andrii Nakryiko
2021-12-23  4:52                 ` Pu Lehui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=30aa8ea2-3752-d711-50f8-4b3d49cad56f@huawei.com \
    --to=pulehui@huawei.com \
    --cc=andrii@kernel.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=john.fastabend@gmail.com \
    --cc=kafai@fb.com \
    --cc=kpsingh@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=shuah@kernel.org \
    --cc=songliubraving@fb.com \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®