From: Markus Elfring <Markus.Elfring@web.de>
To: Jia-Ju Bai <baijiaju1990@gmail.com>,
linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Stanimir Varbanov <stanimir.varbanov@linaro.org>
Subject: Re: [PATCH] media: venus: Fix possible buffer overflow in venus_sfr_print()
Date: Sat, 30 May 2020 11:44:11 +0200 [thread overview]
Message-ID: <30acaf40-3709-d712-892f-c410acd78f63@web.de> (raw)
Please avoid typos in the patch subject.
> To fix this possible bug, sfr->buf_size is assigned to a local variable,
> and then this variable is checked before being used.
How do you think about a wording variant like the following?
Thus assign the data structure member “buf_size” to a local variable
and check it before further usage.
Would you like to add the tag “Fixes” to the commit message?
Regards,
Markus
reply other threads:[~2020-05-30 9:44 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30acaf40-3709-d712-892f-c410acd78f63@web.de \
--to=markus.elfring@web.de \
--cc=agross@kernel.org \
--cc=baijiaju1990@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=stanimir.varbanov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®