From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 67726482F2 for ; Wed, 19 Mar 2025 11:19:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742383142; cv=none; b=tGZ9aD1djmaPM+/0KNFe6xsuKP6eafDI7ATi8ha9H3wcAoZgnPialVzQHWJPcwaMLvtJch1TgmTAkplPs7gI/SIlwuPSDcJtVsT/NULIGAX9WqKkGG5OfIdfqqAb5ye7CXtF8haJfusy731oIfWhWeqcUeHPzT21wNxaSA2LVu8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742383142; c=relaxed/simple; bh=IXeQyYXcup9Cp8G9gPgPi3i1EnfTtTWZ/QE2GjXdGR0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DY5lxv7ujNug1sifrSiv0Ln4yfV9zYhAxDJJek7Izjs7NvPvTVcPkFumNAQqgSgacZAVD3jQb2C9ThMcFH9UiFjZCuwX8uozHXfZVC8QnHPY4RMN8D3OQTjEQx/DES0i82GcQBCr+n5tEUvZLd6BqRGdCVrH7BWmtPdic3QRovE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F20A0113E; Wed, 19 Mar 2025 04:19:07 -0700 (PDT) Received: from [192.168.3.228] (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3B9943F673; Wed, 19 Mar 2025 04:18:58 -0700 (PDT) Message-ID: <30adb3ee-60d2-499f-94d5-0880e83c4403@arm.com> Date: Wed, 19 Mar 2025 11:18:56 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] sched/topology: Fix sched_is_eas_possible() prints To: Vincent Guittot Cc: Ingo Molnar , Peter Zijlstra , Juri Lelli , Dietmar Eggemann , Steven Rostedt , "linux-kernel@vger.kernel.org" References: Content-Language: en-US From: Christian Loehle In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/19/25 11:07, Vincent Guittot wrote: > On Wed, 19 Mar 2025 at 11:59, Christian Loehle wrote: >> >> Add the missing newline on two failure prints to ensure EAS abort >> reasons don't go missing. > > Would be good to have a Fixes tag > > Reviewed-by: Vincent Guittot You're right, thanks. It's fa50e2b452c6 ("sched/topology: Condition EAS enablement on FIE support") 8f833c82cdab ("sched/topology: Change behaviour of the 'sched_energy_aware' sysctl, based on the platform") respectively, so I'll split this to make backporting easier and carry your R-b in both if you don't mind.