From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62900C10F0E for ; Mon, 15 Apr 2019 11:17:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3BA9220880 for ; Mon, 15 Apr 2019 11:17:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727343AbfDOLRH (ORCPT ); Mon, 15 Apr 2019 07:17:07 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:34987 "EHLO relay7-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726556AbfDOLRG (ORCPT ); Mon, 15 Apr 2019 07:17:06 -0400 X-Originating-IP: 90.88.18.121 Received: from aptenodytes (aaubervilliers-681-1-63-121.w90-88.abo.wanadoo.fr [90.88.18.121]) (Authenticated sender: paul.kocialkowski@bootlin.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id AEF452000B; Mon, 15 Apr 2019 11:17:03 +0000 (UTC) Message-ID: <30b3c2548772d13f54284fcf16ed941de88f72cc.camel@bootlin.com> Subject: Re: [PATCH] phy: sun4i-usb: Make sure to disable PHY0 passby for peripheral mode From: Paul Kocialkowski To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com Cc: Kishon Vijay Abraham I , Maxime Ripard , Chen-Yu Tsai , Thomas Petazzoni , Jagan Teki , Hans de Goede Date: Mon, 15 Apr 2019 13:17:03 +0200 In-Reply-To: <20190314130518.2892-1-paul.kocialkowski@bootlin.com> References: <20190314130518.2892-1-paul.kocialkowski@bootlin.com> Organization: Bootlin Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Le jeudi 14 mars 2019 à 14:05 +0100, Paul Kocialkowski a écrit : > On platforms where the MUSB and HCI controllers share PHY0, PHY passby > is required when using the HCI controller with the PHY, but it must be > disabled when the MUSB controller is used instead. > > Without this, PHY0 passby is always enabled, which results in broken > peripheral mode on such platforms (e.g. H3/H5). > > Fixes: ba4bdc9e1dc0 ("PHY: sunxi: Add driver for sunxi usb phy") Does anyone have feedback about this? I was hoping to get it merged rather soon since it pretty much fixes USB gadget on H3/R40/V3/V3s. Cheers, Paul > Signed-off-by: Paul Kocialkowski > --- > drivers/phy/allwinner/phy-sun4i-usb.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/phy/allwinner/phy-sun4i-usb.c b/drivers/phy/allwinner/phy-sun4i-usb.c > index 5163097b43df..7b23920e0068 100644 > --- a/drivers/phy/allwinner/phy-sun4i-usb.c > +++ b/drivers/phy/allwinner/phy-sun4i-usb.c > @@ -551,6 +551,7 @@ static void sun4i_usb_phy0_id_vbus_det_scan(struct work_struct *work) > struct sun4i_usb_phy_data *data = > container_of(work, struct sun4i_usb_phy_data, detect.work); > struct phy *phy0 = data->phys[0].phy; > + struct sun4i_usb_phy *phy = phy_get_drvdata(phy0); > bool force_session_end, id_notify = false, vbus_notify = false; > int id_det, vbus_det; > > @@ -607,6 +608,9 @@ static void sun4i_usb_phy0_id_vbus_det_scan(struct work_struct *work) > mutex_unlock(&phy0->mutex); > } > > + /* Enable PHY0 passby for host mode only. */ > + sun4i_usb_phy_passby(phy, !id_det); > + > /* Re-route PHY0 if necessary */ > if (data->cfg->phy0_dual_route) > sun4i_usb_phy0_reroute(data, id_det); -- Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com