From: Paolo Bonzini <pbonzini@redhat.com>
To: Eric Hankland <ehankland@google.com>,
Wei Wang <wei.w.wang@intel.com>,
rkrcmar@redhat.com
Cc: linux-kernel@vger.kernel.org,
Stephane Eranian <eranian@google.com>,
kvm@vger.kernel.org
Subject: Re: [PATCH v2] KVM: x86: PMU Event Filter
Date: Thu, 11 Jul 2019 13:22:57 +0200 [thread overview]
Message-ID: <30b7a0a1-1dc7-7ab0-938a-e34e61152ec8@redhat.com> (raw)
In-Reply-To: <CAOyeoRUUK+T_71J=+zcToyL93LkpARpsuWSfZS7jbJq=wd1rQg@mail.gmail.com>
On 11/07/19 03:25, Eric Hankland wrote:
>
> +/* for KVM_CAP_PMU_EVENT_FILTER */
> +struct kvm_pmu_event_filter {
> + __u32 type;
> + __u32 nevents;
> + __u64 events[0];
> +};
> +
> +#define KVM_PMU_EVENT_WHITELIST 0
> +#define KVM_PMU_EVENT_BLACKLIST 1
> +
"type" is a bit vague, so I am thinking of replacing it with "action"
and rename the constants to KVM_PMU_EVENT_ACCEPT/REJECT. What do you think?
Paolo
next prev parent reply other threads:[~2019-07-11 11:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 1:25 Eric Hankland
2019-07-11 11:22 ` Paolo Bonzini [this message]
2019-07-11 11:58 ` Paolo Bonzini
2019-07-11 17:04 ` Eric Hankland
2019-07-11 17:12 ` Paolo Bonzini
2019-07-12 3:27 ` Wei Wang
2019-07-16 0:10 ` Eric Hankland
2019-07-16 8:49 ` Wei Wang
2019-07-17 10:22 ` Paolo Bonzini
2019-07-17 17:05 ` Eric Hankland
2019-07-17 17:30 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30b7a0a1-1dc7-7ab0-938a-e34e61152ec8@redhat.com \
--to=pbonzini@redhat.com \
--cc=ehankland@google.com \
--cc=eranian@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rkrcmar@redhat.com \
--cc=wei.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®