From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751622AbdHOLpO (ORCPT ); Tue, 15 Aug 2017 07:45:14 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:3536 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750827AbdHOLpM (ORCPT ); Tue, 15 Aug 2017 07:45:12 -0400 Subject: Re: [PATCH] f2fs: let fill_super handle roll-forward errors To: Jaegeuk Kim CC: , , , References: <20170811004204.24078-1-jaegeuk@kernel.org> <20170815032209.GA91145@jaegeuk-macbookpro.roam.corp.google.com> From: Chao Yu Message-ID: <30b91d0c-63b2-0082-0132-3f188c1a4602@huawei.com> Date: Tue, 15 Aug 2017 19:45:03 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170815032209.GA91145@jaegeuk-macbookpro.roam.corp.google.com> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020202.5992DEC3.01BB,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: ba5fb768f2fac3ccf95d36c02696f2d1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017/8/15 11:22, Jaegeuk Kim wrote: > On 08/15, Chao Yu wrote: >> Hi Jaegeuk, >> >> On 2017/8/11 8:42, Jaegeuk Kim wrote: >>> If we set CP_ERROR_FLAG in roll-forward error, f2fs is no longer to proceed >>> any IOs due to f2fs_cp_error(). But, for example, if some stale data is involved >>> on roll-forward process, we're able to get -ENOENT, getting fs stuck. >>> If we get any error, let fill_super set SBI_NEED_FSCK and try to recover back >>> to stable point. >> >> Before that, we have cleaned up all node/meta page cache, so we will get back to >> last checkpoint status, means losing fsynced datas for ever. >> >> Would it be better to just leave message reminding user to mount with >> disable_roll_forward or run fsck offline. > > We can't rely on user for this, since fsck cannot recover this, resulting in If fsck has no ability to recover this, it could tag superblock in somewhere, then kernel could skip recovery. Comparing to fail recovery directly, it give user another chance to rescuer his datas. Thanks, > infinite mount failure. The only way is to disable roll-forward recovery, which > is same as returning error here. > > Thanks, > >> >> Thanks, >> >>> >>> Cc: >>> Signed-off-by: Jaegeuk Kim >>> --- >>> fs/f2fs/recovery.c | 2 -- >>> 1 file changed, 2 deletions(-) >>> >>> diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c >>> index a3d02613934a..f707d810c87d 100644 >>> --- a/fs/f2fs/recovery.c >>> +++ b/fs/f2fs/recovery.c >>> @@ -649,8 +649,6 @@ int recover_fsync_data(struct f2fs_sb_info *sbi, bool check_only) >>> } >>> >>> clear_sbi_flag(sbi, SBI_POR_DOING); >>> - if (err) >>> - set_ckpt_flags(sbi, CP_ERROR_FLAG); >>> mutex_unlock(&sbi->cp_mutex); >>> >>> /* let's drop all the directory inodes for clean checkpoint */ >>> > > . >