From: Vlastimil Babka <vbabka@suse.cz>
To: Roman Gushchin <roman.gushchin@linux.dev>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
shakeelb@google.com, Muchun Song <muchun.song@linux.dev>,
Dennis Zhou <dennis@kernel.org>,
David Rientjes <rientjes@google.com>,
Naresh Kamboju <naresh.kamboju@linaro.org>
Subject: Re: [PATCH v3 2/5] mm: kmem: add direct objcg pointer to task_struct
Date: Wed, 18 Oct 2023 16:11:26 +0200 [thread overview]
Message-ID: <30bf8eb7-f039-48cf-3dca-11f99604e12e@suse.cz> (raw)
In-Reply-To: <d698b8d0-1697-e336-bccb-592e633e8b98@suse.cz>
On 10/18/23 11:52, Vlastimil Babka wrote:
>> +
>> + return objcg;
>> +}
>> +
>> __always_inline struct obj_cgroup *get_obj_cgroup_from_current(void)
>> {
>> struct mem_cgroup *memcg;
>> @@ -3008,19 +3054,26 @@ __always_inline struct obj_cgroup *get_obj_cgroup_from_current(void)
>>
>> if (in_task()) {
>> memcg = current->active_memcg;
>> + if (unlikely(memcg))
>> + goto from_memcg;
>>
>> - /* Memcg to charge can't be determined. */
>> - if (likely(!memcg) && (!current->mm || (current->flags & PF_KTHREAD)))
> The checks for current->mm and PF_KTHREAD seem to be gone completely after
> the patch, was that intended and why?
And also they are not present in the new flavor that's current_obj_cgroup().
next prev parent reply other threads:[~2023-10-18 14:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 22:18 [PATCH v3 0/5] mm: improve performance of accounted kernel memory allocations Roman Gushchin
2023-10-16 22:18 ` [PATCH v3 1/5] mm: kmem: optimize get_obj_cgroup_from_current() Roman Gushchin
2023-10-17 9:57 ` Vlastimil Babka
2023-10-16 22:18 ` [PATCH v3 2/5] mm: kmem: add direct objcg pointer to task_struct Roman Gushchin
2023-10-16 22:34 ` Shakeel Butt
2023-10-18 9:52 ` Vlastimil Babka
2023-10-18 14:11 ` Vlastimil Babka [this message]
2023-10-18 15:29 ` Shakeel Butt
2023-10-18 17:22 ` Roman Gushchin
2023-10-18 18:26 ` Shakeel Butt
2023-10-18 22:37 ` Roman Gushchin
2023-10-19 16:36 ` Shakeel Butt
2023-10-16 22:18 ` [PATCH v3 3/5] mm: kmem: make memcg keep a reference to the original objcg Roman Gushchin
2023-10-18 11:58 ` Vlastimil Babka
2023-10-18 14:06 ` Vlastimil Babka
2023-10-16 22:18 ` [PATCH v3 4/5] mm: kmem: scoped objcg protection Roman Gushchin
2023-10-18 14:04 ` Vlastimil Babka
2023-10-16 22:19 ` [PATCH v3 5/5] percpu: " Roman Gushchin
2023-10-18 14:23 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30bf8eb7-f039-48cf-3dca-11f99604e12e@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=dennis@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=naresh.kamboju@linaro.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=shakeelb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®