From: Kishon Vijay Abraham I <kishon@ti.com>
To: "Péter Ujfalusi" <peter.ujfalusi@gmail.com>,
"Dan Williams" <dan.j.williams@intel.com>,
"Vinod Koul" <vkoul@kernel.org>,
"Grygorii Strashko" <grygorii.strashko@ti.com>,
"Vignesh Raghavendra" <vigneshr@ti.com>
Cc: <dmaengine@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dmaengine: ti: k3-udma: Fix NULL pointer dereference error
Date: Wed, 10 Feb 2021 17:04:39 +0530 [thread overview]
Message-ID: <30bfe6ef-de01-e019-d2d3-a999d6261fd8@ti.com> (raw)
In-Reply-To: <8e9954cd-53fa-2c7e-2019-9821e5f9d45a@gmail.com>
Hi Peter,
On 10/02/21 3:33 pm, Péter Ujfalusi wrote:
> Hi Kishon,
>
> On 2/9/21 2:02 PM, Kishon Vijay Abraham I wrote:
>> bcdma_get_*() and udma_get_*() checks if bchan/rchan/tchan/rflow is
>> already allocated by checking if it has a NON NULL value. For the
>> error cases, bchan/rchan/tchan/rflow will have error value
>> and bcdma_get_*() and udma_get_*() considers this as already allocated
>> (PASS) since the error values are NON NULL. This results in
>> NULL pointer dereference error while de-referencing
>> bchan/rchan/tchan/rflow.
>>
>> Reset the value of bchan/rchan/tchan/rflow to NULL if the allocation
>> actually fails.
>>
>> Fixes: 017794739702 ("dmaengine: ti: k3-udma: Initial support for K3 BCDMA")
>> Fixes: 25dcb5dd7b7c ("dmaengine: ti: New driver for K3 UDMA")
>> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
>
> Is this the same patch as the other with the similar subject?
Right, sorry for the duplicate patch (thought it didn't go out initially).
Regards
Kishon
next prev parent reply other threads:[~2021-02-10 11:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 12:02 Kishon Vijay Abraham I
2021-02-10 10:03 ` Péter Ujfalusi
2021-02-10 11:34 ` Kishon Vijay Abraham I [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-02-09 9:00 Kishon Vijay Abraham I
2021-02-09 12:23 ` Péter Ujfalusi
2021-02-09 12:45 ` Kishon Vijay Abraham I
2021-02-10 7:50 ` Péter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30bfe6ef-de01-e019-d2d3-a999d6261fd8@ti.com \
--to=kishon@ti.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=grygorii.strashko@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.ujfalusi@gmail.com \
--cc=vigneshr@ti.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®