From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933627AbdKAXUP (ORCPT ); Wed, 1 Nov 2017 19:20:15 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:48299 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932964AbdKAXUO (ORCPT ); Wed, 1 Nov 2017 19:20:14 -0400 Subject: Re: [PATCH 3/6] hugetlb: expose hugetlbfs_inode_info in header To: =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: aarcange@redhat.com, hughd@google.com, nyc@holomorphy.com References: <20171031184052.25253-1-marcandre.lureau@redhat.com> <20171031184052.25253-4-marcandre.lureau@redhat.com> From: Mike Kravetz Message-ID: <30bfff65-4cb9-a6b6-ab31-73d767a4b8ae@oracle.com> Date: Wed, 1 Nov 2017 16:20:06 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171031184052.25253-4-marcandre.lureau@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/31/2017 11:40 AM, Marc-André Lureau wrote: > The following patch is going to access hugetlbfs_inode_info field from > mm/shmem.c. The code looks fine. However, I would prefer something different for the commit message. Perhaps something like: hugetlbfs inode information will need to be accessed by code in mm/shmem.c for file sealing operations. Move inode information definition from .c file to header for needed access. -- Mike Kravetz > > Signed-off-by: Marc-André Lureau > --- > fs/hugetlbfs/inode.c | 10 ---------- > include/linux/hugetlb.h | 10 ++++++++++ > 2 files changed, 10 insertions(+), 10 deletions(-) > > diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c > index 59073e9f01a4..ea7b10357ac4 100644 > --- a/fs/hugetlbfs/inode.c > +++ b/fs/hugetlbfs/inode.c > @@ -55,16 +55,6 @@ struct hugetlbfs_config { > umode_t mode; > }; > > -struct hugetlbfs_inode_info { > - struct shared_policy policy; > - struct inode vfs_inode; > -}; > - > -static inline struct hugetlbfs_inode_info *HUGETLBFS_I(struct inode *inode) > -{ > - return container_of(inode, struct hugetlbfs_inode_info, vfs_inode); > -} > - > int sysctl_hugetlb_shm_group; > > enum { > diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h > index 8bbbd37ab105..f78daf54897d 100644 > --- a/include/linux/hugetlb.h > +++ b/include/linux/hugetlb.h > @@ -278,6 +278,16 @@ static inline struct hugetlbfs_sb_info *HUGETLBFS_SB(struct super_block *sb) > return sb->s_fs_info; > } > > +struct hugetlbfs_inode_info { > + struct shared_policy policy; > + struct inode vfs_inode; > +}; > + > +static inline struct hugetlbfs_inode_info *HUGETLBFS_I(struct inode *inode) > +{ > + return container_of(inode, struct hugetlbfs_inode_info, vfs_inode); > +} > + > extern const struct file_operations hugetlbfs_file_operations; > extern const struct vm_operations_struct hugetlb_vm_ops; > struct file *hugetlb_file_setup(const char *name, size_t size, vm_flags_t acct, >