From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f180.google.com (mail-dy1-f180.google.com [74.125.82.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 178AF42050 for ; Sun, 11 Oct 2026 05:13:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791695626; cv=none; b=rRonXAISyPJZ+VcW9iXFkRg4nBX1U7wZz0knIT9usgoEgNLsL/Pq7mhF9zzwl16ImJGtlak5vH8ZzIDOoVRXyaGsS0zj7H4X78vjx1DUuGL/o2IwFbnSWeYbIKWUArllpPZNLiDUNPsYY6QD351ayAdZYqbEe5NWDRYWSOlByrM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791695626; c=relaxed/simple; bh=yjj+GEMBuBRVvavplchcH8uaXDQxZ2w7EtUDess9Elc=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type:Content-Disposition; b=uyknBHuaRxCqoZS9ShvirleArb9WrfC3fSFMqC2fsZmxzLIRMJqxU55dxmLqHxb6nsGvZQ/hZ06sSBmv7HAlTkSesYd3IMEnpHQFYFmhswJQz0GCarvKvlAyhEOIrvSBAs315dd0biwxt7fWt+UmNB3nLBNKY8djkgBR/CnKJpM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mivFBBm9; arc=none smtp.client-ip=74.125.82.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mivFBBm9" Received: by mail-dy1-f180.google.com with SMTP id 5a478bee46e88-3550c917fd3so1390564eec.0 for ; Sat, 10 Oct 2026 22:13:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791695624; x=1792300424; darn=vger.kernel.org; h=content-disposition:content-transfer-encoding:content-type :mime-version:references:in-reply-to:subject:cc:to:from:message-id :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=jGwiSM6Jw7fQY0scgIdwmNx4g3Nb53u28uyWu2p6TTo=; b=mivFBBm9fSwc0/j757Fw9E4ROGNYoaFrsrwXW1kuvn7HPvPunacD+Cv2h9uU9srizw tQ2j5tZnMU7JZ5NAgarhBBfPmL06/FMMRxEILEDXFwBWV09sY/wdFZugC7X6AU2sVbvl UtE5wet1Oslo3L7A6EpfgPmTn5Y2VhIHlNN+A8/EdbOodg35JIbL8JNAxPnotvxwGy+Y ln5JVxChpYz9HKqK7kfF7c/o6FXN7KSscVZZpNgFR12qsKw8HFRGyo5ip0f9NL/pq3/G h91SS/+lwerZawVgmkIR3bWHdq7QunmILHHi7c8BrjyZuhRF9wvcdTJziNMm8i1o5Or8 RnCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791695624; x=1792300424; h=content-disposition:content-transfer-encoding:content-type :mime-version:references:in-reply-to:subject:cc:to:from:message-id :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=jGwiSM6Jw7fQY0scgIdwmNx4g3Nb53u28uyWu2p6TTo=; b=R65cPgKInk7yAaQBOQLpjnUdYeVb1guqAgHYimZALIzHh7w+4RFRGIzMURo474bD8E c9K54/SzJqo+6NoqptdTQT3UTDEpAdK9CQLm39lDyu7Dh8ABgy+jnEo5+x0p8yg0CXC7 OeuqdLF3JeOPpj+moFRfZC8psiPCny48WNAhmTnLFP5pR2cJeWDBarLN0Ex8S1G+hxGy 6sUvxiWvmW7RUfjge2s1jIXsL63C/HpagobhIXbvfZ48pblVKYTwAqtLhEOEnIs+3x9D 0hyWmIVW71je5q/eQSelelUVUMmW/qSsR4iX2JrmhYirTMKKhlpFGHmban/DwVUR2aza ABFg== X-Forwarded-Encrypted: i=1; AKwUvBze4MdTeVOfIpp43YIclHWKWWi2fQAninBLLBu3ew4A5HPTcZd/3wE6u1I3pwZEg7PWrx/fSXfc4/tkwPk=@vger.kernel.org X-Gm-Message-State: AFq9FYJyV119WkqM3x3ydvg1kBC2MbvjcWdLh50rALy6jYKtRpyebyYn 9wzpbkCwCOPn2vek1boWw7ebymTgwd0ls/+TuB0Qj3lMEEFqluPWMu6c X-Gm-Gg: AYBFou3Qwu/oH+/Yl63qtcTilO5usNP0Ct0pTbRm7cggeVZSKZ7hVStsXTUb8SIL1Hf X6QYbBXphRJ04AAuimiNdSWCwkMTheH/iuDUP9WUWKmqrS8MPsiQsprz8gjDef0ybnqsYYOgrcO BPOfHDeB9JgMnHhQLINtNeJXiHE1rvjF9pbsWrpk5ZYIkl9p+v00apmkw1Dhp89qMDS3tVGP5hJ 9iWUB0hvawm/PyQRlVvTAAb2Cn07txKsxYCB0BcqrrYS0yibNNvO10MFqhZVtuur5o5ClEs/iYN 7vsZZI4Itr/R1KzrlrWsZ/fci/dkLMyGSeqhA4+vZHt8ULEXEeFfVxavglRjC/fDC47h/EW2B2X 0W/d8K8kr5+9elgveGMhQk221Sze52r12YoIam+DAsWXzgrCb8a4SbHXXsTBIwrSSdd2G3ApGgr Ha4HjcZOeiPmaPw5/sOhS30LpigxBv9hbwLsJBmXFoBwhW6R5B430v1GXedI4RGsiZU6OErZ3E8 Xc9ze0JGvTNrpFx9DYXC5NvkfQ+SuvgiIdG5saQcgM6e2fbiQ== X-Received: by 2002:a05:701b:205c:10b0:149:49c:233 with SMTP id a92af1059eb24-16a60811394mr8606020c88.27.1791695623826; Sat, 10 Oct 2026 22:13:43 -0700 (PDT) Received: from localhost ([2a00:79e0:2ebe:8:99d7:6eb1:9874:c6be]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-169a1becf08sm20632400c88.5.2026.10.10.22.13.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Oct 2026 22:13:43 -0700 (PDT) Date: Sat, 10 Oct 2026 22:13:41 -0700 Message-ID: <30c56291bac612db47c6ced73dff739f@gmail.com> From: Dmitry Torokhov To: Miotsuki Mizuno Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Icenowy Zheng , "linux-input@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 2/3] dt-bindings: input: touchscreen: add Nsiway NS2009 In-Reply-To: <20261009144729.85832-3-founder@crepuse.com> References: <20261009144729.85832-1-founder@crepuse.com> <20261009144729.85832-3-founder@crepuse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline Hi Miotsuki, On Fri, Oct 09, 2026 at 02:47:43PM +0000, Miotsuki Mizuno wrote: > Describe the Nsiway NS2009 four-wire resistive touchscreen controller > and the properties used by its polling driver. > > The controller returns 12-bit ADC coordinates. Use the common touchscreen > properties for coordinate ranges and orientation, and allow boards to set > the raw Z1 contact threshold through touchscreen-min-pressure. Limit that > threshold to 1..4095 because zero cannot distinguish a released contact. > > Document the historical default of 80 and a board override of 150 in the > example. The Z1 threshold is for contact detection, not calibrated > pressure. > > Signed-off-by: Mizuno Miotsuki > --- ... > +description: | > + The NS2009 is a four-wire resistive touchscreen controller connected over > + I2C. This binding describes polling operation without a pen interrupt. > + Coordinates are 12-bit ADC readings, not display pixel coordinates. Devicetree bindings should describe the hardware itself rather than the subset of features currently used by the Linux driver. According to the NS2009 datasheet, the controller has several hardware signals and capabilities that should be covered in the binding from the start (even if the initial driver operates in polling mode): - interrupts (maxItems: 1) and wakeup-source: the controller provides an active-low pen interrupt output, which can remain optional for boards where the line is left unconnected. - vdd-supply and vref-supply: main power supply and external reference voltage regulators. - touchscreen-x-plate-ohms (along with touchscreen-max-pressure and touchscreen-fuzz-pressure): the NS2009 supports touch resistance calculation from Z1/Z2 and X-plate resistance. Could you expand the binding description and properties (and show an interrupt/supply example as well) so we do not have to revisit the binding when IRQ or pressure support is added later? Thanks. -- Dmitry