From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED8CA30E0EC for ; Mon, 22 Dec 2025 19:34:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766432091; cv=none; b=s2F4ofKic2ek5i5hscXfKWlrgVjddVsbJQi4rmjD0eG+j9yz8T4ax0ud6EWwSc7Kqni4eeOiiFmnieiZ+dO0UHBVJ8Kxk+mspU4qzT5chAj8TyLPD6Fv+GgsZj9QmXJOsYyY97QYtoF8S2QhXhidilJyDNxsn8t5T2RfrMDX2T4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766432091; c=relaxed/simple; bh=/fo1P6Jvkp9HF0cJbS0xftZBxvAHWwbnAbs2Fgg1hx4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=db0rCYelNpiHKdtHY1NUds0BqZXqsZvmgAFyvwsZyprjTNhi0kUaOiQe5D6dfkPTjzV7vrK09QZIkaCd47CZFLKvq8bjVR6NMsLEOw7GM7Or2fYtEEwtifwQfq3xyHiz4GFPPg63VrmlD7dLinywJhh4oYPqrSYOeJOWHhycdCI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=NgtTsFzp; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="NgtTsFzp" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1766432088; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VG0oF06MATxg/zLOVliOY5C7b4LG+alI0dm9ELpl22A=; b=NgtTsFzpE3Gs2YDBt+dGVOWB2ebXizTtzsmIZIbrzATOOG0bqtBzWl7HJU+jj7EC4ze87I SzHZJWcGkyK7UOOdUwsI9wqiqA0zM7ENWuFNCEfG0T8FR+DNjRwx1O8nIsAbFqtUWfRjCO SPRDr6rgyYKEPyqXjvR6OQSjgMsCw9s= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-613-yfrQinmFPGG4_qNKsVq0HQ-1; Mon, 22 Dec 2025 14:34:43 -0500 X-MC-Unique: yfrQinmFPGG4_qNKsVq0HQ-1 X-Mimecast-MFC-AGG-ID: yfrQinmFPGG4_qNKsVq0HQ_1766432083 Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4f4d60d1fbdso23336801cf.3 for ; Mon, 22 Dec 2025 11:34:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766432083; x=1767036883; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VG0oF06MATxg/zLOVliOY5C7b4LG+alI0dm9ELpl22A=; b=ZXwTwK0qFr7Awg77iyWw8sfmm/yxjfoJcz1oUzdzkUtzdEc2WuJhKIZwlcqPiH7vAX GS5BH391mReB4wI2+b1Rk73qXJV+0jdqksgHsvliNsTmsT8hJsUF+M3iAc3jv5rzFPA5 arZXz6amtVsj7aedrgZDlESvJ/0/vcYOgoKtse87KQj+tmyULeqIJxW9IiLaM3GFXfz3 /+N0cSsfdWyuG8osyCELcZd6/i0NxWeHXVscW+iJ7p6E3aPqrXP2m6+3nuk//CDjwmjG FeoHC1kjNoyODU2WdoDBJFK694YT1xKW4YbzOnC2p6uQX0qUuu3O1rIBcsh/r3Rmlmmg m5Tg== X-Forwarded-Encrypted: i=1; AJvYcCULMh0LxdLf3zoqBdtKYVM/LUM3WhsEOODfLL9PcLGv4X4vUe52GPKrl3kvx53Vg7AGTJGuy5EDtBUH7KY=@vger.kernel.org X-Gm-Message-State: AOJu0YzRK+vQbKruudRSNm6PQG/w4p3ltWGHOgqLJbYxp/eXmPXgI0rq uaVrQjY/jHB8SZfza5oOHUkD8cc3VkW3so2/RvYF3qYzRa5FPBbEVYaBEjxX0kvJI9CliMr4VkS wJgXEyrYNu+FlZS+K8a9IzLqX3v1qUR3Q6vCxXlOD8qnVLK5SACDPDL/mNMWubfYP1Q== X-Gm-Gg: AY/fxX4Ya4lPJ9iwc3RSvsESwHHcndmeN+wb2ZU2O+64aTcy9GY162uQMqeiIYlp3f8 KqrT+0od+ptGE/2WnbX8e4Ywq3bjgg5kpgoHZXsg8XiYnust+kpXDzDaOrvvYK0nrhMIOIB+TEb ViWEkjmS7vK+JTOzfIegJLQziC+RhcSQEaY6mhSOncxSA6du7XelBMuJ/R7yVtMqxHoKLcUdtU0 byMdvf7iIv8xd03uxzqUFVbUvjh73wrS8qoR3kDHgWli4Ldi15Lf5++MkhGkC03XQdEawoQfDYI SnnSMnj5uQkchCSFJlQaLArOw3UjOCcmrHwaeaiTWk8uHLKE15lr6a24BnBQvWDi1/mZk0Da55B vhdHvuRlYRf5OIRn8YcsyT53VGklnWRyQgnB6QPIBeBd1FWvwzXyFAeq8Tp51FJjPySzwE4opuA == X-Received: by 2002:a05:622a:17ca:b0:4e8:b446:c01b with SMTP id d75a77b69052e-4f4abda0960mr191530091cf.61.1766432083226; Mon, 22 Dec 2025 11:34:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IGnavtkUmnDQmxJQ3e4vwSgIlPXL3C48qTsghoyMt5JLf3ySEy2SXRpIFZDKMDuuzyt9EjIdw== X-Received: by 2002:a05:622a:17ca:b0:4e8:b446:c01b with SMTP id d75a77b69052e-4f4abda0960mr191529671cf.61.1766432082740; Mon, 22 Dec 2025 11:34:42 -0800 (PST) Received: from [192.168.2.110] (bras-base-aylmpq0104w-grc-48-76-65-77-217.dsl.bell.ca. [76.65.77.217]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4f4ac563f66sm80950521cf.15.2025.12.22.11.34.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Dec 2025 11:34:42 -0800 (PST) Message-ID: <30c82582-9bbe-4d7b-8549-ebdb29743e86@redhat.com> Date: Mon, 22 Dec 2025 14:34:41 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/5] selftests/mm: allocate 6 hugepages in va_high_addr_switch.sh To: Chunyu Hu , akpm@linux-foundation.org, david@kernel.org, shuah@kernel.org, linux-mm@kvack.org Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com References: <20251221040025.3159990-1-chuhu@redhat.com> <20251221040025.3159990-2-chuhu@redhat.com> Content-Language: en-US, en-CA From: Luiz Capitulino In-Reply-To: <20251221040025.3159990-2-chuhu@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2025-12-20 23:00, Chunyu Hu wrote: > The va_high_addr_switch test requires 6 hugepages, not 5. If running the > test directly by: ./va_high_addr_switch.sh, the test will hit a mmap 'FAIL' > caused by not enough hugepages: > ``` > mmap(addr_switch_hint - hugepagesize, 2*hugepagesize, MAP_HUGETLB): 0x7f330f800000 - OK > mmap(addr_switch_hint , 2*hugepagesize, MAP_FIXED | MAP_HUGETLB): 0xffffffffffffffff - FAILED > ``` > The failure can't be hit if run the tests by running 'run_vmtests.sh -t > hugevm' because the nr_hugepages is set to 128 at the beginning of > run_vmtests.sh and va_high_addr_switch.sh skip the setup of nr_hugepages > because already enough. Reviewed-by: Luiz Capitulino > > CC: Luiz Capitulino > Fixes: d9d957bd7b61 ("selftests/mm: alloc hugepages in va_high_addr_switch test") > Signed-off-by: Chunyu Hu > --- > tools/testing/selftests/mm/va_high_addr_switch.sh | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/mm/va_high_addr_switch.sh b/tools/testing/selftests/mm/va_high_addr_switch.sh > index f89fe078a8e6..a0c93d348b11 100755 > --- a/tools/testing/selftests/mm/va_high_addr_switch.sh > +++ b/tools/testing/selftests/mm/va_high_addr_switch.sh > @@ -111,8 +111,8 @@ setup_nr_hugepages() > > check_test_requirements > save_nr_hugepages > -# 4 keep_mapped pages, and one for tmp usage > -setup_nr_hugepages 5 > +# The HugeTLB tests require 6 pages > +setup_nr_hugepages 6 > ./va_high_addr_switch --run-hugetlb > retcode=$? > restore_nr_hugepages