From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: YingKun Meng <mengyingkun@loongson.cn>,
broonie@kernel.org, lgirdwood@gmail.com
Cc: xry111@xry111.site, linux-kernel@vger.kernel.org,
loongarch@lists.linux.dev, loongson-kernel@lists.loongnix.cn,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] ASoC: loongson: drop of_match_ptr for OF device id
Date: Wed, 26 Jul 2023 13:11:16 +0200 [thread overview]
Message-ID: <30caa2df-4cfc-761e-759f-039e4ff858dd@linaro.org> (raw)
In-Reply-To: <20230726110516.703342-1-mengyingkun@loongson.cn>
On 26/07/2023 13:05, YingKun Meng wrote:
> The ASoC Sound Card driver can be compile tested with !CONFIG_OF
> making 'loongson_asoc_dt_ids' unused:
>
> sound/soc/loongson/loongson_card.c:200:34: warning: unused variable 'loongson_asoc_dt_ids' [-Wunused-const-variable]
>
> As krzysztof advice, we drop of_match_ptr so the device id
> can also be used on ACPI.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202307242008.xqdjgk04-lkp@intel.com
> Fixes: d24028606e76 ("ASoC: loongson: Add Loongson ASoC Sound Card Support")
> Signed-off-by: YingKun Meng <mengyingkun@loongson.cn>
> ---
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-26 11:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 11:05 YingKun Meng
2023-07-26 11:11 ` Krzysztof Kozlowski [this message]
2023-07-26 18:08 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30caa2df-4cfc-761e-759f-039e4ff858dd@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=loongarch@lists.linux.dev \
--cc=loongson-kernel@lists.loongnix.cn \
--cc=mengyingkun@loongson.cn \
--cc=xry111@xry111.site \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®