From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 602662F25F9 for ; Wed, 21 Jan 2026 01:17:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768958280; cv=none; b=VQPqjg1dKScPk19iBMPNCkiR5X816Zg19fM4rIGAvqetU2EDHDxOR2iKcOXNifFvPP60EV8lRKbRm+NWjccV8XzpdFZpqnX9wi0/RFpkPhBmyrwFuWqyxVX/q9MMNTGYUyI34L5QR1CLqA3J81D7e+3JbgAhq2rz4M7r52Qfr4E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768958280; c=relaxed/simple; bh=xsGP7cB2hf7SdbMZgV/n/EaJk8t/U++p4LTCsNWQjgk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IJLBYhJuRcALn5U8Pu/kohY3k4FbFgPO26U3h/msMrzyfmLTGI/fhxIc73TPXn24ozbrZtXq6at0rDLkLwysfX6UHoxrJ7qd0kRzfgcJgbbK+3Wxma2oC9HDwzPk5CZrIKzitm7YjDUs1D298dGPOlpvWhs/PjFN+0+0GJrH6A8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com; spf=none smtp.mailfrom=huaweicloud.com; arc=none smtp.client-ip=45.249.212.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=huaweicloud.com Received: from mail.maildlp.com (unknown [172.19.163.177]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTPS id 4dwmWs6m64zYQtvG for ; Wed, 21 Jan 2026 09:17:29 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.128]) by mail.maildlp.com (Postfix) with ESMTP id A02454058C for ; Wed, 21 Jan 2026 09:17:54 +0800 (CST) Received: from [10.174.178.129] (unknown [10.174.178.129]) by APP4 (Coremail) with SMTP id gCh0CgBHp_dAKXBp1VspEg--.46573S3; Wed, 21 Jan 2026 09:17:54 +0800 (CST) Message-ID: <30d0b7fc-e305-90b3-0a1f-bee871111046@huaweicloud.com> Date: Wed, 21 Jan 2026 09:17:52 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v2] char: lp: Fix NULL pointer dereference of cad To: Greg KH Cc: arnd@arndb.de, linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk, wanghai38@huawei.com, "yi.zhang@huawei.com" , "yangerkun@huawei.com" References: <20260108024155.3800149-1-linan666@huaweicloud.com> <2026011644-glimpse-eatery-c556@gregkh> <2026012041-catfight-fetal-9347@gregkh> <7d2eab46-bad4-3e28-50e7-92a34e22ecd8@huaweicloud.com> <2026012049-scroll-smog-edf1@gregkh> <2026012055-excretory-afternoon-d123@gregkh> From: Li Nan In-Reply-To: <2026012055-excretory-afternoon-d123@gregkh> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CM-TRANSID:gCh0CgBHp_dAKXBp1VspEg--.46573S3 X-Coremail-Antispam: 1UD129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UjIYCTnIWjp_UUUYB7kC6x804xWl14x267AKxVW8JVW5JwAF c2x0x2IEx4CE42xK8VAvwI8IcIk0rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII 0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20xvE14v26w1j6s0DM28EF7xv wVC0I7IYx2IY6xkF7I0E14v26r4UJVWxJr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2z4 x0Y4vEx4A2jsIEc7CjxVAFwI0_GcCE3s1lnxkEFVAIw20F6cxK64vIFxWle2I262IYc4CY 6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr 0_Jr4lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxG rwCYjI0SjxkI62AI1cAE67vIY487MxAIw28IcxkI7VAKI48JMxAqzxv26xkF7I0En4kS14 v26r126r1DMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2Iq xVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc40Y0x0EwIxGrwCI42 IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJVW8JwCI42IY 6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aV CY1x0267AKxVWUJVW8JbIYCTnIWIevJa73UjIFyTuYvjxUFfHjUUUUU X-CM-SenderInfo: polqt0awwwqx5xdzvxpfor3voofrz/ 在 2026/1/20 22:07, Greg KH 写道: > On Tue, Jan 20, 2026 at 09:21:11PM +0800, Li Nan wrote: >> Do you think we need cleanups/fixes in this driver, or should we wait >> for real-world users to encounter issues and discuss them separately? > > As no one who actually has this hardware has reported anything in the > decades that the code has been like this, I would recommend just leaving > it as-is. > > thanks, > > greg k-h Agreed. This patch can be ignored. :) -- Thanks, Nan