From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f181.google.com (mail-oi1-f181.google.com [209.85.167.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C7F626E719 for ; Wed, 31 Dec 2025 04:07:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767154077; cv=none; b=YrL4eNCfTJiC+v13gDtLGGqLDbHaSh21UzYy/s7vnzTrPal+yatt+fqeSRWyYmXHiNXZo0Bpx/i+NU6YIlDHdRjmtGnJHm8cDfjZH1vzXh7xZ0YSDdbcC++A3oXqyTz1YA/sM8G6b5hXmDKwjjETDTODmxBtQWwal4m7Zy+JFdk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767154077; c=relaxed/simple; bh=BHQXxscP62wZkhfnXCyIlpXpap4Nwg2ykXcaQRU1Aio=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WErn/Q0Ou0DDd280oTXu2lEjVAwuqXhBAEoBtpERqmHOwS4OLNLSseMt6LGRnUFtuLZ5CD2zV3sVp91TJ8WUbm2xCYerLgjWRpJQWx3r/32xyLeNASf/+rrijSfHEKXbVCvkdimq7yjOtQrTV5SejHDfPo3hoCtio8nopB41d8A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=c/aMFKC7; arc=none smtp.client-ip=209.85.167.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="c/aMFKC7" Received: by mail-oi1-f181.google.com with SMTP id 5614622812f47-450b5338459so6011062b6e.2 for ; Tue, 30 Dec 2025 20:07:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1767154075; x=1767758875; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rEWpU9UfmDCYEMxA6nsMxalblaTS4cfYkzlnNo+UBaQ=; b=c/aMFKC7kQ8Aqu4r4ADTBUdfpneuwzqjNhuutyejKhYt+kNAYIBNMm5jUBhUjA1/Rf 4/5qR8MhCPq3be6jm0JO7gb5PVM3hVj9GphyB4G4nQ7j39sZgKIKU8ZVzkaoGsl8P4QN Bd+LffWJ4SATIJkE/pWEwcqcOAg2T+AiS/6YI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767154075; x=1767758875; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rEWpU9UfmDCYEMxA6nsMxalblaTS4cfYkzlnNo+UBaQ=; b=AdFXeFTvDLsg11GLugOof4eyd7P/1BkgLPkTamqYiT9PgcbEeef/lUdjBSI14U4yRl wWDYT8cfp9+ttZCBzFIxMp6LxbDu2GENDTu0tLJyYHDR4RQoWMAXx/BAOHgUu1AkJQY8 crSiEfeDQL/qfE/oe2qjMe3qpz+avoIigod+YJWVrjB6dX2JbXBRYWBHi6Huj7kUx4JJ xjdWLDyqwuL/lO9I5tePX+qGQRz/wroqfwFjjZl7MgKohjzUsybtLKMS3x42FPK9GjQ8 BL6BMhuWPxoLeDSZXX30p7JzjvJ7x8Q5I4xPuuO37g92lVObQTnMat2o7P8jgpeQ/szx AbvQ== X-Forwarded-Encrypted: i=1; AJvYcCVtO9xhItVfpAiZu203qyGCUkw5sBzpqtMGOSSo4bu6PoNFl3/OMAunYCdaJeC5tpsIgi7gG/JQXFqWRoY=@vger.kernel.org X-Gm-Message-State: AOJu0YzA/e29h7OxXtrNT1neLk9ePWPKgBU+Nqj965SqdT+FtrqFHJUn Drk9WwzPyVANls9VCy8rtu1d7DdjydcYFKE/au1dejK7ktZSGvcPJX+hI5rR27/ebbI= X-Gm-Gg: AY/fxX6wyTTB5FLTSMycrJfIOjdasxMfDgt2MQtRk+iDFYFvff9KQ0/RwyPRxCKf7BA /nKoNRdXjxDBa64LN0Y9tuLqaMX0WBWQnuZcS4AgDE3sw3/yR/h+jh3yxYS18VrOEmSriHdk4bZ PT5Pf+DKEaKYIuWO/D/mdGjeQH9X5AiAc2o3FlqEpv9L/uAoja2VAb9qXdaWtE6XmhT+ts1MvOS nCbGpRUp05HAB64lRKy12mCzXkC6aq4eW53uBIbHNj2BX1iI+D8V+nWp2zKUELxi40mVtNkJrtd 4JJWA4EOGhfNMJOxuvZ1ul8kYJ8q7QdYLnZQpeZEF7fCuzwrGKOcvXrAvTNAyz0DcsoXuwp1k5r AzNIXBFV0Bx0NLBCNorf/gmmRjJ5yaK0G038/BZXQyg8Y2TpspkVGkEk563cyxORGi69A4oBAHf zfTQiDYEoZzRixrdKwM7E6QqQ= X-Google-Smtp-Source: AGHT+IGk43rmMGz2LTVg3do8lOBVQ/ADeo1lfHCAWZcf3O24miuOt3rdd/Qp6y8+P/Y0QEMjm9pUgA== X-Received: by 2002:a05:6808:2e4d:b0:44f:8f27:e39a with SMTP id 5614622812f47-457b2061b07mr18260342b6e.8.1767154074844; Tue, 30 Dec 2025 20:07:54 -0800 (PST) Received: from [192.168.1.14] ([38.175.187.108]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-3fdaabbf2e6sm21907245fac.17.2025.12.30.20.07.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Dec 2025 20:07:54 -0800 (PST) Message-ID: <30d14c51-3325-49be-9510-43f4661ff6c4@linuxfoundation.org> Date: Tue, 30 Dec 2025 21:07:53 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Linux 6.19-rc1 mediatek mt7921e broke badly To: Eric Biggers , Linus Torvalds Cc: Matthew Schwartz , =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= , Mikhail Gavrilov , Mario Limonciello , Johannes Berg , quan.zhou@mediatek.com, Felix Fietkau , lorenzo@kernel.org, ryder.lee@mediatek.com, linux-wireless@vger.kernel.org, Linux Kernel Mailing List , Linux ARM , linux-mediatek@lists.infradead.org, shuah , Shuah Khan References: <756e3f65-b2f2-4da3-985a-17754a7a872d@t-8ch.de> <6fc04df5-b753-4b2d-b978-0e59a7f48ff7@linux.dev> <20251231015712.GA2299@sol> Content-Language: en-US From: Shuah Khan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 12/30/25 21:00, Shuah Khan wrote: > On 12/30/25 18:57, Eric Biggers wrote: >> On Tue, Dec 30, 2025 at 05:27:13PM -0800, Linus Torvalds wrote: >>> On Tue, 30 Dec 2025 at 15:57, Shuah Khan wrote: >>>> >>>> I would recommend reverting f804a5895eba instead of trying >>>> fix it. Then find a better way to eliminate extra newline that >>>> shows up in dmesg when firmware build date happens to have >>>> a newline. >>> >>> Yeah. Let's revert it. >>> >>> And the way to fix the extra newline is trivial: just remove it from >>> the "dev_info()" format string. >>> >>> Our kernel printing logic will add a newline for the next line anyway >>> if it is missing (unless somebody explicitly uses PR_CONT). >>> >>> Can whoever saw the problem confirm that just a revert and a "remove >>> \n from that dev_info()" fixes the output for them? >> >> That works for me.  The revert by itself makes the FORTIFY_SOURCE crash >> go away and reintroduces a blank line in the log.  Removing the \n from >> the string passed to dev_info as well makes the blank line go away. >> > > I just sent the revert. I will try removing \n from dev_info() > later on tomorrow. > > My quick trial still showed extra line which didn't make sense > to me. More trials have to wait for tomorrow. > Hmm - there are 3 places that print build_date in mt76_connac2_load_ram() 3022 dev_info(dev->dev, "WM Firmware Version: %.10s, Build Time: %.15s\n ", 3023 hdr->fw_ver, hdr->build_date); 3051 dev_info(dev->dev, "WA Firmware Version: %.10s, Build Time: %.15s\n ", 3052 hdr->fw_ver, hdr->build_date); 3127 dev_info(dev->dev, "HW/SW Version: 0x%x, Build Time: %.16s\n", 3128 be32_to_cpu(hdr->hw_sw_ver), hdr->build_date); The last one prints %.16s and other two do %.15s - is the fix simply changing last one on line 3127 to print %.15s - this avoids printing the extra \n? thanks, -- Shuah