From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A16340926C for ; Mon, 28 Sep 2026 10:35:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790591725; cv=none; b=BUgkMg00Q1nKmKtios2/7A3+VroXx5Vz6mKFVO0ivyqfJaWZ6SoFqYxRzDoIaFdu4l6a3qPD5JQfVJ6hDmvExXbfv1l/xGeZpvjHo/xifuw0kEMYPrZNXvXn28PMpxmQfX7A9Exns5tjSkW7Xx2Zr/EejVYshrfX4iNJuI9jDIE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790591725; c=relaxed/simple; bh=uBvJsGkwlPeJjyoA5UjXwXEsAQAqAnUC2W542XJX+Jc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OaxQPs+hkEa6Kusjh6OBnJbhgCPcX5wYv6lKGcQFjcjqNXaTHf+238bGFz1kMS3fu/oSrozaYRLP5Ff9/pw45K9XHAI2+e2+jzi3pX2daOKKvOn4eax7+NXVX2DvRoGEuIBpizS6S2SH7N0n1xFojUkoG7u3LY4LouXyJWW1M4k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=hbW3+63n; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AZzVGDGf; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="hbW3+63n"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AZzVGDGf" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68S9MH7o546968 for ; Mon, 28 Sep 2026 10:35:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= A36i+8Y0LPlWxU4cYfGu/QYHKhlLH1yQq9y13jnpBgU=; b=hbW3+63naVjI/ucE imFkU9u8JSpt4ru6eYtsidc8S+BBq20oDcOdPFZ8+/KakSMWjuDFmQWQyfqNstKD Fd8G4LRGtDA6u8YlZuLG2AYQiYk1ffjtWKrDFdOXOOsevoL+DSsipsgAVGvgmBZE bAxM65lSDiFlhT1338gBOOjAyYjf15R6CHwMqHGFc3hPjO7gCxHqD9JmC/QGFV66 QUndrkIy/P7sr319PtwnKAx7dhBa+OogFPpdbWFkGTv1iu9Jyw2DGmikiVHNgX3y S5FBQ6Bf9kPfcRZRaw2OgyNu26bjdC6VcBNHVSB7o0Cz8sm+0UMbtH36HLOe5bnc weiRrQ== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gyav4a29h-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 28 Sep 2026 10:35:23 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-9106bb33cdfso5202486d6.2 for ; Mon, 28 Sep 2026 03:35:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790591722; x=1791196522; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=A36i+8Y0LPlWxU4cYfGu/QYHKhlLH1yQq9y13jnpBgU=; b=AZzVGDGfQANjMFWfXLiGuOw3Xtlr3xcH+O/T71npuG8q0oCjxXhnvuNwzgRykgh+3P JPSYr62enVjsauHu3RUhCVYNaU66Zc+uBzvz/q4m6Fi0BPzUxQe4aOVgUByQ0qf4UkaC z3LpgW+5Q2EQYg9Ks01uPLX8Ou1DFkLeIZjNHxjwzs/njsfQlurl0niUWEbAD/75DI7M vqSOshWdS7OWlIE9znqMVVIbUzj+HjCZC3ARuKAxYEyLedWs9yVS2pUNGEnmICWpg8lH 3tMavKufU1u1A1VJ+R2Vrxwh07r+iwx+9hM/jKsjIOd/yPCagpM8thAoJEK8sq3E5Qkj aZXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790591722; x=1791196522; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=A36i+8Y0LPlWxU4cYfGu/QYHKhlLH1yQq9y13jnpBgU=; b=hW+bAXQZ6QJkIKytjFy9xxfZhg294YpIAEj0O9oSQkwlGKv7g2FLDu5rdCgw8c97sJ nUocnDCc6EkZSTEpcbD5Q23A0ulmck04GW2WMp5ljhyxoC3Zq6/YkTjd4pnDL8ZuaQpw VzfreVnqpx93AWbqFCRn0H8fqaBmpZD6pNq7tJ2dHIbnoDjuMnGgPab3vTDlAVJzEtpg TGoMiQq4eMjNK8Tb87B1LpSK1karfERRlRL9XJvCBgfn/5jrBSNArccklX/GMDVcjWAU sQlaqHN4mPyoONwI9nmTpoKtexSv20Tlok7scYH+uDdDJ1V9vPr1DqhP7/pLaGIE6UaM bRPw== X-Forwarded-Encrypted: i=1; AKwUvBzgiK1LSULbOOOADQdWYPM92rO8cFhswA7aDQGxFBHGCQuUMyIGXx2g6atqYkWj6JhMOlnNjWJNqDmwT5Y=@vger.kernel.org X-Gm-Message-State: AFq9FYLrA1tZE0A4zrWHMAhM2+KOGNDT9j7Zd2xW2G/lfJYF0fKYCMu/ JTlwhUhtBHO8mqMvODDYBQ67aXUkseoPmCBTZLDBrzvwy4xsh+Va+x//EKfsHe0L7sqB4efnYiY FKWXfSvkb90TnLFOeznh4/PkIr0oRyfU4NmHlNfIi1f25N55kQ99hNF9lTsoMlhObrjwSng4sC4 w= X-Gm-Gg: AYBFou2oaH8GAhkbn06bCdnHjQ2uNAOCEucm0HKJJX9A6hkKayugc201WsNUSXXGieg 1siByh3LqTmBubM/ZNkaXWZnP+bhQIqwxyZz488VcGpd0gnYST9rjMd60Gnb7AVw3541gPfbvG6 6GToR62iq17Gyyeey8FsGoklaitOZKDg3vm5jLxFpch1aKX/GuGU4S+ns5Gqvl97DOyovrIKVaq bx6M0LlB3yUPmOZf4pmz3/69W6rUuezdCDWmxr9fzjF7La8oKeF1gT/xGlJX+b1vcUHVEY1JOHG aZnoluUJinOzzE5fZAGn2KiUqBl3p95ebbgPAeouV1T8thdsQRaGiWYf+tvEMCVEfp1SS/wnEH/ l2vvZgi1kLTCihdPSBBB9SQ== X-Received: by 2002:a05:6214:5d04:b0:90e:8d21:714 with SMTP id 6a1803df08f44-9142f767dc4mr170597506d6.2.1790591722128; Mon, 28 Sep 2026 03:35:22 -0700 (PDT) X-Received: by 2002:a05:6214:5d04:b0:90e:8d21:714 with SMTP id 6a1803df08f44-9142f767dc4mr170597206d6.2.1790591721683; Mon, 28 Sep 2026 03:35:21 -0700 (PDT) Received: from [192.168.202.12] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c2dcf626b3esm172894866b.27.2026.09.28.03.35.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Sep 2026 03:35:20 -0700 (PDT) Message-ID: <30d8a155-9e36-4fb0-91a8-8d95b266d30b@oss.qualcomm.com> Date: Mon, 28 Sep 2026 12:35:19 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] pinctrl: qcom: ipq5018: add required gpios and missing PWM functions To: george.moussalem@outlook.com, Bartosz Golaszewski , Bjorn Andersson , Linus Walleij Cc: linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260924-ipq5018-pwm-functions-v1-1-8990a4e85b2f@outlook.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260924-ipq5018-pwm-functions-v1-1-8990a4e85b2f@outlook.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 7nGdTbSLYBmQ5AnWKA9vaG0XE6dOYNpr X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI4MDA0MiBTYWx0ZWRfX/N+KghJgOZVB M6p9ztJEJWsSbY0CavBd8dzoLDokr5ASyKAsHtxEijtW3gNAFAIB4Uh/Y904ESK3SeDn4W/kW29 /+BitM5PaEQf7OWt1qrHKhkTAOeBeikhAZwf6aaMTZOARQq9PF1BhrSE+7wF6l1ITl8MIiUVL/0 Q+O0nbvzHJf2YKVKj33LqzYC1RtsvrUXslsOnxrXomUQ6yo3JYMF6ydo08KS/Lp93d61i8ozlPL PKNY9tax4iWjGVVP/x4IKNoXzL+/FnrzLSnNlg4YOmKeOqHOMaaZoM44QICTmMg3CYwD1zcuQrH LrwUOVwVXCeGh6VKKGilA2lcqd9VKw/ZlKv284OmSzWVaLNHGievI36rvqhQ1Ipns88VmdiYJl7 ActJakMByvMfF+jPoQnTaZ2sBHuHLvWjudLhMSPnMkgXjfYy0xS3TmZyj1j3DXVdFscdblh/Nsq eVVJIEdp4qk4eObteXQ== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI4MDA0MiBTYWx0ZWRfX3qCl/5ykNYsh fW0kT22fgf7uQ2HraZRUfs2ttUSOI7iQ6IPtPhMjDb3AzDplo5gFnJuZo3sYMDA4oYiF6O0xq85 JRnv0EEJvXIv5OOVIpdDZY4u7RogRIA= X-Proofpoint-ORIG-GUID: 7nGdTbSLYBmQ5AnWKA9vaG0XE6dOYNpr X-Authority-Analysis: v=2.4 cv=MqLHeGae c=1 sm=1 tr=0 ts=6aba42eb cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=UqCG9HQmAAAA:8 a=k9Tl5aKVw7jfSEjyEx0A:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-28_02,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 lowpriorityscore=0 suspectscore=0 impostorscore=0 phishscore=0 adultscore=0 clxscore=1015 priorityscore=1501 spamscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609280042 On 9/24/26 2:22 PM, George Moussalem via B4 Relay wrote: > From: George Moussalem > > On multiple Linksys routers, GPIO 1, 30, and 46 are used to drive the > PWM led on PWM1, PWM3, and PWM0 channels respectively, so let's update > the pwm# and pingroups accordingly. > > Signed-off-by: George Moussalem > --- > drivers/pinctrl/qcom/pinctrl-ipq5018.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/pinctrl/qcom/pinctrl-ipq5018.c b/drivers/pinctrl/qcom/pinctrl-ipq5018.c > index 84392fe258c9..74fccdd5146a 100644 > --- a/drivers/pinctrl/qcom/pinctrl-ipq5018.c > +++ b/drivers/pinctrl/qcom/pinctrl-ipq5018.c > @@ -539,7 +539,7 @@ static const char * const qdss_tracectl_b_groups[] = { > }; > > static const char * const pwm0_groups[] = { > - "gpio42", > + "gpio42", "gpio46", > }; > > static const char * const qdss_cti_trig_out_b0_groups[] = { > @@ -547,7 +547,7 @@ static const char * const qdss_cti_trig_out_b0_groups[] = { > }; > > static const char * const pwm1_groups[] = { > - "gpio43", > + "gpio43", "gpio1", Nit: please keep the added entries sorted Konrad