mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vincent Mailhol <mailhol@kernel.org>
To: Dave Hansen <dave.hansen@intel.com>,
	Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] x86/cpu: don't gate PROCESSOR_SELECT with EXPERT
Date: Wed, 11 Nov 2026 16:38:38 +0100	[thread overview]
Message-ID: <30db0b9c-cd43-409e-a39c-f91dee446d55@kernel.org> (raw)
In-Reply-To: <efe70a7a-32ad-4b7c-a514-b27bc1ac16b3@kernel.org>

Hi Dave, Boris,

On 01/11/2026 at 12:26, Vincent Mailhol wrote:
> On 31/10/2026 at 14:58, Dave Hansen wrote:
>> On 10/31/26 00:51, Vincent Mailhol wrote:
>>> Remove the EXPERT dependency from PROCESSOR_SELECT. Make the option N by
>>> default so that all x86 CPU types remain supported by default.
>>
>> I actually kinda despise the vendor selection stuff in the first place.
>>
>> It just causes problems. Like for protection keys. I diligently made it
>> Intel-only when it was merged. But AMD came along and ruined my party
>> when they added support for it. We had to go do more work later to make
>> it available on AMD.
> 
> I think I am still missing the connection between the protection-key
> example and keeping PROCESSOR_SELECT behind EXPERT. When AMD added
> protection-key support, the dependency needed updating regardless of
> whether vendor selection was visible outside EXPERT.
> 
> I understand that setting the correct CPU_SUP_* dependencies can be
> challenging, but those dependencies are the developer's
> responsibility. I don't think EXPERT is intended to hide symbols
> whose dependencies are difficult to implement correctly in Kconfig. My
> understanding is that it hides questions which require advanced
> knowledge from the user configuring the kernel.
> 
>> It's also one of those things that inevitably hides build problems.
>>
>> Hiding it all behind EXPERT seems very prudent to me. I'm not seeing
>> justification in this series to change that.
> 
> My justification is that the configuration process currently seems
> backward. For example, an AMD-only build doesn't need
> MITIGATION_CALL_DEPTH_TRACKING. Today, the user would need to navigate
> the "Mitigations for CPU vulnerabilities" menu and understand that
> option to disable it individually. It seems easier to ask which CPU
> vendors need to be supported and let Kconfig exclude features specific
> to the other vendors. The same reasoning applies to other symbols with
> CPU_SUP_* dependencies.
> 
> Generally speaking, my opinion is that EXPERT should be applied to the
> child symbols rather than their parents. The deeper we go in the
> dependency tree, the more specialised the options become and the more
> expertise they require.
> 
> I agree that keeping vendor selection behind EXPERT reduces exposure
> to configuration combinations that may receive limited testing. But if
> there is a bug in Kconfig, is limiting exposure the correct strategy?
> In the end, it just hides a genuine bug without addressing the root
> cause.

Have you had a chance to read my replies?

I wrote patch 3 because, as a user configuring a kernel for my own
machine, I felt that choosing the supported CPU vendors directly
improved the configuration experience.

If, after considering my arguments, you still prefer to keep
PROCESSOR_SELECT behind EXPERT, that's fine with me. In that case, would
you consider picking up patches 1 and 2 independently?


Yours sincerely,
Vincent Mailhol


  reply	other threads:[~2026-11-11 15:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-31  7:51 [PATCH 0/3] x86: Make processor vendor selection available without EXPERT Vincent Mailhol
2026-10-31  7:51 ` [PATCH 1/3] x86/mce: Add CPU_SUP_* dependencies for Intel/Zhaoxin MCE features Vincent Mailhol
2026-11-11 15:46   ` Dave Hansen
2026-10-31  7:51 ` [PATCH 2/3] x86/numa: Add CPU_SUP_AMD dependency for legacy AMD NUMA Vincent Mailhol
2026-10-31  7:51 ` [PATCH 3/3] x86/cpu: don't gate PROCESSOR_SELECT with EXPERT Vincent Mailhol
2026-10-31 13:58   ` Dave Hansen
2026-11-01 11:26     ` Vincent Mailhol
2026-11-11 15:38       ` Vincent Mailhol [this message]
2026-11-11 15:45         ` Dave Hansen
2026-10-31 21:43 ` [PATCH 0/3] x86: Make processor vendor selection available without EXPERT Borislav Petkov
2026-11-01 11:27   ` Vincent Mailhol

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=30db0b9c-cd43-409e-a39c-f91dee446d55@kernel.org \
    --to=mailhol@kernel.org \
    --cc=bp@alien8.de \
    --cc=dave.hansen@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®