mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Sedlak <daniel@sedlak.dev>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
	guilherme giacomo simoes <trintaeoitogc@gmail.com>,
	Wayne Campbell <wcampbell1995@gmail.com>
Cc: ojeda@kernel.org, alex.gaynor@gmail.com, boqun.feng@gmail.com,
	gary@garyguo.net, bjorn3_gh@protonmail.com,
	benno.lossin@proton.me, a.hindborg@kernel.org,
	aliceryhl@google.com, tmgross@umich.edu, walmeida@microsoft.com,
	fujita.tomonori@gmail.com, tahbertschinger@gmail.com,
	rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [PATCH] rust: macros: add authors
Date: Sat, 7 Dec 2024 11:14:59 +0100	[thread overview]
Message-ID: <30ddfc7f-4b13-4caf-8859-2cd2e72ef878@sedlak.dev> (raw)
In-Reply-To: <CANiq72neo_RtANWJu_GW5LxsR5KWxriS1L8nsXkNn7ioiaEQKQ@mail.gmail.com>



On 12/6/24 9:17 PM, Miguel Ojeda wrote:
> There are several ways we could do this:
> 
>    - A single field, that only accepts a list.
> 
>    - A single field that accepts both a string or a list.

Since module is a macro, if we would allow syntax in the macro like:

	authors: ["author1", "author2", ...]

I think we could fight with the code formatting, because when it comes 
to the rust macros, rustfmt is often very confused and we could end up 
with variations like:

	authors: ["author1", "author2",
			"author3"]

or

	authors: [
		   "author1",
		   "author2",
		  ]

and rustfmt would be totally ok with both of them.

> 
>    - Two fields like this (that cannot coexist).
> 
>    - Accepting several "author" fields and append them all into a list.
> 

I think accepting several "author" fields is the best one because it 
mirrors the C API, where in C when you want to specify more authors you 
just repeat the MODULE_AUTHOR("author<N>") macro.

  parent reply	other threads:[~2024-12-07 10:15 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-06 19:22 guilherme giacomo simoes
2024-12-06 20:17 ` Miguel Ojeda
2024-12-06 21:19   ` guilherme giacomo simoes
2024-12-06 22:42     ` Miguel Ojeda
2024-12-07  1:47   ` guilherme giacomo simoes
2024-12-07 10:14   ` Daniel Sedlak [this message]
2024-12-07 16:07     ` guilherme giacomo simoes
2024-12-09 12:21       ` Daniel Sedlak
2024-12-09 11:47     ` [PATCH] " Miguel Ojeda
2024-12-09 12:29       ` Daniel Sedlak
2024-12-09 13:14         ` guilherme giacomo simoes
2024-12-09 12:55       ` guilherme giacomo simoes
2024-12-09  3:59 ` [PATCH] " kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=30ddfc7f-4b13-4caf-8859-2cd2e72ef878@sedlak.dev \
    --to=daniel@sedlak.dev \
    --cc=a.hindborg@kernel.org \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=benno.lossin@proton.me \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=fujita.tomonori@gmail.com \
    --cc=gary@garyguo.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tahbertschinger@gmail.com \
    --cc=tmgross@umich.edu \
    --cc=trintaeoitogc@gmail.com \
    --cc=walmeida@microsoft.com \
    --cc=wcampbell1995@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®