From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D12D38737E for ; Tue, 13 Jan 2026 09:49:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768297760; cv=none; b=d4CTRwpoCy9DWQKTIyUFJsgTCQRJ4D4i4Fi4d3+HhemKyrXLmv9VoEPGZaTIDWTd2/a7YogYonSQDcOgSI3gsvBwKUh40/wrbifvZyzTHblPiZKOY1zHDZdkdnMtI0HSN7Wi+y1J3ieT4qtoR+iVuud7ZNfW9jWM3hh3KsFTz9M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768297760; c=relaxed/simple; bh=rldiau7LJXcOO0Pd+JfsXVEuF+CP8SBS2Jq+Rj28UZU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uwUMqgHp7IhWGctt5EeRaVXD8HAOv5XDGAOdUL/Kd5kfgkf11axkiWvMs327Qfui/FLrgZAbSiqaf6qPOaQNmdJCA+VeGbgtvyjcjwFyrDsC5a4VX9T99nt7Xhcur3FiepkpGguhMoTzvTsfzmKO+pnzjrrfQosskVOe8yAf+xQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=EWcMNFQW; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="EWcMNFQW" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-47edd9024b1so1692905e9.3 for ; Tue, 13 Jan 2026 01:49:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1768297757; x=1768902557; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=IkR4LfU8d2LcPG3/noB2c/VdgPhARHyvnvpu09hPr6M=; b=EWcMNFQWokyYQ1jUiWOXeyE8jfBbb6FhKM9F9XRStv1glTWorFRarMFJZPmkKNEO/f EkANhkpLx16EK70m5VKLJR+TNiZN9lx6JqlcZw8ELi01L/csvsTEOBh4zdd/AgTsW7Fe 1fN5FHNTqwnOGa6T7xbsbhe+5bFKNdQvT9fnl+C6nZgqIAbQmKCgZ4uB6607HHJOvfzM 90Lexj/lYOCeESrOJ59ethuRtgD3pA1fzI6s0EwcSs+scsPiHG4Voa+ftsSuv1KuoixA CjE7s15eWR7mP9Al5b7HvrxAUsnqbgI2dU9aJJLXdSYCyq4cjJKg9WE6BgvEoAC2Wieu MISw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768297757; x=1768902557; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IkR4LfU8d2LcPG3/noB2c/VdgPhARHyvnvpu09hPr6M=; b=a63lHzrIMfPNmoYQk6gBK0PQQYda4mjX7jtZIXwa7Pl+OVQsn/7tu2b1BWBZ+5iX+u ESXjaLo6zNX054bJ0OhB6GKe13nb3dOcHiowEGiv+sd1yUvWJSG2X/zmgyv1KiBjyxR2 vw9QgxD2STLQWfe9tc6ZzzyxgDJMegDpzGz8UzZ/IfdOs+8ejTzOUiSxJZRwz7FzB0A3 u9m4DGWnKSaesZEZJSFZDcII8C13FB+DpcuXskh2sZbHVoYT64dfRcvmCMYXmML6Lg9G XwCfiNNMrVQeZJuebrbSFbdZH/cmdj++Hk1KD4vikBSVZ+Er87Jb1rJ+Q3RdVQ1EOSqC XoOw== X-Forwarded-Encrypted: i=1; AJvYcCWj1U3JEE5iRqYKUWecJr257YZZv22bs7P63killdScjs8n+AqvxtGJHVpWmoW9+WNGhpc4QNiziu6/CAc=@vger.kernel.org X-Gm-Message-State: AOJu0Yz+GSV3PNWoz7II1dJHpdgNIoQUxXlgkfwAwKlVjT9bBq2FR7v/ ooyW3wKpmcAFq3wWBUsKitnjNpLr2pPJ1eqvR1s7fVOpNj0UhkK7LvGBcT5/lfVuJek= X-Gm-Gg: AY/fxX6Grk8ZmlZ77eoXh1zQyCmDQHbt3C9Nki0nI8+PrUH8d2fuEIErsT1HWWaau8W y0J6kXZIMZKb3plsYdagEkWIxYpwiJfzYcfzwXHgoBDd9Qo7Rzu/bysL1k/XNq1UD8oF+Oqo/34 wZn6AEBYoFoFqwUdXjxxbHy8v1aPOdmXxKhTUweG7ZPp9qvB+80EmiENedujpaVXoUMvGUY5OBt gWoL2UL/GucFqNMSzu4emCZ+hOtA4F1cPK++mwjwkJ/jzzQJGCmNKP7cyVTPogL8Wwakq0pheGo 47tdaaskeMbUjucY7800XtT4LseYB+XEYszkzZqwY3Gkx27FtC9AysAQZALAmgpEWEG4QaHyMsN VzFbeTYGjXwgg08M57jOSEjlbdHt+M4bUhi59eDOtuZ/FcwUDF7LkjV5NNnrTrzVx9CWsU/xsDJ fPmPkbByE1x6EO0iZVb8MSFaZqXM20Q/IEMLZUhab4lyilix7/dl8HVIM= X-Google-Smtp-Source: AGHT+IFljzIApLs6K0urPpIfNVxYXphnQ4IkgtF/Eo8NnIXz1bAxvwl/i9fym1QFfouIdmsnW3s6JQ== X-Received: by 2002:a05:600c:820f:b0:477:a978:3a7b with SMTP id 5b1f17b1804b1-47d84b32f09mr213986235e9.22.1768297757438; Tue, 13 Jan 2026 01:49:17 -0800 (PST) Received: from ?IPV6:2001:a61:138d:5701:1aab:ab2a:99f8:6c9a? ([2001:a61:138d:5701:1aab:ab2a:99f8:6c9a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd5df90dsm43504596f8f.20.2026.01.13.01.49.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jan 2026 01:49:16 -0800 (PST) Message-ID: <30e2487e-5738-46bc-95f7-8d0ba3ba9b1a@suse.com> Date: Tue, 13 Jan 2026 10:49:16 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [syzbot] [usb?] INFO: task hung in i2c_tiny_usb_disconnect To: weipeng , syzbot+30b78308ba7e64647ff8@syzkaller.appspotmail.com Cc: anna-maria@linutronix.de, frederic@kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, syzkaller-bugs@googlegroups.com, tglx@linutronix.de References: <6963d09e.050a0220.eaf7.0070.GAE@google.com> <20260113075210.39425-1-coderlogicwei@gmail.com> Content-Language: en-US From: Oliver Neukum In-Reply-To: <20260113075210.39425-1-coderlogicwei@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 13.01.26 08:52, weipeng wrote: > @@ -287,9 +311,9 @@ static void i2c_tiny_usb_disconnect(struct usb_interface *interface) > { > struct i2c_tiny_usb *dev = usb_get_intfdata(interface); > > - i2c_del_adapter(&dev->adapter); > usb_set_intfdata(interface, NULL); > - i2c_tiny_usb_free(dev); > + WRITE_ONCE(dev->disconnected, true); > + queue_work(system_long_wq, &dev->release_work); Hi, I am sorry, but this fix is looking a bit fishy. For once what prevents the driver from being unloaded with a work item queued after disconnect() has run? How do you make sure that the disconnected flag is ever read? Regards Oliver