From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4778C433EF for ; Sat, 14 May 2022 03:00:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231538AbiENDAU (ORCPT ); Fri, 13 May 2022 23:00:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231477AbiENC6t (ORCPT ); Fri, 13 May 2022 22:58:49 -0400 Received: from out30-130.freemail.mail.aliyun.com (out30-130.freemail.mail.aliyun.com [115.124.30.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22E452E434B for ; Fri, 13 May 2022 18:41:33 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R151e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04357;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=11;SR=0;TI=SMTPD_---0VD5SDVr_1652492488; Received: from 30.236.14.33(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VD5SDVr_1652492488) by smtp.aliyun-inc.com(127.0.0.1); Sat, 14 May 2022 09:41:29 +0800 Message-ID: <30e805ba-cf4d-c13c-8d34-e1b2d9e77dae@linux.alibaba.com> Date: Sat, 14 May 2022 09:42:06 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v2 1/2] arm64/hugetlb: Use ptep_get() to get the pte value of a huge page To: Anshuman Khandual , catalin.marinas@arm.com, will@kernel.org Cc: mike.kravetz@oracle.com, akpm@linux-foundation.org, songmuchun@bytedance.com, willy@infradead.org, christophe.leroy@csgroup.eu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <88e02de3-c87e-2728-d980-da0e70a58102@arm.com> From: Baolin Wang In-Reply-To: <88e02de3-c87e-2728-d980-da0e70a58102@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/13/2022 6:50 PM, Anshuman Khandual wrote: > > > On 5/13/22 09:07, Baolin Wang wrote: >> The original huge_ptep_get() on ARM64 is just a wrapper of ptep_get(), > > Right, as arm64 does not enable __HAVE_ARCH_HUGE_PTEP_GET. > >> which will not take into account any contig-PTEs dirty and access bits. > > As expected being operating on a single table entry. > >> Meanwhile we will implement a new ARM64-specific huge_ptep_get() >> interface in following patch, which will take into account any contig-PTEs >> dirty and access bits. To keep the same efficient logics to get the pte > > s/logics/logic Will fix. > >> value, change to use ptep_get() as a preparation. >> >> Signed-off-by: Baolin Wang >> Reviewed-by: Muchun Song > > LGTM > > Reviewed-by: Anshuman Khandual Thanks.