From: Randy Dunlap <rdunlap@infradead.org>
To: Patrick Bellasi <patrick.bellasi@arm.com>,
Ingo Molnar <mingo@kernel.org>
Cc: Mark Brown <broonie@kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: linux-next: Tree for Sep 16 (kernel/sched/core.c)
Date: Tue, 17 Sep 2019 08:24:19 -0700 [thread overview]
Message-ID: <30eb4c83-a90d-21aa-3f9e-4da8e66769ef@infradead.org> (raw)
In-Reply-To: <8736gv2gbv.fsf@arm.com>
On 9/17/19 6:38 AM, Patrick Bellasi wrote:
>
> On Tue, Sep 17, 2019 at 08:52:42 +0100, Ingo Molnar wrote...
>
>> * Randy Dunlap <rdunlap@infradead.org> wrote:
>>
>>> On 9/16/19 3:38 PM, Mark Brown wrote:
>>>> Hi all,
>>>>
>>>> Changes since 20190915:
>>>>
>>>
>>> on x86_64:
>>>
>>> when CONFIG_CGROUPS is not set:
>
> Hi Randy,
> thanks for the report.
>
>>> CC kernel/sched/core.o
>>> ../kernel/sched/core.c: In function ‘uclamp_update_active_tasks’:
>>> ../kernel/sched/core.c:1081:23: error: storage size of ‘it’ isn’t known
>>> struct css_task_iter it;
>>> ^~
>>> CC kernel/printk/printk_safe.o
>>> ../kernel/sched/core.c:1084:2: error: implicit declaration of function ‘css_task_iter_start’; did you mean ‘__sg_page_iter_start’? [-Werror=implicit-function-declaration]
>>> css_task_iter_start(css, 0, &it);
>>> ^~~~~~~~~~~~~~~~~~~
>>> __sg_page_iter_start
>>> ../kernel/sched/core.c:1085:14: error: implicit declaration of function ‘css_task_iter_next’; did you mean ‘__sg_page_iter_next’? [-Werror=implicit-function-declaration]
>>> while ((p = css_task_iter_next(&it))) {
>>> ^~~~~~~~~~~~~~~~~~
>>> __sg_page_iter_next
>>> ../kernel/sched/core.c:1091:2: error: implicit declaration of function ‘css_task_iter_end’; did you mean ‘get_task_cred’? [-Werror=implicit-function-declaration]
>>> css_task_iter_end(&it);
>>> ^~~~~~~~~~~~~~~~~
>>> get_task_cred
>>> ../kernel/sched/core.c:1081:23: warning: unused variable ‘it’ [-Wunused-variable]
>>> struct css_task_iter it;
>>> ^~
>>>
>>
>> I cannot reproduce this build failue: I took Linus's latest which has all
>> the -next scheduler commits included (ad062195731b), and an x86-64 "make
>> defconfig" and a disabling of CONFIG_CGROUPS still resuls in a kernel
>> that builds fine.
>
> Same here Ingo, I cannot reproduce on arm64 and !CONFIG_CGROUPS and
> testing on tip/sched/core.
>
> However, if you like, the following patch can make that code a
> bit more "robust".
>
> Best,
> Patrick
>
> ---8<---
> From 7e17b7bb08dd8dfc57e01c2a7b6875439eb47cbe Mon Sep 17 00:00:00 2001
> From: Patrick Bellasi <patrick.bellasi@arm.com>
> Date: Tue, 17 Sep 2019 14:12:10 +0100
> Subject: [PATCH 1/1] sched/core: uclamp: Fix compile error on !CONFIG_CGROUPS
>
> Randy reported a compiler error on x86_64 and !CONFIG_CGROUPS which is due
> to uclamp_update_active_tasks() using the undefined css_task_iter().
>
> Since uclamp_update_active_tasks() is used only when cgroup support is
> enabled, fix that by properly guarding that function at compile time.
>
> Signed-off-by: Patrick Bellasi <patrick.bellasi@arm.com>
> Link: https://lore.kernel.org/lkml/1898d3c9-1997-17ce-a022-a5e28c8dc115@infradead.org/
> Fixes: commit babbe170e05 ("sched/uclamp: Update CPU's refcount on TG's clamp changes")
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Thanks.
> ---
> kernel/sched/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 3c7b90bcbe4e..14873ad4b34a 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -1043,6 +1043,7 @@ static inline void uclamp_rq_dec(struct rq *rq, struct task_struct *p)
> uclamp_rq_dec_id(rq, p, clamp_id);
> }
>
> +#ifdef CONFIG_UCLAMP_TASK_GROUP
> static inline void
> uclamp_update_active(struct task_struct *p, enum uclamp_id clamp_id)
> {
> @@ -1091,7 +1092,6 @@ uclamp_update_active_tasks(struct cgroup_subsys_state *css,
> css_task_iter_end(&it);
> }
>
> -#ifdef CONFIG_UCLAMP_TASK_GROUP
> static void cpu_util_update_eff(struct cgroup_subsys_state *css);
> static void uclamp_update_root_tg(void)
> {
>
--
~Randy
next prev parent reply other threads:[~2019-09-17 15:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-16 22:38 linux-next: Tree for Sep 16 Mark Brown
2019-09-17 5:05 ` linux-next: Tree for Sep 16 (kernel/sched/core.c) Randy Dunlap
2019-09-17 7:52 ` Ingo Molnar
2019-09-17 13:38 ` Patrick Bellasi
[not found] ` <871rwf2fr0.fsf@arm.com>
2019-09-17 15:07 ` Randy Dunlap
2019-09-17 15:24 ` Randy Dunlap [this message]
2019-09-18 6:05 ` Ingo Molnar
2019-09-18 10:03 ` Patrick Bellasi
2019-09-25 1:31 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30eb4c83-a90d-21aa-3f9e-4da8e66769ef@infradead.org \
--to=rdunlap@infradead.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=patrick.bellasi@arm.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®