From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Maciej Strozek <mstrozek@opensource.cirrus.com>,
Mark Brown <broonie@kernel.org>
Cc: Cezary Rojewski <cezary.rojewski@intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
alsa-devel@alsa-project.org, patches@opensource.cirrus.com,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ASoC: Intel: mtl-match: Add cs42l43_l0 cs35l56_l23 for MTL
Date: Tue, 23 Jan 2024 09:34:00 +0100 [thread overview]
Message-ID: <30f022a5-7ab1-4b2d-b4c1-5a209ec67c5b@linux.intel.com> (raw)
In-Reply-To: <20240122151545.69437-1-mstrozek@opensource.cirrus.com>
On 1/22/24 16:15, Maciej Strozek wrote:
It wouldn't hurt to add a brief commit message describing what the
hardware layout is, specifically how the mics are handled.
It's also best to submit the corresponding machine driver updates at the
same time to check for consistency.
> },
> + {
> + .link_mask = BIT(0) | BIT(2) | BIT(3),
> + .links = cs42l43_link0_cs35l56_link2_link3,
> + .drv_name = "sof_sdw",
> + .sof_tplg_filename = "sof-mtl-cs42l43-l0-cs35l56-l23.tplg",
was this topology submitted to the SOF tree? I don't see it, usually we
review topology/acpi/machine stuff together to avoid disconnects.
> + },
> {
> .link_mask = GENMASK(2, 0),
> .links = mtl_cs42l43_cs35l56,
> --
> 2.34.1
>
next prev parent reply other threads:[~2024-01-23 8:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 15:15 Maciej Strozek
2024-01-23 8:34 ` Pierre-Louis Bossart [this message]
2024-01-23 8:48 ` Maciej Strozek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30f022a5-7ab1-4b2d-b4c1-5a209ec67c5b@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=mstrozek@opensource.cirrus.com \
--cc=patches@opensource.cirrus.com \
--cc=peter.ujfalusi@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®