From: YueHaibing <yuehaibing@huawei.com>
To: David Miller <davem@davemloft.net>
Cc: <joe@perches.com>, <gregkh@linuxfoundation.org>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH] appletalk: Fix potential NULL pointer dereference in unregister_snap_client
Date: Thu, 14 Mar 2019 11:18:43 +0800 [thread overview]
Message-ID: <30fa0130-1a4d-39a1-05d7-130545d274e1@huawei.com> (raw)
In-Reply-To: <20190313.140324.1217171685315730689.davem@davemloft.net>
On 2019/3/14 5:03, David Miller wrote:
> From: Yue Haibing <yuehaibing@huawei.com>
> Date: Tue, 12 Mar 2019 10:04:26 +0800
>
>> timer_setup(&aarp_timer, aarp_expire_timeout, 0);
>> aarp_timer.expires = jiffies + sysctl_aarp_expiry_time;
>> add_timer(&aarp_timer);
>> - register_netdevice_notifier(&aarp_notifier);
>> + rc = register_netdevice_notifier(&aarp_notifier);
>> + if (rc)
>> + unregister_snap_client(aarp_dl);
>> + return rc;
>
> You've left the timer running in this error path.
Oops, sorry, I'll resend to fix it.
>
> .
>
prev parent reply other threads:[~2019-03-14 3:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-12 2:04 Yue Haibing
2019-03-13 21:03 ` David Miller
2019-03-14 3:18 ` YueHaibing [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30fa0130-1a4d-39a1-05d7-130545d274e1@huawei.com \
--to=yuehaibing@huawei.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®