mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Helge Deller <deller@gmx.de>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>, jejb@parisc-linux.org
Cc: linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org
Subject: Re: [PATCH 0/8] constify parisc parisc_device_id
Date: Mon, 21 Aug 2017 22:42:42 +0200	[thread overview]
Message-ID: <30fb04dd-118e-d866-0166-2f9a8e67ff1a@gmx.de> (raw)
In-Reply-To: <1503164546-31433-1-git-send-email-arvind.yadav.cs@gmail.com>

Hi Arvind,

On 19.08.2017 19:42, Arvind Yadav wrote:
> parisc_device_id are not supposed to change at runtime. All functions
> working with parisc_device_id provided by <asm/parisc-device.h> work with
> const parisc_device_id. So mark the non-const structs as const.

Basically your patches are correct, but those structs aren't used
after bootup any longer.
So, they are much better placed in the __initconst or __initdata
sections so that they get dropped before the kernel enters userspace.
Changing it to __initconst includes more changes to those files
than just changing one line.

So, I won't apply your patches.
Instead I've hacked up new versions in my tree which move those to 
__init* sections.

Anyway, thanks for your patches!

Helge 
 
> Arvind Yadav (8):
>   [PATCH 1/8] parisc: asp: constify parisc_device_id
>   [PATCH 2/8] parisc: ccio: constify parisc_device_id
>   [PATCH 3/8] parisc: dino: constify parisc_device_id
>   [PATCH 4/8] parisc: hppb: constify parisc_device_id
>   [PATCH 5/8] parisc: lasi: constify parisc_device_id
>   [PATCH 6/8] parisc: lba_pci: constify parisc_device_id
>   [PATCH 7/8] parisc: sba_iommu: constify parisc_device_id
>   [PATCH 8/8] parisc: wax: constify parisc_device_id
> 
>  drivers/parisc/asp.c         | 2 +-
>  drivers/parisc/ccio-rm-dma.c | 2 +-
>  drivers/parisc/dino.c        | 2 +-
>  drivers/parisc/hppb.c        | 2 +-
>  drivers/parisc/lasi.c        | 2 +-
>  drivers/parisc/lba_pci.c     | 2 +-
>  drivers/parisc/sba_iommu.c   | 2 +-
>  drivers/parisc/wax.c         | 2 +-
>  8 files changed, 8 insertions(+), 8 deletions(-)
> 

      parent reply	other threads:[~2017-08-21 20:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-19 17:42 Arvind Yadav
2017-08-19 17:42 ` [PATCH 1/8] parisc: asp: constify parisc_device_id Arvind Yadav
2017-08-19 17:42 ` [PATCH 2/8] parisc: ccio: " Arvind Yadav
2017-08-19 17:42 ` [PATCH 3/8] parisc: dino: " Arvind Yadav
2017-08-19 17:42 ` [PATCH 4/8] parisc: hppb: " Arvind Yadav
2017-08-19 17:42 ` [PATCH 5/8] parisc: lasi: " Arvind Yadav
2017-08-19 17:42 ` [PATCH 6/8] parisc: lba_pci: " Arvind Yadav
2017-08-19 17:42 ` [PATCH 7/8] parisc: sba_iommu: " Arvind Yadav
2017-08-19 17:42 ` [PATCH 8/8] parisc: wax: " Arvind Yadav
2017-08-21 20:42 ` Helge Deller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=30fb04dd-118e-d866-0166-2f9a8e67ff1a@gmx.de \
    --to=deller@gmx.de \
    --cc=arvind.yadav.cs@gmail.com \
    --cc=jejb@parisc-linux.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®