From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Tinghan Shen <tinghan.shen@mediatek.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Mark Brown <broonie@kernel.org>, YC Hung <yc.hung@mediatek.com>,
Curtis Malainey <cujomalainey@chromium.org>,
Allen-KH Cheng <allen-kh.cheng@mediatek.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v2 1/3] dt-bindings: dsp: mediatek: Use meaningful names for mbox
Date: Mon, 13 Jun 2022 14:41:19 +0200 [thread overview]
Message-ID: <30fcd090-0f31-5a7a-ec14-11098aac8e5c@collabora.com> (raw)
In-Reply-To: <20220609083101.24195-2-tinghan.shen@mediatek.com>
Il 09/06/22 10:30, Tinghan Shen ha scritto:
> Rename mbox according to action instead of 'mbox0' and 'mbox1'.
>
> Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
> ---
> .../devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml b/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml
> index b7e68b0dfa13..6cedd6868cc5 100644
> --- a/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml
> +++ b/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml
> @@ -55,8 +55,8 @@ properties:
>
> mbox-names:
> items:
> - - const: mbox0
> - - const: mbox1
> + - const: rep
> + - const: req
"reply", "request" - as said on patch [2/3]....
P.S.: Adding context for anyone else reading this patch, mt8195 devicetrees didn't
get any dsp node yet.
>
> memory-region:
> items:
> @@ -100,6 +100,6 @@ examples:
> memory-region = <&adsp_dma_mem_reserved>,
> <&adsp_mem_reserved>;
> power-domains = <&spm 6>; //MT8195_POWER_DOMAIN_ADSP
> - mbox-names = "mbox0", "mbox1";
> + mbox-names = "rep", "req";
> mboxes = <&adsp_mailbox0>, <&adsp_mailbox1>;
> };
next prev parent reply other threads:[~2022-06-13 17:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-09 8:30 [PATCH v2 0/3] Add MT8186 ADSP dt-binding Tinghan Shen
2022-06-09 8:30 ` [PATCH v2 1/3] dt-bindings: dsp: mediatek: Use meaningful names for mbox Tinghan Shen
2022-06-13 12:41 ` AngeloGioacchino Del Regno [this message]
2022-06-15 17:30 ` Krzysztof Kozlowski
2022-06-09 8:31 ` [PATCH v2 2/3] firmware: " Tinghan Shen
2022-06-13 12:37 ` AngeloGioacchino Del Regno
2022-06-15 3:22 ` Tinghan Shen
2022-06-09 8:31 ` [PATCH v2 3/3] dt-bindings: dsp: mediatek: add mt8186 dsp document Tinghan Shen
2022-06-15 17:32 ` Krzysztof Kozlowski
2022-06-16 7:34 ` Tinghan Shen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30fcd090-0f31-5a7a-ec14-11098aac8e5c@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=allen-kh.cheng@mediatek.com \
--cc=broonie@kernel.org \
--cc=cujomalainey@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tinghan.shen@mediatek.com \
--cc=yc.hung@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®