From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA8EAC6FD37 for ; Mon, 19 Sep 2022 10:20:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231479AbiISKUf (ORCPT ); Mon, 19 Sep 2022 06:20:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230253AbiISKRU (ORCPT ); Mon, 19 Sep 2022 06:17:20 -0400 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F22331EC5D for ; Mon, 19 Sep 2022 03:17:17 -0700 (PDT) Received: by mail-lf1-x131.google.com with SMTP id a3so34123563lfk.9 for ; Mon, 19 Sep 2022 03:17:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=XOtH2ITlshpecI6bnBjoAK2o/4UpsZgaomPe58WTFa0=; b=GwFABzsbegV66LxbaPP4YDrsxec94wyru8Hz9FS4rgvjS8oOOS858m8qxYp3aMSxnC VCu+vHzF3xlEnnlwmtjkWjY+lrkVKYGVwBVDLgqBVoYi/xwkMUf5+tHzj7F4Ecx8Kx4v H1l9byIZ3wYm6YoXcvgkDLoPJr6kia7fdUOpXgKWjcUJgUfCJuNwGHQOwTfkTKz977CJ PH6G8IeN8iIZ9pkSFILb/BrGWyPv2dhyMr7raDJztLo+oUeIGgN9hzmESOwJHfO9116S Cmm3gwS1dlFMYQAvHt0/97W73qQ6md0kHnBaE6ezK2NFV519DV1U53TwBkEfsFz9IT/T FAYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=XOtH2ITlshpecI6bnBjoAK2o/4UpsZgaomPe58WTFa0=; b=BxzL7XGxAk9T2baiVjQRZ/VzEpJiC0K5aq+kUr59cpdtKDEABdctq26x+GRv2KmnTg myLsXHjqmNS0pCujJy+0aKo261GnSfz7FqbNwhgj3MlRvv51svTvnspqjRuhUKm4Kq0Y d/oTK2qzoqGue8blUm5AA4JUkSG0H+jZfaW5wRez9l2jUVJnAvRyAaCcklavkNu36V9K BSjP22DzN2hSg9MAsz19dljqZRscDzbGXJUZOBLvxmz2JbZ59mqtWdDp3Sk8c6ixT/Hn qR7lNFYIVZTiDYH0XwNQSR3tFHdSLwysG/FtLBRhJmjuW5F3dATz+r7IrpbFn6o1JwUV VQ8w== X-Gm-Message-State: ACrzQf3LMH9qzRWK6wj3GFauXn/eFGAdlEoKG5ZnCDXTvbQNbVNaenxj gbDm/Ck1rNnHpPN0h8zg1U61kA== X-Google-Smtp-Source: AMsMyM6c/cgEmUbMwNS+ktAG5NYNyqQf7jmXokYFYJBjSFcX8SUSKTqHBQ0nwJnCUhV0rlKmUK8rUw== X-Received: by 2002:a05:6512:1283:b0:499:d0a3:3ca8 with SMTP id u3-20020a056512128300b00499d0a33ca8mr5781548lfs.665.1663582636171; Mon, 19 Sep 2022 03:17:16 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id o20-20020ac24bd4000000b0049c29292250sm3847835lfq.149.2022.09.19.03.17.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Sep 2022 03:17:15 -0700 (PDT) Message-ID: <31028736-ba81-122e-b630-b66e9d9d491a@linaro.org> Date: Mon, 19 Sep 2022 12:17:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH 1/6] dt-bindings: phy: ti: phy-gmii-sel: Add bindings for J721e Content-Language: en-US To: Siddharth Vadapalli , Rob Herring Cc: lee.jones@linaro.org, krzysztof.kozlowski+dt@linaro.org, kishon@ti.com, vkoul@kernel.org, dan.carpenter@oracle.com, grygorii.strashko@ti.com, rogerq@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, sjakhade@cadence.com References: <20220914093911.187764-1-s-vadapalli@ti.com> <20220914093911.187764-2-s-vadapalli@ti.com> <20220914161527.GA2269201-robh@kernel.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/09/2022 07:28, Siddharth Vadapalli wrote: >>> @@ -65,12 +66,19 @@ properties: >>> description: | >>> Required only for QSGMII mode. Array to select the port for >>> QSGMII main mode. Rest of the ports are selected as QSGMII_SUB >>> - ports automatically. Any one of the 4 CPSW5G ports can act as the >>> - main port with the rest of them being the QSGMII_SUB ports. >>> - maxItems: 1 >>> - items: >>> - minimum: 1 >>> - maximum: 4 >>> + ports automatically. For J7200 CPSW5G with the compatible: >>> + ti,j7200-cpsw5g-phy-gmii-sel, ti,qsgmii-main-ports is an >>> + array of only one element, which is the port number ranging from >>> + 1 to 4. For J721e CPSW9G with the compatible: >>> + ti,j721e-cpsw9g-phy-gmii-sel, ti,qsgmii-main-ports is an array >>> + of two elements, which corresponds to two potential QSGMII main >>> + ports. The first element and second element of the array can both >>> + range from 1 to 8 each, corresponding to two QSGMII main ports. >>> + For J721e CPSW9G, to configure port 2 as the first QSGMII main >>> + port and port 7 as the second QSGMII main port, we specify: >>> + ti,qsgmii-main-ports = <2>, <7>; >>> + If only one QSGMII main port is desired, mention the same main >>> + port twice. >> >> Two different forms for the same property name is not great. Just make a >> new property if you need something different. > > Thank you for reviewing the patch. Based on the discussion for the > previous series at [1], I had planned to reuse the same property > "ti,qsgmii-main-ports" for TI's J721e device too. The reason for this is > that the property represents the same feature on both devices which is > that of the QSGMII main port. The only difference between the two of > them is that J7200's CPSW5G has 4 external ports while J721e's CPSW9G > has 8 external ports. Thus, J7200 can have at most one QSGMII main port > while J721e can have up to two. Adding a new property which describes > the same feature appears to be redundant to me. Please let me know. > The trouble is that you wrote the description like it were two different properties (for xx this is one element, for yy this is something else). You need to describe the property in unified way. Best regards, Krzysztof