From: Keith Owens <kaos@sgi.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux Kernel Development <linux-kernel@vger.kernel.org>,
linux-xfs@oss.sgi.com
Subject: Re: XFS build error on m68k in 2.5.43
Date: Wed, 16 Oct 2002 21:30:27 +1000 [thread overview]
Message-ID: <31054.1034767827@ocs3.intra.ocs.com.au> (raw)
In-Reply-To: Your message of "Wed, 16 Oct 2002 13:21:39 +0200." <Pine.GSO.4.21.0210161319210.9988-100000@vervain.sonytel.be>
On Wed, 16 Oct 2002 13:21:39 +0200 (MEST),
Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
>When compiling a kernel for m68k (with CONFIG_XFS_FS=m), I get this error:
>
>| make -f fs/xfs/Makefile
>| rm -f fs/xfs/built-in.o; m68k-linux-ar rcs fs/xfs/built-in.o
>| m68k-linux-gcc -Wp,-MD,fs/xfs/linux/.xfs_stats.o.d -D__KERNEL__ -Iinclude -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer -fno-strict-aliasing -fno-common -pipe -fno-strength-reduce -ffixed-a2 -nostdinc -iwithprefix include -DMODULE -Ifs/xfs -funsigned-char -DKBUILD_BASENAME=xfs_stats -c -o fs/xfs/linux/xfs_stats.o fs/xfs/linux/xfs_stats.c
>| In file included from fs/xfs/xfs.h:70,
>| from fs/xfs/linux/xfs_stats.c:33:
>| fs/xfs/xfs_bmap_btree.h:662: badly punctuated parameter list in `#define'
>| fs/xfs/xfs_log.h:62: warning: `_lsn_cmp' defined but not used
>| make[2]: *** [fs/xfs/linux/xfs_stats.o] Error 1
>| make[1]: *** [fs/xfs] Error 2
>| make: *** [fs] Error 2
>
>Since it's not obvious to me what's wrong with that define, I'm asking here.
Spot the typo :(
--- fs/xfs/xfs_bmap_btree.h.orig Wed Oct 16 21:28:36 2002
+++ fs/xfs/xfs_bmap_btree.h Wed Oct 16 21:28:49 2002
@@ -658,8 +658,8 @@
#else
#define xfs_bmbt_disk_set_all(r, s) \
xfs_bmbt_set_all(r, s)
-#define xfs_bmbt_disk_set_allf(r, 0, b, c, v) \
- xfs_bmbt_set_allf(r, 0, b, c, v)
+#define xfs_bmbt_disk_set_allf(r, o, b, c, v) \
+ xfs_bmbt_set_allf(r, o, b, c, v)
#endif
void
next prev parent reply other threads:[~2002-10-16 11:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-16 11:21 Geert Uytterhoeven
2002-10-16 11:30 ` Keith Owens [this message]
2002-10-16 11:31 ` Nikita Danilov
2002-10-16 12:00 ` David S. Miller
2002-10-16 12:11 ` Stephen Lord
2002-10-16 16:27 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31054.1034767827@ocs3.intra.ocs.com.au \
--to=kaos@sgi.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®