mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Like Xu <like.xu@linux.intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: pbonzini@redhat.com, Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@redhat.com>,
	Kan Liang <kan.liang@linux.intel.com>,
	wei.w.wang@intel.com, x86@kernel.org,
	linux-kernel@vger.kernel.org, Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH v5 0/5] perf/x86: Some minor changes to support guest Arch LBR
Date: Fri, 9 Apr 2021 16:51:02 +0800	[thread overview]
Message-ID: <3106c3f9-45c7-d286-5a56-8c6eda8990f2@linux.intel.com> (raw)
In-Reply-To: <91102eac-a315-3165-1670-8313176657f1@linux.intel.com>

Em, does anyone want to review these minor changes?

I believe some of them solve the real problem.

On 2021/4/6 11:20, Like Xu wrote:
> Hi all, do we have any comments on this patch set?
> 
> On 2021/3/26 9:19, Like Xu wrote:
>> Hi Peter,
>>
>> Please help review these minor perf/x86 changes in this patch set,
>> and we need some of them to support Guest Architectural LBR in KVM.
>>
>> This version keeps reserve_lbr_buffers() as is because the LBR xsave
>> buffer is a per-CPU buffer, not a per-event buffer. We only need to
>> allocate the buffer once when initializing the first event.
>>
>> If you are interested in the KVM emulation, please check
>> https://lore.kernel.org/kvm/20210314155225.206661-1-like.xu@linux.intel.com/
>>
>> Please check more details in each commit and feel free to comment.
>>
>> Previous:
>> https://lore.kernel.org/lkml/20210322060635.821531-1-like.xu@linux.intel.com/ 
>>
>>
>> v4->v5 Changelog:
>> - Add "Tested-by: Kan Liang"
>> - Make the commit message simpler
>> - Make check_msr() to ignore msr==0
>> - Use kmem_cache_alloc_node() [Namhyung]
>>
>> Like Xu (5):
>>    perf/x86/intel: Fix the comment about guest LBR support on KVM
>>    perf/x86/lbr: Simplify the exposure check for the LBR_INFO registers
>>    perf/x86: Skip checking MSR for MSR 0x000
>>    perf/x86/lbr: Move cpuc->lbr_xsave allocation out of sleeping region
>>    perf/x86: Move ARCH_LBR_CTL_MASK definition to include/asm/msr-index.h
>>
>>   arch/x86/events/core.c           |  8 +++++---
>>   arch/x86/events/intel/bts.c      |  2 +-
>>   arch/x86/events/intel/core.c     |  7 +++----
>>   arch/x86/events/intel/lbr.c      | 29 ++++++++++++++++++-----------
>>   arch/x86/events/perf_event.h     |  8 +++++++-
>>   arch/x86/include/asm/msr-index.h |  1 +
>>   6 files changed, 35 insertions(+), 20 deletions(-)
>>
> 


      reply	other threads:[~2021-04-09  8:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-26  1:19 Like Xu
2021-03-26  1:19 ` [PATCH v5 1/5] perf/x86/intel: Fix the comment about guest LBR support on KVM Like Xu
2021-03-26  1:19 ` [PATCH v5 2/5] perf/x86/lbr: Simplify the exposure check for the LBR_INFO registers Like Xu
2021-03-26  1:19 ` [PATCH v5 3/5] perf/x86: Skip checking MSR for MSR 0x000 Like Xu
2021-03-26  1:19 ` [PATCH v5 4/5] perf/x86/lbr: Move cpuc->lbr_xsave allocation out of sleeping region Like Xu
2021-03-26  1:19 ` [PATCH v5 5/5] perf/x86: Move ARCH_LBR_CTL_MASK definition to include/asm/msr-index.h Like Xu
2021-04-06  3:20 ` [PATCH v5 0/5] perf/x86: Some minor changes to support guest Arch LBR Like Xu
2021-04-09  8:51   ` Like Xu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3106c3f9-45c7-d286-5a56-8c6eda8990f2@linux.intel.com \
    --to=like.xu@linux.intel.com \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=jolsa@redhat.com \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=peterz@infradead.org \
    --cc=wei.w.wang@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®