From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B8A0EB64DC for ; Mon, 26 Jun 2023 20:46:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230232AbjFZUqI (ORCPT ); Mon, 26 Jun 2023 16:46:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229495AbjFZUqF (ORCPT ); Mon, 26 Jun 2023 16:46:05 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A766D26BA for ; Mon, 26 Jun 2023 13:44:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687812281; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Jg84V4EUJQpXdxqWzxivCvOZP0F5oMgT+7AkEanWAjY=; b=Cpf6OWKtYIIsMAq+YthMzi0KeMDv4G97m9HMMo2zHP0m/LJlwaONp1t7MX9xOKu09pexpW sM5ND6xxWVZS4awpDs2sh1Gpl46c7YwxmKjIPqtQndXKV4wQfJbaj6sVfrG7EbokEpCepX tOg7epQEit63RlP9QdA9eVYwLAJzupw= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-421-7YCo_sUtM-2ljXNnHnLNqA-1; Mon, 26 Jun 2023 16:44:37 -0400 X-MC-Unique: 7YCo_sUtM-2ljXNnHnLNqA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D44F6280D5BC; Mon, 26 Jun 2023 20:44:17 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 71C6340C206F; Mon, 26 Jun 2023 20:44:16 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <3101881.1687801973@warthog.procyon.org.uk> To: Ilya Dryomov Cc: dhowells@redhat.com, netdev@vger.kernel.org, Xiubo Li , Jeff Layton , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jens Axboe , Matthew Wilcox , ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] libceph: Partially revert changes to support MSG_SPLICE_PAGES MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3109247.1687812255.1@warthog.procyon.org.uk> Date: Mon, 26 Jun 2023 21:44:15 +0100 Message-ID: <3109248.1687812255@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ilya Dryomov wrote: > if (sendpage_ok(bv.bv_page)) > msg.msg_flags |= MSG_SPLICE_PAGES; > else > msg.msg_flags &= ~MSG_SPLICE_PAGES; Hmmm... I'm not sure there's any guarantee that msg, including msg_flags, won't get altered by ->sendmsg(). David