From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752922AbcERKKa (ORCPT ); Wed, 18 May 2016 06:10:30 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:56165 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751767AbcERKK2 (ORCPT ); Wed, 18 May 2016 06:10:28 -0400 From: Arnd Bergmann To: Stefano Stabellini Cc: Boris Ostrovsky , David Vrabel , Juergen Gross , Stefano Stabellini , Ian Campbell , Shannon Zhao , Konrad Rzeszutek Wilk , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Xen: don't warn about 2-byte wchar_t in efi Date: Wed, 18 May 2016 12:08:58 +0200 Message-ID: <3110664.iUc8PxbkSO@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: <1462970928-532144-1-git-send-email-arnd@arndb.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:MIitibKIwLyIsYQWv0v0/W9FLFajyg31Q3Ncm7Pmp0NQJFYcduk c7b7yl50rl9pzXSd01eQ463sGS2R/WPkyCnpLJEqNzjtKm+0xfu43YXOWWzXNmD77NnpsUs KxiOmvx33wTc18R1wee4DexR6q+AVJ5slhmaTWpz0kZgkvFN4tkyNDi5YNYhIJutH/7el2U wKxB+wU91SmT8SsqFjdxg== X-UI-Out-Filterresults: notjunk:1;V01:K0:AlY/YdggVdQ=:ePJBY8dvnRYugbPJYmB7mt 8kkgvNfFdUfxYkBgvzjgrkO6n2Pjbj1d2zeER4SVZ5e/SYk32i7azGEMBXq+fWspUTTBRsKQW G0CRJIB74K0x3MudZVXvMTpIACbWXDSMoIcrun9HFLlM2OJw96FjwE5kKxEvpQAJ7JraS3hbH dlNu5WZNJenZ6ixl0zFL16iQGf7jq01Nvbs68OfAuCt5GOcuuBO5EGOgWKpIb0v/9s7rkpUkA uC2dRIg3i/guNyUbmGe2x4psq5uBxGRhaJaP37G0/v/40VzY2+pmSR3bRunObmftGydo7N4Wz Kwm2SdboUtLWGo41tl7caKJlWm76ucy7AMVO8kBuIv5juZ/KpkbLs/dZKHaAcEjFJ8m3w8yx6 PYQXCEwite/qxEgxR+8PvdqqJAffFajSJVtv76m9CnkAZanjyn7ZDvdpXmUQyxb16BI5XRJlQ bUTZ/BBBET07lu6r/sH3ix5uPWepGrl8Zk6dyfCdjjNkQiL4i8sRcmDHIVb9ITu0o5UFUvRmo jDL3U7RNSfq37UVx90c1Wuo4iIeN5f2u9kI+ZzAxj3yL8N+rLtD9t4HytG0krgfq5nrZoFB2S li9/8RzEiUjL2o6MlhuoEoI8l/K0Oz1vZvMakdJfJCec7n47HgXbAXbiBy5IeYpt6X7VQhgSJ f0nYM7DdR355BaFHERuiut5ATjl6PqfcvcEpFHXcl1c0eJ0GTBpgpno5Ut/aDq7CFsw3s3JmO 95HGEWrTvB28XHmj Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 16 May 2016 12:08:17 Stefano Stabellini wrote: > On Wed, 11 May 2016, Arnd Bergmann wrote: > > The XEN UEFI code has become available on the ARM architecture > > recently, but now causes a link-time warning: > > > > ld: warning: drivers/xen/efi.o uses 2-byte wchar_t yet the output is to use 4-byte wchar_t; use of wchar_t values across objects may fail > > > > This seems harmless, because the efi code only uses 2-byte > > characters when interacting with EFI, so we don't pass on those > > strings to elsewhere in the system, and we just need to > > silence the warning. > > > > It is not clear to me whether we actually need to build the file > > with the -fshort-wchar flag, but if we do, then we should also > > pass --no-wchar-size-warning to the linker, to avoid the warning. > > > > Signed-off-by: Arnd Bergmann > > Fixes: 37060935dc04 ("ARM64: XEN: Add a function to initialize Xen specific UEFI runtime services") > > Given that drivers/xen/efi.c doesn't actually use any wchar_t, it is not > clear to me whether we need to pass -fshort-wchar either. However this > patch is correct any, so I committed it to xentip. Right, I was wondering about that too, but it has been this way since the code was first merged, so I couldn't figure out if removing the flag had any side-effects. Arnd