From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757824AbbEEVkZ (ORCPT ); Tue, 5 May 2015 17:40:25 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:58678 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753507AbbEEVkW (ORCPT ); Tue, 5 May 2015 17:40:22 -0400 From: Arnd Bergmann To: Sandy Sun Cc: akpm@linux-foundation.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ipc/sem: 64bit union semun definition Date: Tue, 05 May 2015 23:40:17 +0200 Message-ID: <3111248.ei0HoJaVIp@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: <1430850523-7522-1-git-send-email-a22017@motorola.com> <2165666.hrkl3t0kHm@wuerfel> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:aqO3FS5p6ESupywBYm1aTcJgZ1cjl4b4dQN0/sVS0/Ji8AC0h0o VX01A8cooSn14TsElx7IZur2Akx/yLstKzzKbOtg4zvdwEFq5DNyZ+3k3I78P7RxNx2Fnmb MXUpxvbMua2wvmN9zGjgmPqQG/17mQhiusFkp/q/DQYB5ukW2k0wroB32ikXQw4WYGFCd0M jQgEpMGy1HkvT6p/ljmTQ== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 05 May 2015 14:09:14 Sandy Sun wrote: > Hi Arnd, > > If user space uses union semun to define.It will use semid_ds not > semid64_ds. > > I used LTP test case semctl01 IPC_STAT to do the test on 64 bit > system.According to the test results: > > Before the change, semun uses semid_ds, the field of sem_nsems reporting of > semaphore STAT info is incorrect: > > semctl01 1 TFAIL : semaphore STAT info is incorrect > semctl01 2 TFAIL : semaphore mode info is incorrect > > After this change, the return value is correct: > semctl01 1 TPASS : buf.sem_nsems and buf.sem_perm.mode are correct > semctl01 2 TPASS : buf.sem_perm.mode is correct I don't understand: semctl01 does not reference 'union semun64'. How does this change make a difference, and why would that difference be limited to 64-bit systems? Arnd