From: "Christian König" <christian.koenig@amd.com>
To: Andrew Davis <afd@ti.com>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm: Move radeon and amdgpu Kconfig options into their directories
Date: Tue, 23 Aug 2022 07:59:40 +0200 [thread overview]
Message-ID: <3112082f-9950-d6d2-34b8-0cf2a044f28b@amd.com> (raw)
In-Reply-To: <20220823000111.9765-1-afd@ti.com>
Am 23.08.22 um 02:01 schrieb Andrew Davis:
> Most Kconfig options to enable a driver are in the Kconfig file
> inside the relevant directory, move these two to the same.
>
> Signed-off-by: Andrew Davis <afd@ti.com>
With the tab vs. spaces pointed out by Randy fixed the patch is
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/Kconfig | 42 ------------------------------
> drivers/gpu/drm/amd/amdgpu/Kconfig | 22 ++++++++++++++++
> drivers/gpu/drm/radeon/Kconfig | 22 ++++++++++++++++
> 3 files changed, 44 insertions(+), 42 deletions(-)
>
> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
> index 6c2256e8474b..24fa9ccd92a4 100644
> --- a/drivers/gpu/drm/Kconfig
> +++ b/drivers/gpu/drm/Kconfig
> @@ -234,50 +234,8 @@ source "drivers/gpu/drm/i2c/Kconfig"
>
> source "drivers/gpu/drm/arm/Kconfig"
>
> -config DRM_RADEON
> - tristate "ATI Radeon"
> - depends on DRM && PCI && MMU
> - depends on AGP || !AGP
> - select FW_LOADER
> - select DRM_DISPLAY_DP_HELPER
> - select DRM_DISPLAY_HELPER
> - select DRM_KMS_HELPER
> - select DRM_TTM
> - select DRM_TTM_HELPER
> - select POWER_SUPPLY
> - select HWMON
> - select BACKLIGHT_CLASS_DEVICE
> - select INTERVAL_TREE
> - help
> - Choose this option if you have an ATI Radeon graphics card. There
> - are both PCI and AGP versions. You don't need to choose this to
> - run the Radeon in plain VGA mode.
> -
> - If M is selected, the module will be called radeon.
> -
> source "drivers/gpu/drm/radeon/Kconfig"
>
> -config DRM_AMDGPU
> - tristate "AMD GPU"
> - depends on DRM && PCI && MMU
> - select FW_LOADER
> - select DRM_DISPLAY_DP_HELPER
> - select DRM_DISPLAY_HDMI_HELPER
> - select DRM_DISPLAY_HELPER
> - select DRM_KMS_HELPER
> - select DRM_SCHED
> - select DRM_TTM
> - select DRM_TTM_HELPER
> - select POWER_SUPPLY
> - select HWMON
> - select BACKLIGHT_CLASS_DEVICE
> - select INTERVAL_TREE
> - select DRM_BUDDY
> - help
> - Choose this option if you have a recent AMD Radeon graphics card.
> -
> - If M is selected, the module will be called amdgpu.
> -
> source "drivers/gpu/drm/amd/amdgpu/Kconfig"
>
> source "drivers/gpu/drm/nouveau/Kconfig"
> diff --git a/drivers/gpu/drm/amd/amdgpu/Kconfig b/drivers/gpu/drm/amd/amdgpu/Kconfig
> index 7777d55275de..36b1206124cf 100644
> --- a/drivers/gpu/drm/amd/amdgpu/Kconfig
> +++ b/drivers/gpu/drm/amd/amdgpu/Kconfig
> @@ -1,4 +1,26 @@
> # SPDX-License-Identifier: MIT
> +
> +config DRM_AMDGPU
> + tristate "AMD GPU"
> + depends on DRM && PCI && MMU
> + select FW_LOADER
> + select DRM_DISPLAY_DP_HELPER
> + select DRM_DISPLAY_HDMI_HELPER
> + select DRM_DISPLAY_HELPER
> + select DRM_KMS_HELPER
> + select DRM_SCHED
> + select DRM_TTM
> + select DRM_TTM_HELPER
> + select POWER_SUPPLY
> + select HWMON
> + select BACKLIGHT_CLASS_DEVICE
> + select INTERVAL_TREE
> + select DRM_BUDDY
> + help
> + Choose this option if you have a recent AMD Radeon graphics card.
> +
> + If M is selected, the module will be called amdgpu.
> +
> config DRM_AMDGPU_SI
> bool "Enable amdgpu support for SI parts"
> depends on DRM_AMDGPU
> diff --git a/drivers/gpu/drm/radeon/Kconfig b/drivers/gpu/drm/radeon/Kconfig
> index 52819e7f1fca..3248d12c562d 100644
> --- a/drivers/gpu/drm/radeon/Kconfig
> +++ b/drivers/gpu/drm/radeon/Kconfig
> @@ -1,4 +1,26 @@
> # SPDX-License-Identifier: MIT
> +
> +config DRM_RADEON
> + tristate "ATI Radeon"
> + depends on DRM && PCI && MMU
> + depends on AGP || !AGP
> + select FW_LOADER
> + select DRM_DISPLAY_DP_HELPER
> + select DRM_DISPLAY_HELPER
> + select DRM_KMS_HELPER
> + select DRM_TTM
> + select DRM_TTM_HELPER
> + select POWER_SUPPLY
> + select HWMON
> + select BACKLIGHT_CLASS_DEVICE
> + select INTERVAL_TREE
> + help
> + Choose this option if you have an ATI Radeon graphics card. There
> + are both PCI and AGP versions. You don't need to choose this to
> + run the Radeon in plain VGA mode.
> +
> + If M is selected, the module will be called radeon.
> +
> config DRM_RADEON_USERPTR
> bool "Always enable userptr support"
> depends on DRM_RADEON
next prev parent reply other threads:[~2022-08-23 5:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 0:01 Andrew Davis
2022-08-23 0:06 ` Randy Dunlap
2022-08-23 0:15 ` Andrew Davis
2022-08-23 5:59 ` Christian König [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-10-16 18:52 Andrew F. Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3112082f-9950-d6d2-34b8-0cf2a044f28b@amd.com \
--to=christian.koenig@amd.com \
--cc=afd@ti.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome