From: Milian Wolff <milian.wolff@kdab.com>
To: "Steinar H. Gunderson" <sgunderson@bigfoot.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Jiri Olsa <jolsa@kernel.org>
Subject: Re: Inlined functions in perf report
Date: Tue, 20 Dec 2016 15:03:40 +0100 [thread overview]
Message-ID: <3116188.fHYjqyENF0@milian-kdab2> (raw)
In-Reply-To: <20161220134341.GA4183@sesse.net>
[-- Attachment #1: Type: text/plain, Size: 1406 bytes --]
On Tuesday, December 20, 2016 2:43:41 PM CET Steinar H. Gunderson wrote:
> On Tue, Dec 20, 2016 at 02:27:10PM +0100, Milian Wolff wrote:
> > It is not even possible with that, perf report is lacking the steps
> > required to add inline frames - it will only add "real" frames it gets
> > from either of the unwind libraries.
> >
> > I have a WIP patch available for this functionality though, it can be
> > found
> > here (depends on libbfd, i.e. bfd_find_inliner_info):
> >
> > https://github.com/milianw/linux/commit/
> > 71d031c9d679bfb4a4044226e8903dd80ea601b3
>
> Thanks, I'll be sure to try it out. I assume this works only with -g dwarf?
> I.e., for non-graph runs, I will still get the bottom function only, not the
> inlined one.
There is no -g dwarf to my knowldge. There is only `perf record -g`, which is
the framepointer based unwinding and that should also work. But I only really
tested this WIP branch with `--call-graph dwarf` so far.
I'm not so sure whether I understand your sentence about "non-graph runs". It
has nothing to do with `perf report -g graph` (yes, perf is confusing!).
You'll have to:
perf record [-g | --call-graph lbr | --call-graph dwarf ] (pick one)
perf report -g srcline (and anything else)
Cheers
--
Milian Wolff | milian.wolff@kdab.com | Software Engineer
KDAB (Deutschland) GmbH&Co KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts
[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5903 bytes --]
next prev parent reply other threads:[~2016-12-20 14:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-20 11:59 Steinar H. Gunderson
2016-12-20 12:17 ` Peter Zijlstra
2016-12-20 13:27 ` Milian Wolff
2016-12-20 13:43 ` Steinar H. Gunderson
2016-12-20 14:03 ` Milian Wolff [this message]
2016-12-20 13:54 ` Arnaldo Carvalho de Melo
2016-12-20 14:05 ` Milian Wolff
2016-12-20 14:08 ` Steinar H. Gunderson
2016-12-20 14:37 ` Arnaldo Carvalho de Melo
2016-12-20 17:01 ` Steinar H. Gunderson
2016-12-21 0:53 ` Jin, Yao
2016-12-21 9:58 ` Steinar H. Gunderson
2016-12-21 10:09 ` Milian Wolff
2016-12-21 10:20 ` Steinar H. Gunderson
2016-12-21 22:56 ` Jin, Yao
2016-12-21 22:58 ` Steinar H. Gunderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3116188.fHYjqyENF0@milian-kdab2 \
--to=milian.wolff@kdab.com \
--cc=acme@kernel.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=sgunderson@bigfoot.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®