From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43E86C6369E for ; Wed, 18 Nov 2020 16:38:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CFB3824835 for ; Wed, 18 Nov 2020 16:38:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="ni/KvVsT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727145AbgKRQig (ORCPT ); Wed, 18 Nov 2020 11:38:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725874AbgKRQif (ORCPT ); Wed, 18 Nov 2020 11:38:35 -0500 Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04050C0613D4; Wed, 18 Nov 2020 08:38:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=kaWjsdpjpN5LXJFbr3apPZfPhM8ZPQRzOwRezmytxfc=; b=ni/KvVsTrsHhVTTp0uXSKdQdPP efSxTQtf/JZCqql1NhPqJavZka9wb99k2Ywx2fwo4ZDZqscHX/MSGVx6Wr8GDlLLNYfMwmgnVimHN zwOWozkN62VhGkvcUK3OREauyrp8JjjUp6FZiqMh3baw7vKAEcRztk0Ov0/13i28qJoXAka5xXj2e zNrA1ZoX/xaugEYwvZ8jvz5BdIZ9z7B1awQWzZpUoJ8bLr3BkQtaAGQw9YcU0ZetHIlIyqjr2oE3D Yo5WxTTX/ywVaiabqlAbGkwygLFqzhFNS4z/K8Ai5XUP8jqOC1sLI79+yGjOk1anso5scLD67WP/U 3q/IJY/Q==; Received: from [2601:1c0:6280:3f0::bcc4] by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfQTY-0005Dn-Uf; Wed, 18 Nov 2020 16:38:33 +0000 Subject: Re: md: dm-writeback: add __noreturn to BUG-ging function To: Christian Borntraeger , Mike Snitzer Cc: linux-kernel@vger.kernel.org, Mikulas Patocka , Alasdair Kergon , dm-devel@redhat.com, Heiko Carstens , Vasily Gorbik , linux-s390@vger.kernel.org References: <20201113225228.20563-1-rdunlap@infradead.org> <344abf76-9405-58ba-2dc4-27cab88c974d@de.ibm.com> <20201117163147.GA27243@redhat.com> <20201118154944.GB545@redhat.com> <20201118160748.GA754@redhat.com> <7ae2b73e-e6e5-3357-11e4-efd93e93ba35@de.ibm.com> From: Randy Dunlap Message-ID: <3116ea60-1dc3-9c15-31ec-5ce8ef72ba1a@infradead.org> Date: Wed, 18 Nov 2020 08:38:27 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <7ae2b73e-e6e5-3357-11e4-efd93e93ba35@de.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/18/20 8:35 AM, Christian Borntraeger wrote: > > > On 18.11.20 17:07, Mike Snitzer wrote: >> On Wed, Nov 18 2020 at 10:49am -0500, >> Mike Snitzer wrote: >> >>> I don't think my suggestion will help.. given it'd still leave >>> persistent_memory_claim() without a return statement. >>> >>> Think it worthwhile to just add a dummy 'return 0;' after the BUG(). >> >> Decided to go with this, now staged for 5.11: >> https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=dm-5.11&id=a1e4865b4dda7071f3707f7e551289ead66e38b1 >> > > Looks like a sane solution. Thank you for following up. Yes, thanks again. -- ~Randy