From: David Howells <dhowells@redhat.com>
To: Yang Li <yang.lee@linux.alibaba.com>
Cc: dhowells@redhat.com, dwmw2@infradead.org,
keyrings@vger.kernel.org, linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] certs: Fix some kernel-doc comments
Date: Thu, 31 Mar 2022 13:56:06 +0100 [thread overview]
Message-ID: <3118064.1648731366@warthog.procyon.org.uk> (raw)
In-Reply-To: <20220317021249.31655-1-yang.lee@linux.alibaba.com>
Yang Li <yang.lee@linux.alibaba.com> wrote:
> /**
> - * Allocate a struct key_restriction for the "builtin and secondary trust"
> - * keyring. Only for use in system_trusted_keyring_init().
> + * get_builtin_and_secondary_restriction - Allocate a struct key_restriction
> + * for the "builtin and secondary trust" keyring. Only for use in
> + * system_trusted_keyring_init().
> */
> static __init struct key_restriction *get_builtin_and_secondary_restriction(void)
Better to just turn the "/**" into "/*" for this one. It's not a function
that should necessarily appear in API docs.
David
next prev parent reply other threads:[~2022-03-31 12:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-17 2:12 Yang Li
2022-03-31 12:56 ` David Howells [this message]
2022-04-02 7:31 Yang Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3118064.1648731366@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=abaci@linux.alibaba.com \
--cc=dwmw2@infradead.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®