From: "André Almeida" <andrealmeid@igalia.com>
To: Sebin Sebastian <mailmesebin00@gmail.com>
Cc: "Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Pan, Xinhui" <Xinhui.Pan@amd.com>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Nirmoy Das" <nirmoy.das@amd.com>,
"Lijo Lazar" <lijo.lazar@amd.com>,
"Evan Quan" <evan.quan@amd.com>,
"Tom St Denis" <tom.stdenis@amd.com>,
"Somalapuram Amaranath" <Amaranath.Somalapuram@amd.com>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 -next] drm/amdgpu: double free error and freeing uninitialized null pointer
Date: Mon, 1 Aug 2022 14:06:41 -0300 [thread overview]
Message-ID: <31187f41-64c8-d7ce-fcf2-5da421b3e194@igalia.com> (raw)
In-Reply-To: <20220730034923.25500-1-mailmesebin00@gmail.com>
Às 00:46 de 30/07/22, Sebin Sebastian escreveu:
> Fix a double free and an uninitialized pointer read error. Both tmp and
> new are pointing at same address and both are freed which leads to
> double free. Adding a check to verify if new and tmp are free in the
> error_free label fixes the double free issue. new is not initialized to
> null which also leads to a free on an uninitialized pointer.
>
> Suggested by: S. Amaranath <Amaranath.Somalapuram@amd.com>
> Signed-off-by: Sebin Sebastian <mailmesebin00@gmail.com>
Reviewed-by: André Almeida <andrealmeid@igalia.com>
next prev parent reply other threads:[~2022-08-01 17:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-30 3:46 Sebin Sebastian
2022-08-01 1:28 ` Quan, Evan
2022-08-01 17:06 ` André Almeida [this message]
2022-08-10 16:41 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31187f41-64c8-d7ce-fcf2-5da421b3e194@igalia.com \
--to=andrealmeid@igalia.com \
--cc=Amaranath.Somalapuram@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=evan.quan@amd.com \
--cc=lijo.lazar@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mailmesebin00@gmail.com \
--cc=nirmoy.das@amd.com \
--cc=tom.stdenis@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®