From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 787883E9C18 for ; Wed, 10 Jun 2026 10:52:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781088772; cv=none; b=KMrm9tWsFpPYOr5yflP6JVQCBWhoNSaBP5N24oBO3GKOEfFt/T4zKEc/lxY2XrMMNcNIgRO9BqhelumF5fLBsqPzzOdYfXa7+pG+/QIKPnZYfUc+BUM8x5UqlLDK3B3Hhge5RBVceE53ZqzeSHba+TocTaKb+S8EOM9A6moDHbo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781088772; c=relaxed/simple; bh=+fVsd1Z1+tIzaGhW+BpuLIuaSGTLG0J27IW8uVttLPI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WYrwBQG2yGCPtxQGt3dsnHomvIOPQaZ+TCuuPDKoCfZZy6mrZGAMC16SGT2gbZelDsGsqMeDkzk8PY4nl0EY8iI+KdBgujjvoI0O4kORYOR5a+x3/7K3mKvPbHfZUZrdoLEQbhZBcUNLdfEs9E36vwEwL73Y/xO9ATholrf1qFg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bz3tNq2I; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PXPAEes6; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bz3tNq2I"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PXPAEes6" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65A8wt8n735625 for ; Wed, 10 Jun 2026 10:52:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= TK96IQjgP90UGFdgjcEfW6TzZ2WJM/XtcB+xnxS45I0=; b=bz3tNq2IMi6oxKBJ /0CcPf1Q6ZILQx56EV7sbjNaWSukT/dHmMCeu62boRm2mbwH2LhwNwhfgbasC1mE iEML19TM0kotrxGdKuylFxjFb2eKb+tfTkvdHLTB4ko07aoUprWS0YgRHFrzNWnm 6YPMN+agwvhG/8tXWCNKwzAydJQaCERCjyP6KwN4r5rkayRhqBF5Yus3zS9YmrHH mUwQ9zu9W+1Qq8J43aziQ5mEET0RuGxY/LQd7SCN8jIt+zeiI+ARHvoJYPsJ+GiT cS9yYJQyyhhobAhLiKfebjqpok1qY7BUgTdMY4yC43CJH+oIu9U81bsdVvWpCQTm tpbJLQ== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eq4w1reh1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 10 Jun 2026 10:52:50 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-915b6b63056so1002360085a.1 for ; Wed, 10 Jun 2026 03:52:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781088770; x=1781693570; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=TK96IQjgP90UGFdgjcEfW6TzZ2WJM/XtcB+xnxS45I0=; b=PXPAEes6FuM9eUswKJLn1lqirl3DoTY5t0o7AdR+XG7T8OjFFe3OK3/ttCiZ3Bl7R9 rME7U3Q4EDzJGkCpZk7B5MhvDGxqNG/tjmluUe3YJ3tKrG7sj6FKgLY1rATbBsO6AsuM nZltocGoymir18wuHZuMwy2wCb/DJGLvVJiHB359tSm3Wop+mPrQmyWhGYZYCQ+8NoCm wl+2sWqj4mrL0uLb0ByX07MDqfYdX6ql4QrSDxhvYaM2YrI/IVK7EWo2K9RBNk5CpfYO IcfNyYykYBWG35a6RcOMcbGs5TB3hgby28XaflC+wkAfqL43kjhQ1v21IuZH4foKO6iM WmPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781088770; x=1781693570; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TK96IQjgP90UGFdgjcEfW6TzZ2WJM/XtcB+xnxS45I0=; b=Nl7rW3J2nhkRwwUc8cYKecG5fJSo5xTwIUqxqXMUvwRv5Y8Ivvwpbk56D95Rti5Alu k8Hq70pfkNSjzdLxnNdda2HIV+sad+w2tsnA1cUhEhiaMW/ILtbFAlpD1kb/NsWZUe2u kvLdWOrMokFh4PJolCEwx83PR5YWAV4u+sdOGV8YvXetv3Xpg7jyViDNahcS0WMImLmR d5nofhpQ0v/BzdVGphNGB4TJisQ+xQ/0QSgCVFkBzypoJJ5o/5cYFjiXBSM+fLrrPY0w apswy2Qjc9oZm41EZiKcZMUGjINjS2nRHyqxc9ub3Scc/7T74e3ABBwT0kDD+qfnWKvp x6YQ== X-Forwarded-Encrypted: i=1; AFNElJ8W0Qm2OI83PaWpKSrk8VFjBVRog1qN4Pp/sFwCZQN7NakKSdewEG4CzDyYQX9rO6BzC2zGTNgXbZfoQZE=@vger.kernel.org X-Gm-Message-State: AOJu0YxaNhbAUAAz/36C6tS6iPYL1u68htLRWUJCr8Mi9sOMgNAy5l8U lMON5PUPzDY9mULblhfaTgpulaxdIjnrnA91oJnDHXtXy4b1R6PNHggXC/anAPQIOFvXk2jCYht d5oSFlxOYwT4RocnbYR3J86MyuwSMg8wQ1PbZ07Jo9NIFEO7Egps7kLxa97Ep4KLsCdA= X-Gm-Gg: Acq92OHP/gp8KqABp8dOVjynGDizqRF+RbQTXfJ7qNp1URO1YK9LeWzuE/l6TzPF1Bg BRR06OVUjWaKUhaoW4GpE/Rx8Le2dq0RF/wu/bsM+hAS64brcINJ/T97z6eZG6WGIFHc1zKCFNk qUPof/yE3TATQe5tJ9HVaC/vbjLZM8vC8OQ+Iyv9aHCsGsJzYSrCJi7tJwWZ4SOU/b0NX/EKS+V k5HGtVEJYBDDcfRcR4E3Gxw2/1bRVhK21bEQdZb3gcHfRcxnp3Mc1ikk74V8MSbZSazWpC5144x TkmmkF32qkTmvlje/UOP6IMZcL0g7pAMO2SIrjt6avd2RP/zPxISH0Kea9/sAqyN3BVEWKNJfjP iLqF5XPcBolhsJPZlbt93tWiAlfZH70HME2jJc+ca2KO2n7ilVk7T1Rd8O/E= X-Received: by 2002:a05:622a:53c7:b0:510:1325:58b9 with SMTP id d75a77b69052e-51795c56255mr369073591cf.41.1781088769691; Wed, 10 Jun 2026 03:52:49 -0700 (PDT) X-Received: by 2002:a05:622a:53c7:b0:510:1325:58b9 with SMTP id d75a77b69052e-51795c56255mr369073261cf.41.1781088769303; Wed, 10 Jun 2026 03:52:49 -0700 (PDT) Received: from [192.168.68.125] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id a640c23a62f3a-bf055309368sm1154147866b.49.2026.06.10.03.52.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Jun 2026 03:52:48 -0700 (PDT) Message-ID: <311ceabf-23ff-471b-9553-797c7d76af74@oss.qualcomm.com> Date: Wed, 10 Jun 2026 11:52:47 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ASoC: codecs: lpass-va-macro: Fix LPASS Codec Version for SC7280 To: Luca Weiss , Srinivas Kandagatla , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Dmitry Baryshkov Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260526-sc7280-va-macro-2-0-v1-1-2c1b572fa388@fairphone.com> Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: <20260526-sc7280-va-macro-2-0-v1-1-2c1b572fa388@fairphone.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: K1TyxkKfSDqj58YC87NDkh5TJ5R4NuvA X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjEwMDEwMyBTYWx0ZWRfX+xLH6lBZinxL /0byzCf/e9HpllG5egbN6LUqZvtxYOLq21cPJE1P4GF9OCkP/cOyISlrVmXFYbQUT2uqT7AD6a9 njjsvExEDPo7zpw3vabg2yJqAfwwLzkVUvAl4b7dRIG9XYPwbKzkZJMmmp/r/Fboh9i6HJazidi tREE0jHFWoQk8ob3VhwEpcXCPRJX7eXlYg2r2SCPIvFGaqAdZFUGlktUMA0YjttjhEH1AYTNKBk O9aE8AfSJREO5RYm5OyfHLMQGgy0aFtZ6Y5+rNNIgg/aXeJkraJLCPgAYW+NJ1tKBCdcUNuMV+K zcyz6NatqLbv/ucUo+i8cQZgspfQ5eCjBTWorYNMBj2WmLbmgXMei4UmqNmrReR4bQtfuWAdv+5 mzywAl7jyrYSjape/4Tb5xs0If8FGm5hW1NKnIijrsjswnOj1efVo8LxgV8CE28Rh27IVp/ZBLh EvpUQ7a1pgrIVJx7lLw== X-Proofpoint-GUID: K1TyxkKfSDqj58YC87NDkh5TJ5R4NuvA X-Authority-Analysis: v=2.4 cv=ZfEt8MVA c=1 sm=1 tr=0 ts=6a294202 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=6H0WHjuAAAAA:8 a=EUspDBNiAAAA:8 a=Vj5VumI9SRvEE-TA0EoA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 a=Soq9LBFxuPC4vsCAQt-j:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-10_02,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 clxscore=1015 spamscore=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 impostorscore=0 suspectscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606100103 Thanks Luca for the patch, On 5/26/26 4:03 PM, Luca Weiss wrote: > According to both the static definition in downstream... > > yupik-audio-overlay.dtsi: qcom,bolero-version = <4>; > #define BOLERO_VERSION_2_0 0x0004) > > and the runtime detection: > > CDC_VA_TOP_CSR_CORE_ID_0=0x1 > CDC_VA_TOP_CSR_CORE_ID_1=0xf > > SC7280 has LPASS Codec Version 2.0 and not, as declared with > sm8250_va_data LPASS_CODEC_VERSION_1_0. > > Create new va_macro_data with .version not set to use the runtime > detection and correctly get .version = LPASS_CODEC_VERSION_2_0. > > Fixes: 77212f300bfd ("ASoC: codecs: lpass-va-macro: set the default codec version for sm8250") Can you help me understand if this change was fixing any issue, if so can you pl add CC stable > Signed-off-by: Luca Weiss > --- > I'm fairly confident this is correct, but please someone double check > this if they can. Yes, you are correct, this is actually Bolero 1.1.0 Version where things have changed in codec. if you read major number it will be 1 This has been artificially tagged as 2.0 in the driver. So the change that you are doing is correct. Reviewed-by: Srinivas Kandagatla --srini > --- > sound/soc/codecs/lpass-va-macro.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/sound/soc/codecs/lpass-va-macro.c b/sound/soc/codecs/lpass-va-macro.c > index 528d5b167ecf..58a5798823d7 100644 > --- a/sound/soc/codecs/lpass-va-macro.c > +++ b/sound/soc/codecs/lpass-va-macro.c > @@ -244,6 +244,11 @@ static const struct va_macro_data sm8250_va_data = { > .version = LPASS_CODEC_VERSION_1_0, > }; > > +static const struct va_macro_data sc7280_va_data = { > + .has_swr_master = false, > + .has_npl_clk = false, > +}; > + > static const struct va_macro_data sm8450_va_data = { > .has_swr_master = true, > .has_npl_clk = true, > @@ -1755,7 +1760,7 @@ static const struct dev_pm_ops va_macro_pm_ops = { > }; > > static const struct of_device_id va_macro_dt_match[] = { > - { .compatible = "qcom,sc7280-lpass-va-macro", .data = &sm8250_va_data }, > + { .compatible = "qcom,sc7280-lpass-va-macro", .data = &sc7280_va_data }, > { .compatible = "qcom,sm6115-lpass-va-macro", .data = &sm8450_va_data }, > { .compatible = "qcom,sm8250-lpass-va-macro", .data = &sm8250_va_data }, > { .compatible = "qcom,sm8450-lpass-va-macro", .data = &sm8450_va_data }, > > --- > base-commit: 550604d6c9b9efc8d068aff94dc301694a7afdee > change-id: 20260526-sc7280-va-macro-2-0-f0d4591a611b > > Best regards, > -- > Luca Weiss >