From: "Ard Biesheuvel" <ardb@kernel.org>
To: "Kees Cook" <kees@kernel.org>
Cc: "Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
"Nathan Chancellor" <nathan@kernel.org>,
"Nicolas Schier" <nsc@kernel.org>,
"Nick Desaulniers" <ndesaulniers@google.com>,
"Bill Wendling" <morbo@google.com>,
"Justin Stitt" <justinstitt@google.com>,
linux-efi@vger.kernel.org, llvm@lists.linux.dev,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH v1 0/3] efi/libstub: Build the x86 stub from KBUILD_CFLAGS
Date: Thu, 08 Oct 2026 16:43:11 +0200 [thread overview]
Message-ID: <31318d3b-1738-49d2-8017-d4ebf98aa22f@app.fastmail.com> (raw)
In-Reply-To: <20261006204210.i.137-kees@kernel.org>
On Tue, 6 Oct 2026, at 22:42, Kees Cook wrote:
> Hi!
>
> The x86 EFI stub builds from its own short list of compiler flags instead
> of KBUILD_CFLAGS, so options added kernel-wide reach it only when someone
> remembers to add them there too (e.g. for -fms-extensions). Swap it
> around to remove unwanted options instead, as we do for all the other
> architectures.
>
> This will let Clang's -fexperimental-late-parse-attributes reach the
> stub build so that __counted_by() will get parsed without error[1].
>
> Thanks!
>
> -Kees
>
> Link: https://lore.kernel.org/all/202610060642.7C4125F@keescook [1]
>
> Kees Cook (3):
> efi/libstub: Declare the x86 stub's assembly entry points
> efi/libstub: Build the x86 stub from KBUILD_CFLAGS
> efi/libstub: Disable kernel stack erasing in the common flags
>
Thanks. I've queued this up but with a tweak applied to patch #1,
as it broke the GCC i386 build due to the fact that 'asmlinkage'
evaluates to __attribute__((regparm(0))), and apparently, GCC
still thinks that differs from a function without the attribute,
even when it is the default. (Clang built fine)
prev parent reply other threads:[~2026-10-08 14:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-06 20:42 Kees Cook
2026-10-06 20:42 ` [PATCH v1 1/3] efi/libstub: Declare the x86 stub's assembly entry points Kees Cook
2026-10-06 20:42 ` [PATCH v1 2/3] efi/libstub: Build the x86 stub from KBUILD_CFLAGS Kees Cook
2026-10-07 9:20 ` Nathan Chancellor
2026-10-06 20:42 ` [PATCH v1 3/3] efi/libstub: Disable kernel stack erasing in the common flags Kees Cook
2026-10-07 9:21 ` Nathan Chancellor
2026-10-08 14:43 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31318d3b-1738-49d2-8017-d4ebf98aa22f@app.fastmail.com \
--to=ardb@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=justinstitt@google.com \
--cc=kees@kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=nsc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®