From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E674023C39A for ; Wed, 22 Apr 2026 16:28:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776875323; cv=none; b=JckY8speBryLnzpNOgwTyJ/PdcvqZsuDzXuZx8C8YAZZm9/nxyYa7J0RRtYz1fPwtWQEjkVoQvHaeKT2bp+5zz8yEAUTfs/yV2jSJDB+GUBNGre0i5XVc032dYljt00SrsxZwwS4kCav8uvjagUGGsDwaTrlZbQB7g4zG3Za1G8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776875323; c=relaxed/simple; bh=DSdp1oOOP0f/99CCoNjEV4ACcAUGkj5A3V4vdetbQno=; h=Date:From:To:CC:Subject:In-Reply-To:References:Message-ID: MIME-Version:Content-Type; b=iWagm2rWYzmJ8Zfmq88+UD2okmS0GYBGLWsg0X6DIrTH5AL9GlxxgDBpR5zf8gw2GlHIKPuAUHwgSqU4JiT/NFWtP6Hnkb+/aHg2b/w7pbHV3N/mYmQm9oGa26KW0UJvBVqfjCRWurGH7mf8JaAQKODXqsYK+HF4UlbDmxHSeKg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Z7J+edW0; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z7J+edW0" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-488b3f8fa2bso59777965e9.1 for ; Wed, 22 Apr 2026 09:28:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776875320; x=1777480120; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=HDGgfaqhTTh7V4D9W5G/d86lJdbnAvnjw/1hlwsVKF4=; b=Z7J+edW0iELxCDXLd3KHbOjM5iDujNa/NTnYvep8TldpwhkXxTPagNBdsEPIIH7lF9 467BtB5MALQcV8ELGjo7im+EsOXcSy727f12cESHNUb027eOwVmLJN0omxwtAkSrhytn d/4M5a5M7xPKPu6rPliqH2RDL6itFrxoP6aDLagf9uJ7z4nlxbhvNuEHg+0bOBAOh+dH vlc/1f6gWNE6qPLp4WfRIalkMXjGRRcRId4UA0L5eP6t9xhk8JoRKEK5ncqy10+oqES/ Fm6v3ocmXC5KsY1fNdMJQi9j9URYdFFINYPRECw4YMPM0T0I3TKcceKVF6S2kS8CAd7U icUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776875320; x=1777480120; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HDGgfaqhTTh7V4D9W5G/d86lJdbnAvnjw/1hlwsVKF4=; b=ID7EMgBZoso7xvGlPensJZwakOmhfxFubDl7/IFGBIuW6l1mBRetw8gcbqwUbuqzjv e0h4b8lVQ6lLKx5QPPT73kov8RGeirBmW3arqB2GBoeJ3YcrI2inHmNWg0vXcbnIUxlG lUtKlw2yAGqhlxVbd/xrMtyGQJImbKAvRjH/dP/grQ0v/hpqE9uIP5qP1VmFkUSyUFoC UVoHwCamSwWFQq8TLDlstCH7+Wx4j8VT5ZoLNysIL5ljqqduvXXhV2lp9Tp41+Rq1xrH ORRiaRkYU5N+qOE17lIMWFkZDyEcH+dpGsQb3TpTSIzKNMopNlCHA3d3ND+yPmyMrCR1 PJLw== X-Forwarded-Encrypted: i=1; AFNElJ+Y39fJF3hFsOKvrrdck1Y+NAJFGiL4gQ4edq6jiGxsLUmYgYM1ECNN+L76Dq5asZBbqnF1MY54Or1xWm4=@vger.kernel.org X-Gm-Message-State: AOJu0YxYHZpCrgEbtAvo8UIOY7xn9CFq4R3A17CCuvpIqvBtUvwbnkvJ i3l8GIuY9KEmIXwV8R9hHqv/dYLmTmPhF1nNlpHA0qSu446qcab+Dxzz X-Gm-Gg: AeBDieuBw/mEVcN27EK2Izwk92c71In2S8qrvRqaOA+JrPCZMfviKfgnnbG9csQZHpl igy36mfbyUOD0IQ9ziyqMLvhw3KY/cOJtrl2wN0N1wcXUldUhb21TdKMHSiqqVMYyeUS1wytlJT 7cdEagMkno0O/zFBwxZEgMnKMyNCaLZpTOFErvVr60BN3CwHJQHJE+carPHJ3fa2r/w+acUKrNJ XTpixC/VWBD4PejKGkWRyBk8w/3wA1E7agcddRgqmCsaA4P5mqmYjTZqq2eNbbO9X2Iox427MWv qNpfrPzhebPIcizzyAebbYWtu/4kpn7vZWIciTg1wZNPFHUrZeGzglkopw8QAZhcYcMLTzP7fna kBpDhAr55RLu+hV+nuKueWpHVekWLLX0kNuGq+oFN8RqOmDaKPdqvEDlYWwjCxUS3ZhuOsuzY2f HYopSq16PbgCiSNQ2lMDcqlfy5sdusDBtlqhQJ X-Received: by 2002:a05:600c:c112:b0:486:fe83:861c with SMTP id 5b1f17b1804b1-488fb896910mr267679685e9.7.1776875320083; Wed, 22 Apr 2026 09:28:40 -0700 (PDT) Received: from ehlo.thunderbird.net ([86.1.69.5]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4891df9e50asm201988925e9.0.2026.04.22.09.28.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Apr 2026 09:28:39 -0700 (PDT) Date: Wed, 22 Apr 2026 17:28:39 +0100 From: Josh Law To: Andy Shevchenko CC: akpm@linux-foundation.org, kees@kernel.org, James.Bottomley@hansenpartnership.com, linux-kernel@vger.kernel.org, andy.shevchenko@gmail.com Subject: Re: [RFC] [QUESTION] Stuff to do for string In-Reply-To: References: Message-ID: <313CDBE8-2AE7-4104-9DE0-C119A843A0F4@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit On 22 April 2026 17:12:37 BST, Andy Shevchenko wrote: >On Wed, Apr 22, 2026 at 03:57:16PM +0100, Josh Law wrote: >> Hello, (this is my first RFC, so maybe cc is bad, but yeah) >> >> What do you guys have planned/would like me to have a look at doing in >> lib/string.c >> >> I am home from school so I am virtually free > >Arbitrary things that came to my mind (no particular order) > >- Get rid of strlcat() Yeah, I'm working on that actually :D, privately, I sorta stopped cuz i thought kees was gonna do that, if not, not issue! >- Clean up include/linux/string.h > a) drop extern for functions > b) put the headers it includes into an order and follow IWYU Hmm, yeah, I see it's kind of a mess (in a polite way) >- kill memscan() in favour of memchr() / memchr_inv() Hmm, maybe, is there a crazy amount of files that call memscan()? I'll also (try ;), yk, school :( ) to review patches for your file. Ig it's the best I do for you lot right now, (I am starting to review most if not all patches in lib), e.g: https://lore.kernel.org/all/AA9B2A7E-A88D-457C-8244-50087631B347@gmail.com :) Thanks!