From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 794EEC433EF for ; Thu, 5 May 2022 08:47:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350353AbiEEIuk (ORCPT ); Thu, 5 May 2022 04:50:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235438AbiEEIuh (ORCPT ); Thu, 5 May 2022 04:50:37 -0400 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02F3D49F35 for ; Thu, 5 May 2022 01:46:59 -0700 (PDT) Received: by mail-wr1-x433.google.com with SMTP id i5so5115969wrc.13 for ; Thu, 05 May 2022 01:46:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=KAi9SgYYEJZdQCddUzbx52lypx3cIglFyl/qHafebhw=; b=tkNfdzaaxw1oNzzHEFi5PsCP9pSRB2g18WUgVkc6DnnNJz4opSwgzEVFoUUkq98Kud DmFNXaVYExw1NuJr8DqujznLa2az0lWDiTc0qWvNUCAP5r5OW9iSR8QEqSlWZJONTS4P F30VkUEk9v9uHoJqLqcvFr87lcceheNYz87udcrXOAHtFnIyEOvlcZaxaIZkOdNhT30Y dB4ud6EWIxegH+EYbtLr/2s0zJ21Uw2TaCRSfxNT1dPyuAPqkA2Ti2WZXu8bcR/8mxNC eMgh7vO/iGZwuEnOROZ+GPB0E6E/imyXgauO3i4m/vz/qEwWxwP3ttMVK1mz2Ist0shg sbpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=KAi9SgYYEJZdQCddUzbx52lypx3cIglFyl/qHafebhw=; b=aV6mdcw+/rBxSXL815qPXnUMra4mY37Qg1/aVJt8GIkJFpDv+hvca1hqONe5e5sV01 JjVbQIlItWJf05zlGWYsa/5k3wE0YXfowFKZEsuS/ZSLIYPNGiPTfIXhwHRYWy57k8wP PB3jE3IrN1KS9NDvNpyQ/mZ4AWBX1YmP5iZKLGdDgkMhxG5yZmoCUReLC09IKIvLQHUz 4cx3oTolMjC0zzfTtfCmrwDymKRUWZE4GPIA4CVSB+oBIAloTr769TypKK3LV6L6OIMF XKirYkFExsql/R1pdIMH4R7Ii5eT7L/++EtFxbUY0LdSzsZFU9IkEJ8SIK1nAsCBUmF5 6ZSw== X-Gm-Message-State: AOAM530iKD2ggYtBDiOPESOtIWU6ljXGBKRX33twv7yvtI5WaYF0yIBV U2oblTVbTmdvw02NnAsU9uqszQ== X-Google-Smtp-Source: ABdhPJx0cG82J35HyxF+U/lAjaHUyieUfdukDsGukXiyDflYgKWosvfKkWmN+5Kvijh4a8XoYMPHpw== X-Received: by 2002:a5d:6551:0:b0:20a:e23c:a7fa with SMTP id z17-20020a5d6551000000b0020ae23ca7famr19657153wrv.535.1651740417622; Thu, 05 May 2022 01:46:57 -0700 (PDT) Received: from [192.168.0.217] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id 67-20020a1c1946000000b003942a244f2csm6771728wmz.5.2022.05.05.01.46.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 May 2022 01:46:57 -0700 (PDT) Message-ID: <313a5b2e-c571-a13f-3447-b1cd7200f4c9@linaro.org> Date: Thu, 5 May 2022 10:46:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [RFC v2 4/4] arm64: dts: rockchip: Add mt7531 dsa node to BPI-R2-Pro board Content-Language: en-US To: Vladimir Oltean , Frank Wunderlich Cc: Frank Wunderlich , linux-mediatek@lists.infradead.org, linux-rockchip@lists.infradead.org, Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , Sean Wang , Landen Chao , DENG Qingfang , Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Matthias Brugger , Peter Geis , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org References: <20220430130347.15190-1-linux@fw-web.de> <20220430130347.15190-5-linux@fw-web.de> <20220504152450.cs2afa4hwkqp5b5m@skbuf> <20220504154720.62cwrz7frjkjbb7u@skbuf> From: Krzysztof Kozlowski In-Reply-To: <20220504154720.62cwrz7frjkjbb7u@skbuf> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/05/2022 17:47, Vladimir Oltean wrote: >> >> current device-tree nodes using "switch" and "ports" >> >> see discussioon here about make it fixed to "ports" property instead of PatternProperties including optional "ethernet-" >> >> https://patchwork.kernel.org/project/linux-mediatek/patch/20220502153238.85090-1-linux@fw-web.de/#24843155 > > Hmm, I don't get why Krzysztof said to just keep what is used in > existing device trees. The schema validator should describe what is > valid, These were talks about bindings which describe hardware. The node name, except Devicetree spec asking for generic names, does not matter here actually. > and since the mt7530 driver does not care one way or another > (some drivers do explicitly parse the "ports"/"ethernet-ports" node), > then whatever is valid for the DSA core is also valid for the mt7530 > bindings. And "ethernet-ports" is valid too, so I think it should be > accepted by mediatek.yaml... You can make it "(ethernet-)?ports" as well. My comment was purely to make it simpler, for bindings (goes into properties, not patternProperties) and for us. If you prefer to keep it like DSA core, also fine. Best regards, Krzysztof