From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753040AbcIOOyz (ORCPT <rfc822;w@1wt.eu>);
        Thu, 15 Sep 2016 10:54:55 -0400
Received: from mailout2.w1.samsung.com ([210.118.77.12]:20923 "EHLO
        mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752840AbcIOOyc (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 15 Sep 2016 10:54:32 -0400
X-AuditID: cbfec7ef-f79e76d000005b57-19-57dab62451df
Subject: Re: [PATCH v3] leds: Introduce userspace leds driver
To: Pavel Machek <pavel@ucw.cz>
Cc: David Lechner <david@lechnology.com>,
        Richard Purdie <rpurdie@rpsys.net>, linux-kernel@vger.kernel.org,
        linux-leds@vger.kernel.org, Marcel Holtmann <marcel@holtmann.org>
From: Jacek Anaszewski <j.anaszewski@samsung.com>
Message-id: <313cbae5-fd66-f0ae-79a9-a3f4273d6f9c@samsung.com>
Date: Thu, 15 Sep 2016 16:54:26 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
        Thunderbird/45.2.0
MIME-version: 1.0
In-reply-to: <20160915130831.GJ13132@amd>
Content-type: text/plain; charset=windows-1252; format=flowed
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupmleLIzCtJLcpLzFFi42LZduznOV2VbbfCDR4ftrRY1CBmcXnXHDaL
        rW/WMVp8+/SL0eLuqaNsFrt3PWV1YPNYv3s5u8en/pOsHnvm/2D1WLH6O7vH501yAaxRXDYp
        qTmZZalF+nYJXBlTtl1kLVjHVnHhtmgD4weWLkZODgkBE4l3s98wQdhiEhfurWfrYuTiEBJY
        xigxcccsZpCEkMBnRon1m4VhGp682MEMV7R5/10WCOcZo8TWaxPBOoQFbCXWbbwGNlZEQF5i
        a98KsA5mgY2MEldOLwMrYhMwlPj54jVYEa+AncTn1d8YQWwWAVWJ9nMf2bsYOThEBSIkdt9N
        hSgRlPgx+R7Y2ZwCmhKz9k1nB7GZBRwlHizayQphy0tsXvMWbJeEwDx2if9b7rKBzJEQkJXY
        dIAZ4gMXiWtdr6DeF5Z4dXwLO4QtI9HZcZAJoncyo8TFYzdZIZzVjBIbOzuhOqwlGv7/YoHY
        xicxadt0ZogFvBIdbUIQJR4SLSv+QS1zlPjQOpEdEkJvGCXuLFjPPoFRfhaSh2YheWIWkicW
        MDKvYhRJLS3OTU8tNtQrTswtLs1L10vOz93ECEwip/8df7+D8WlzyCFGAQ5GJR7eFXNvhQux
        JpYVV+YeYpTgYFYS4d22BSjEm5JYWZValB9fVJqTWnyIUZqDRUmcd++CK+FCAumJJanZqakF
        qUUwWSYOTqkGxrXXyp/affivd13x8/R7xqvK8qJjVq2vCj/88dQFCbmF2ztr9r7dLb2k/qbm
        ckHL3olfVa6HpJ3sL2/ZtXWh8b9EPu5oqcTwKuZSyZ3tV75waOg+yf+7ls9+/uVTe56wcqRP
        kVY1O1My0bJ28dfZX83//WOY33131UXObV4JSiICU3ZbSHomqiuxFGckGmoxFxUnAgC0kF/+
        HgMAAA==
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrDIsWRmVeSWpSXmKPExsVy+t/xq7rft94KN/j2WcpiUYOYxeVdc9gs
        tr5Zx2jx7dMvRou7p46yWeze9ZTVgc1j/e7l7B6f+k+yeuyZ/4PVY8Xq7+wenzfJBbBGudlk
        pCampBYppOYl56dk5qXbKoWGuOlaKCnkJeam2ipF6PqGBCkplCXmlAJ5RgZowME5wD1YSd8u
        wS1jyraLrAXr2Cou3BZtYPzA0sXIySEhYCLx5MUOZghbTOLCvfVsXYxcHEICSxgl1t6ezgjh
        PGOUOP1lHyNIlbCArcS6jdeYQGwRAXmJrX0rmCGKXjFK/Fr4igXEYRbYyCjxuW892Fw2AUOJ
        ny9eg3XwCthJfF79DWwSi4CqRPu5j+wgtqhAhMStVR8ZIWoEJX5Mvgd2H6eApsSsfdPBapiB
        Ni94v44FwpaX2LzmLfMERoFZSFpmISmbhaRsASPzKkaR1NLi3PTcYkO94sTc4tK8dL3k/NxN
        jMCY2nbs5+YdjJc2Bh9iFOBgVOLhDZh9K1yINbGsuDL3EKMEB7OSCO+2LUAh3pTEyqrUovz4
        otKc1OJDjKZAT0xklhJNzgfGe15JvKGJobmloZGxhYW5kZGSOG/JhyvhQgLpiSWp2ampBalF
        MH1MHJxSDYzTN7O+XrIv9H1i41G3sqfad/ddW/HUYDrnGocdjw0/dC6/x3Pk0oS/1v2BLj8+
        8ize8DS7ZkKtwE3TO3xRDDxTbSUfPNBbKSlXmDtznU5wSMJ3hr5FST2eh//eVVt8MefWj4Ui
        Yj2i03SeupZkfVmv8+p77BPmivkzL1rL8y9kX5O/QnLb6lYNJZbijERDLeai4kQALqz5Pr8C        AAA=
X-MTR: 20000000000000000@CPGS
X-CMS-MailID: 20160915145427eucas1p2aeca412a764725cf4adbac3e31d36bbf
X-Msg-Generator: CA
X-Sender-IP: 182.198.249.179
X-Local-Sender: =?UTF-8?B?SmFjZWsgQW5hc3pld3NraRtTUlBPTC1TeXN0ZW0gRlcgIChN?=
        =?UTF-8?B?Qikb7IK87ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?=
X-Global-Sender: =?UTF-8?B?SmFjZWsgQW5hc3pld3NraRtTUlBPTC1TeXN0ZW0gRlcgIChN?=
        =?UTF-8?B?QikbU2Ftc3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgU29mdHdhcmUgRW5naW5l?=
        =?UTF-8?B?ZXI=?=
X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjc1MjY=?=
CMS-TYPE: 201P
X-HopCount: 7
X-CMS-RootMailID: 20160912081846eucas1p255044e49034685ad44400d6830ef0b95
X-RootMTR: 20160912081846eucas1p255044e49034685ad44400d6830ef0b95
References: <1473439776-15655-1-git-send-email-david@lechnology.com>
 <CGME20160912081846eucas1p255044e49034685ad44400d6830ef0b95@eucas1p2.samsung.com>
 <80597ded-f4b4-2990-3eae-e72276296d1a@samsung.com> <20160915130831.GJ13132@amd>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Pavel,

On 09/15/2016 03:08 PM, Pavel Machek wrote:
> Hi!
>
>>> +	if (copy_from_user(&udev->user_dev, buffer,
>>> +			   sizeof(struct uleds_user_dev))) {
>>> +		ret = -EFAULT;
>>> +		goto out;
>>> +	}
>>> +
>>> +	if (!udev->user_dev.name[0]) {
>>> +		ret = -EINVAL;
>>> +		goto out;
>>> +	}
>>> +
>>> +	ret = led_classdev_register(NULL, &udev->led_cdev);
>>> +	if (ret < 0)
>>> +		goto out;
>
> No sanity checking on the name -> probably a security hole. Do not
> push this upstream before this is fixed.

Thanks for catching this.

David, please check if the LED name sticks to the LED class
device naming convention.

And one thing that caught my eye only now - please use
devm_led_classdev_register().

For now I'm dropping the patch.

-- 
Best regards,
Jacek Anaszewski