mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
To: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Geert Uytterhoeven" <geert+renesas@glider.be>,
	"Sakari Ailus" <sakari.ailus@linux.intel.com>,
	"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
	linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/4] media: rcar-csi2: Add D-PHY support for V4H
Date: Fri, 30 May 2025 15:31:05 +0300	[thread overview]
Message-ID: <313e359f-460f-4c3e-b4bd-f3281673135d@ideasonboard.com> (raw)
In-Reply-To: <20250511174730.944524-1-niklas.soderlund+renesas@ragnatech.se>

Hi,

On 11/05/2025 20:47, Niklas Söderlund wrote:
> Hello,
> 
> This series adds support for CSI-2 D-PHY reception on R-Car Gen4 V4H
> devices. Previously only C-PHY reception due to poor documentation and
> no hardware to test D-PHY on.
> 
> Later revisions of the datasheet (Rev.1.21) describes the start-up
> procedure in some detail, and we now have hardware to test on! The
> documentation however only sparsely documents the registers involved and
> instead mostly document magic values and an order to write them to
> register offsets without much documentation.
> 
> This series tries to in the extend possible to at least used named
> register and use formulas and lookup tables to make some sens of the
> magic values. Still most of them comes of a table of magic values in the
> datasheet.
> 
> Patch 1/4 clears up a unfortunate mix of the name mbps (mega bits per
> second) used in the D-PHY context and msps (mega symbols per second)
> used in the C-PHY context.
> 
> Patch 2/4 and 3/4 prepares for adding D-PHY support by cleaning up
> register names and an updated common startup procedure for V4H which
> have been revised in later versions of the datasheet since the initial
> C-PHY V4H support was added.
> 
> Finally patch 4/4 adds D-PHY support.
> 
> The work is to great extent at many different link speed and number of
> lanes. In 2-lane mode using an IMX219 and in 4-lane mode using IMX462
> sensors.
> 
> See individual patches for change log.
> 
> Niklas Söderlund (4):
>   media: rcar-csi2: Clarify usage of mbps and msps
>   media: rcar-csi2: Rework macros to access AFE lanes
>   media: rcar-csi2: Update start procedure for V4H
>   media: rcar-csi2: Add D-PHY support for V4H
> 
>  drivers/media/platform/renesas/rcar-csi2.c | 447 ++++++++++++++++++---
>  1 file changed, 402 insertions(+), 45 deletions(-)
> 

On my V4H + GMSL multistream branch (i.e. C-PHY):

Tested-by: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>

 Tomi


      parent reply	other threads:[~2025-05-30 12:31 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-11 17:47 Niklas Söderlund
2025-05-11 17:47 ` [PATCH v2 1/4] media: rcar-csi2: Clarify usage of mbps and msps Niklas Söderlund
2025-05-30 12:31   ` Tomi Valkeinen
2025-05-30 13:04   ` Laurent Pinchart
2025-05-11 17:47 ` [PATCH v2 2/4] media: rcar-csi2: Rework macros to access AFE lanes Niklas Söderlund
2025-05-30 13:06   ` Laurent Pinchart
2025-05-11 17:47 ` [PATCH v2 3/4] media: rcar-csi2: Update start procedure for V4H Niklas Söderlund
2025-05-30 13:42   ` Laurent Pinchart
2025-05-11 17:47 ` [PATCH v2 4/4] media: rcar-csi2: Add D-PHY support " Niklas Söderlund
2025-05-11 19:07   ` ALOK TIWARI
2025-05-11 20:03     ` Niklas Söderlund
2025-05-12  7:37       ` Geert Uytterhoeven
2025-05-12  8:48         ` Niklas Söderlund
2025-05-30 13:38           ` Laurent Pinchart
2025-05-30 12:31 ` Tomi Valkeinen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=313e359f-460f-4c3e-b4bd-f3281673135d@ideasonboard.com \
    --to=tomi.valkeinen+renesas@ideasonboard.com \
    --cc=geert+renesas@glider.be \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=niklas.soderlund+renesas@ragnatech.se \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®