From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D34E36C5A1 for ; Wed, 14 Jan 2026 06:37:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768372661; cv=none; b=Xwui+Qv4odiXCDI+Zk/isp3N4o2saDVZdvby8Xjg59V3hnBAZdKaWn/P+sWxEEoZV+TZv9ZTQYlLHD0cETl2HsTs1lR3hkjLHoxVJQMDzmUJITfKy7R3c1ZsItbhcaSWU2VNBXUifldzx4bRp4QiwsjUx0S5mNpKYRqaEAlyBYU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768372661; c=relaxed/simple; bh=RzIjDmRcOusdLVG/Z/S9Qc24M/jxtlfD2LQCgYeNkL0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rkkWv4HACgFIqDbNU8pynkxELZjqHq6kFguEPXucGDGEZDIxzYvgHWPQOW74NoiulEoKdBLr9hF5l1SpTHE9R592nUBSV+cvj1+ZxESDDP/yt4HEvPUa894iDmkeq3zGMJE2QBtI8P53ou7sSnNd7V8VoZ5bCY0XBqy3BbXMIdI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=P7MCmfJ6; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=e/Bqv71K; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="P7MCmfJ6"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="e/Bqv71K" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60E66qQD3061708 for ; Wed, 14 Jan 2026 06:37:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= GCcmZoBzN/A3JPIeppt/PGfNgz11ZDMQFaZXR2up6DI=; b=P7MCmfJ6SjTJn5WA S+Ivy2xD7sKNHJkxILSng+KfJQrOT3sOR0vk7rxx/c8eNiv2IgNKrkFQ2vTN6Wnw CR9z7nHplebMmdjNOrsA5rqhAUxv7BSp8IN3bB650qa+8B6B99B3QiavNcbeb1V8 qX9TtiST1LvPD8nVDVVBK8gMwhUfbWzvq5r/F0Mx4Q7YckEIb5Xg1FHFab03vi+F YcO4vUWqPozCV25NSIgsVyIARdSkqzjpX3Ckp7xp9mmBECiuZBuY+A6BdOHrkKY5 2Sgm8bwsI2Gqg3VLQK+HMrPrOujeqLnmPr3c65SZW1uDO8rwlpB75UxIagre0G2s FJs8UQ== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bns8v2js3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 14 Jan 2026 06:37:28 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2a0a8c465c1so3867355ad.1 for ; Tue, 13 Jan 2026 22:37:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768372648; x=1768977448; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=GCcmZoBzN/A3JPIeppt/PGfNgz11ZDMQFaZXR2up6DI=; b=e/Bqv71Kntr0Y+S+UgJ4AtJ1Otk4qvkKBLcqLaZ7tD6wCMroRAMvX8LKs4dMFcadmh EWIfpZLLPT2Ep5QLtplrLhKWjlK/2jlcJF2bgf36hEbyNaE7yoUhm5evsDe0JF9Ujrsx kbPwxC0Yt3n71tM3lS7mlJzYIDmPCCijkp66yb4Hi55SAJtbHo+NdOHAO0lOh1z7MsUN zWqyEjnFjGild+hn/axGXCNzRpPJYwvx85L0snXlWOACUUzSOi8dp0gd+E/53LmSa/92 MvixycQSSdcyUpulCaUSSW3R/+aWMtcFd6V9KaKpVy+tTtqjuvKc5f940njW51TJ8mQ8 nVUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768372648; x=1768977448; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GCcmZoBzN/A3JPIeppt/PGfNgz11ZDMQFaZXR2up6DI=; b=VI7OuNsYQH5/3XGd+mBndvLIpWMEcolpKYsDGFauTiLW+R/KsI0TPoJJeyERcJVUlI qvcSPQfD853IyV2HKs7eXeHJ7AkEKaiCkkfsvDGcvuzMaKMzyasWwevYWBuYHotMZSCb VjMgs6Ky2fK1flBv9+L2ScBNbnA3CF4P16U/1oDTW0nQlud5023rlBvhrvaq75VJ0OIe i6v2aeWESVqQIx+pL9AqivL55Yq4QkfGJ1RGziznZlOqzUhRpulJuagv/hHHsbtxqu33 VxGcPMPTWhBmizNvCNz/6mJlbe6B4G4wZ5CJUo7UprhmHZL0Qldv23z62n52Y/zfTlE1 FRxQ== X-Forwarded-Encrypted: i=1; AJvYcCVDWx3toiYRsj6wKt8cN1Lkm6KF2EPMZ0cM110D8K9NRfZdeCgB4vyyCMM6OH/BX/d24wztYhT+dSwO6LQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwCo0tT/+iPn0FIqCDKJ5Z3AzZZwOh70ANky8CO2e8TJmiSOsuh ihWZCP9Knc72Xo2Cmh63irIghASGzCq8VaT8VeLiXtLH2f/E8z/IfM83EKPOu8gFHW8S4ZAHgEn i+cG3yCXx0BrePSfhZCHGKFpXolF450XDjpdA5CtRHlgsu5RT5dpjXEuLDnRAtOBqbNY= X-Gm-Gg: AY/fxX5S5dlCbSSMnTvVdiUJhOBbw1EQJ++wgGA0CC1i+IQAChtjFQbHDxFsurN74om ipZnVyAAiFuZyW+eO9dvf2Fn4+OPAFdlWiaf4Koh9fd5/nBTRA2Tnn52v5cDsBPFhFNNt719kBQ NSNRA23Tt3P5HdNsBB68M10mySUZeeNHbmX1PtIvN/oneGpaUYAb8l4v4CNpDxC1KAr4bnA/M7j LcOmr9Tr4/LCenyiw8J+1zLXlnGaJoLsh4e+8ypdk25X9P0XCvzp80Ka2hox1FGEE/7YvGgUPq2 l/VoqfTecdbcuZxxlwsuTBM5Rdqq7g6A5UrnTxi0n7BcWGX/NfWftKPrPH7wql4CKn1yAcQNdo7 neRqliSjjCQBT4K9YQZsSfPw9z7536ZiVCQ== X-Received: by 2002:a17:903:41c3:b0:2a0:f0bf:197a with SMTP id d9443c01a7336-2a599dac241mr16267545ad.13.1768372647622; Tue, 13 Jan 2026 22:37:27 -0800 (PST) X-Received: by 2002:a17:903:41c3:b0:2a0:f0bf:197a with SMTP id d9443c01a7336-2a599dac241mr16267315ad.13.1768372647065; Tue, 13 Jan 2026 22:37:27 -0800 (PST) Received: from [192.168.1.7] ([106.222.229.124]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3cb2b72sm218575885ad.51.2026.01.13.22.37.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jan 2026 22:37:26 -0800 (PST) Message-ID: <3149158c-a6c4-4c5d-9011-de4db8d1220c@oss.qualcomm.com> Date: Wed, 14 Jan 2026 12:07:20 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC RFT] drm/msm: adreno: attach the GMU device to a driver To: Neil Armstrong Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter References: <20251022-topic-adreno-attach-gmu-to-driver-v1-1-999037f7c83e@linaro.org> Content-Language: en-US From: Akhil P Oommen In-Reply-To: <20251022-topic-adreno-attach-gmu-to-driver-v1-1-999037f7c83e@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=aY5sXBot c=1 sm=1 tr=0 ts=696739a8 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=ZIcQe8sNaMnfUD2ODhXWYw==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=KKAkSRfTAAAA:8 a=9eDHubkGBslCoLSAWpMA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: XQeePnlHuRBGEBvx9GvM8tBKWrGvdugw X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE0MDA0OSBTYWx0ZWRfX9tmvutI9bcWT pN4BO7mUZxvf6wtzM6EjwmjM6OT2dFbiRj0fD1+nAJJGY0rPaVOOpE0ohSGqrAhSXbzcyHaDoH/ PAOiNzEaxTd+gj+wfLg2KeEzwtXX+i1uVE7XOqbnGFQbZU06tHkst7xUUZlXf6Tp1xoOofPW1z3 KlXl9hNwJK9o2TF6+pdPyUXymyju00vYp/OaCK2fnzCuyUwoKy7O1BZqhW7pvR0h304uUlQvAN/ AcmeylF1geuU4MN8zqY18OAefgdG5Z5QKV7BeyPg+Sph4sM+3Hh/i3VJILen6VXrA6V+EiD8Ah9 astT0/ZJ5vYIMqhFRf4YwbdblGcF5GKYEB7WYZ/QQpKaPyNcWuydHvJOCtHaYIQKN/weYSxj4aG bbgQBNFkhAA/Kl7JG8OQfjIlav311ElbQBUdQFsOENqfEoNmPtVcH8647BoFAqwroSV8zgq5Vfw 7iUJ4gZfCIl7hHFaIpg== X-Proofpoint-GUID: XQeePnlHuRBGEBvx9GvM8tBKWrGvdugw X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-14_02,2026-01-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 suspectscore=0 malwarescore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 adultscore=0 phishscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601140049 On 10/22/2025 6:14 PM, Neil Armstrong wrote: > Due to the sync_state is enabled by default in pmdomain & CCF since v6.17, > the GCC and GPUCC sync_state would stay pending, leaving the resources in > full performance: > gcc-x1e80100 100000.clock-controller: sync_state() pending due to 3d6a000.gmu > gpucc-x1e80100 3d90000.clock-controller: sync_state() pending due to 3d6a000.gmu > > In order to fix this state and allow the GMU to be properly > probed, let's add a proper driver for the GMU and add it to > the MSM driver components. > > Only the proper GMU has been tested since I don't have > access to hardware with a GMU wrapper. > > Signed-off-by: Neil Armstrong > --- > drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 354 ++++++++++++++--------------- > drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 6 - > drivers/gpu/drm/msm/adreno/a6xx_gpu.h | 3 - > drivers/gpu/drm/msm/adreno/adreno_device.c | 4 + > drivers/gpu/drm/msm/adreno/adreno_gpu.h | 4 + > drivers/gpu/drm/msm/msm_drv.c | 16 +- > 6 files changed, 192 insertions(+), 195 deletions(-) > Niel, Could you please send the follow up revision of this patch? Lets get this fix merged. -Akhil.