From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753333AbeADPFX (ORCPT + 1 other); Thu, 4 Jan 2018 10:05:23 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:33680 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753190AbeADPFV (ORCPT ); Thu, 4 Jan 2018 10:05:21 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20180104150519epoutp02ca5fe9e28a3b8d98ecdf246d6f597127~Go7Q6XgYl3128131281epoutp02K X-AuditID: b6c32a46-9adff700000010ee-c8-5a4e42ae1a6d From: Bartlomiej Zolnierkiewicz To: "Pieter \"PoroCYon\" Sluys" Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: Re: [PATCH] vfb: fix video mode and line_length being set when loaded Date: Thu, 04 Jan 2018 16:05:15 +0100 Message-id: <3149875.iSmVjzXX7W@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <81bf0d1e-ee7a-29ea-d19e-ffeb41d285fe@national.shitposting.agency> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset="us-ascii" X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrMIsWRmVeSWpSXmKPExsWy7bCmme46J78og6cbeS2e3drLZHGi7wOr xeVdc9gstj6cwubA4nHocAejx8ljP1k8Pm+SC2CO4rJJSc3JLEst0rdL4MrY+Osma0EHT8Xn ZVvYGxgnc3YxcnJICJhInJl+h62LkYtDSGAHo8Srth4o5zujxM/WDhaYqs2Xe1ggEruBqj5f YQNJCAl8ZZTY31cJYrMJWElMbF/FCGKLCDhKXF21nRnEZhbIkjix4iwriC0sECCx+Pw3sF4W AVWJ12+Pg9XzCmhKzG1czw5iiwp4SWzZ184EYnMK+Eu0XPrOClEjKPFj8j0WiJnyEvv2T2WF sHUkzh5bxwhynITADDaJCSt7mCGudpH40vqHDcIWlnh1fAs7hC0t8WzVRkYIezqjxPbfEhDN mxklVu2eAFVkLXH4+EWoDXwSHYf/AsU5gOK8Eh1tQhAlHhKzTz+HhpCjxMf5W5ggIfScUeLB wqvMExhlZyE5fBaSw2chOXwBI/MqRrHUguLc9NRiowIjveLE3OLSvHS95PzcTYzgqNdy28G4 5JzPIUYBDkYlHt4V6n5RQqyJZcWVuYcYJTiYlUR4OY2AQrwpiZVVqUX58UWlOanFhxilOViU xHlbA1yihATSE0tSs1NTC1KLYLJMHJxSDYz+MTeuGD1P77A8l9XpcvM4T8eWx8v//5V+Lzbd OmN51E27+C2uu1sTZCO8d8rwbZ/BcEZg4/VpfS+LBNI2uJ35FjpVxdz/oFLb7en2c8K2XDBY o/PXd2O/8t5Tp+2YNM9/LRco2/T9cepmvZbg12IbS91qRGYrLf9z9QXba63sA2tMavoUV1kq sRRnJBpqMRcVJwIAUzGmCPYCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrNLMWRmVeSWpSXmKPExsVy+t9jAd21Tn5RBis6+S2e3drLZHGi7wOr xeVdc9gstj6cwubA4nHocAejx8ljP1k8Pm+SC2CO4rJJSc3JLEst0rdL4MrY+Osma0EHT8Xn ZVvYGxgnc3YxcnJICJhIbL7cw9LFyMUhJLCTUaJ50lwo5yujxLOX05lAqtgErCQmtq9iBLFF BBwlrq7aztzFyMHBLJAlsWa/JkhYWMBPorvzJ1g5i4CqxOu3x8HKeQU0JeY2rmcHsUUFvCS2 7GsHq+EU8JdoufSdFWLXc0aJ52fmMUM0CEr8mHyPBcRmFpCX2Ld/KiuErSWxfudxpgmM/LOQ lM1CUjYLSdkCRuZVjJKpBcW56bnFRgVGeanlesWJucWleel6yfm5mxiBQbrtsFb/DsbHS+IP MQpwMCrx8K5Q94sSYk0sK67MPcQowcGsJMLLaQQU4k1JrKxKLcqPLyrNSS0+xCjNwaIkzsuf fyxSSCA9sSQ1OzW1ILUIJsvEwSnVwJj0N/BE6LnYlhN8uZP/WHnJLa61WCo799mCrHVWBSYi EQ5qmzXndq86tm+pl5bcpKgTN7+8ztQ5yHznieg2Idv9qkZds6KqsldOPL7R0+NUTA9fouDE qqZp7d2u2klWy8yXZYY88L5970+ORPI3KZfC2GvZlYp/nrobbc/ROXinO75L8cmr20osxRmJ hlrMRcWJANwg/nlOAgAA X-CMS-MailID: 20180104150517epcas2p1c44a5c7c52e30798d3405e92a833158d X-Msg-Generator: CA CMS-TYPE: 102P X-CMS-RootMailID: 20171220145325epcas4p2734200912e99f122f834413362cf6504 X-RootMTR: 20171220145325epcas4p2734200912e99f122f834413362cf6504 References: <39a57338-18ac-c64f-1cf1-70a5f905990a@national.shitposting.agency> <81bf0d1e-ee7a-29ea-d19e-ffeb41d285fe@national.shitposting.agency> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Wednesday, December 20, 2017 02:53:00 PM Pieter PoroCYon Sluys wrote: > Geert Uytterhoeven: > > Please add your "Signed-off-by", cfr. > > Documentation/process/submitting-patches.rst. > > Sorry I knew I would've messed up *something*. > > > You can drop the tests for 2 and 4, as these are no longer used by the driver. > > Done that. > > Cc: Bartlomiej Zolnierkiewicz > Signed-off-by: Pieter "PoroCYon" Sluys I've queued your patch for 4.16 kernel (after fixing few minor issues [*]), thanks! [*] next time please remember to: * always include full patch description in the later patch revisions * put things that don't belong to patch description after "---" so they will not be included in the final commit * in the later patch revisions include ChangeLog after "---" and also put patch version in the patch summary line / mail subject (i.e. "[PATCH v2] ...") * add tags (i.e. "Reviewed-by: ...") from patch reviewers / testers into the patch description * check your patch with scripts/checkpatch.pl tool and fix reported issues, i.e.: ERROR: switch and case should be at the same indent #69: FILE: drivers/video/fbdev/vfb.c:242: + switch (info->var.bits_per_pixel) { + case 1: [...] + case 8: [...] + case 16: + case 24: + case 32: Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics